public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/102280] New: span'
@ 2021-09-10 17:43 joeloser93 at gmail dot com
  2021-09-10 17:44 ` [Bug c++/102280] span's range deduction guide is missing contiguous_iterator constraint joeloser93 at gmail dot com
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: joeloser93 at gmail dot com @ 2021-09-10 17:43 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102280

            Bug ID: 102280
           Summary: span'
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: joeloser93 at gmail dot com
  Target Milestone: ---

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug c++/102280] span's range deduction guide is missing contiguous_iterator constraint
  2021-09-10 17:43 [Bug c++/102280] New: span' joeloser93 at gmail dot com
@ 2021-09-10 17:44 ` joeloser93 at gmail dot com
  2021-09-10 17:47 ` [Bug c++/102280] span's range deduction guide is missing ranges::contiguous_range constraint joeloser93 at gmail dot com
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: joeloser93 at gmail dot com @ 2021-09-10 17:44 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102280

--- Comment #1 from Joe Loser <joeloser93 at gmail dot com> ---
`span` has a range deduction guide, but it is not properly constrained for
ranges satisfying `contiguous_iterator` concept only at
https://github.com/gcc-mirror/gcc/blob/01b5038718056b024b370b74a874fbd92c5bbab3/libstdc%2B%2B-v3/include/std/span#L412
per 22.7.3.3 in the working draft.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug c++/102280] span's range deduction guide is missing ranges::contiguous_range constraint
  2021-09-10 17:43 [Bug c++/102280] New: span' joeloser93 at gmail dot com
  2021-09-10 17:44 ` [Bug c++/102280] span's range deduction guide is missing contiguous_iterator constraint joeloser93 at gmail dot com
@ 2021-09-10 17:47 ` joeloser93 at gmail dot com
  2021-09-13  9:42 ` [Bug libstdc++/102280] " redi at gcc dot gnu.org
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: joeloser93 at gmail dot com @ 2021-09-10 17:47 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102280

--- Comment #2 from Joe Loser <joeloser93 at gmail dot com> ---
Sorry, typo in previous comment. The `span` range deduction guide should
constrain on `ranges::contiguous_range`, not `contiguous_iterator` concept --
sorry. This is from P1394 (https://wg21.link/p1394).

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libstdc++/102280] span's range deduction guide is missing ranges::contiguous_range constraint
  2021-09-10 17:43 [Bug c++/102280] New: span' joeloser93 at gmail dot com
  2021-09-10 17:44 ` [Bug c++/102280] span's range deduction guide is missing contiguous_iterator constraint joeloser93 at gmail dot com
  2021-09-10 17:47 ` [Bug c++/102280] span's range deduction guide is missing ranges::contiguous_range constraint joeloser93 at gmail dot com
@ 2021-09-13  9:42 ` redi at gcc dot gnu.org
  2021-09-16 22:05 ` cvs-commit at gcc dot gnu.org
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: redi at gcc dot gnu.org @ 2021-09-13  9:42 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102280

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
   Last reconfirmed|                            |2021-09-13
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libstdc++/102280] span's range deduction guide is missing ranges::contiguous_range constraint
  2021-09-10 17:43 [Bug c++/102280] New: span' joeloser93 at gmail dot com
                   ` (2 preceding siblings ...)
  2021-09-13  9:42 ` [Bug libstdc++/102280] " redi at gcc dot gnu.org
@ 2021-09-16 22:05 ` cvs-commit at gcc dot gnu.org
  2021-09-16 22:12 ` redi at gcc dot gnu.org
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-09-16 22:05 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102280

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:e67917f5df9d84f5aed3513b3931a82870d25135

commit r12-3591-ge67917f5df9d84f5aed3513b3931a82870d25135
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Sep 15 21:49:29 2021 +0100

    libstdc++: Add missing constraint to std::span deduction guide [PR102280]

    Signed-off-by: Jonathan Wakely <jwakely@redhat.com>

    libstdc++-v3/ChangeLog:

            PR libstdc++/102280
            * include/std/span (span(Range&&)): Add constraint to deduction
            guide.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libstdc++/102280] span's range deduction guide is missing ranges::contiguous_range constraint
  2021-09-10 17:43 [Bug c++/102280] New: span' joeloser93 at gmail dot com
                   ` (3 preceding siblings ...)
  2021-09-16 22:05 ` cvs-commit at gcc dot gnu.org
@ 2021-09-16 22:12 ` redi at gcc dot gnu.org
  2021-09-20 20:47 ` joeloser93 at gmail dot com
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: redi at gcc dot gnu.org @ 2021-09-16 22:12 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102280

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.4

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libstdc++/102280] span's range deduction guide is missing ranges::contiguous_range constraint
  2021-09-10 17:43 [Bug c++/102280] New: span' joeloser93 at gmail dot com
                   ` (4 preceding siblings ...)
  2021-09-16 22:12 ` redi at gcc dot gnu.org
@ 2021-09-20 20:47 ` joeloser93 at gmail dot com
  2021-09-21  1:48 ` redi at gcc dot gnu.org
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: joeloser93 at gmail dot com @ 2021-09-20 20:47 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102280

--- Comment #4 from Joe Loser <joeloser93 at gmail dot com> ---
Johnathan, your fix LGTM. Safe to mark this as resolved, or do you need to do
something to backport it for the 10.4 release branch?

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libstdc++/102280] span's range deduction guide is missing ranges::contiguous_range constraint
  2021-09-10 17:43 [Bug c++/102280] New: span' joeloser93 at gmail dot com
                   ` (5 preceding siblings ...)
  2021-09-20 20:47 ` joeloser93 at gmail dot com
@ 2021-09-21  1:48 ` redi at gcc dot gnu.org
  2021-09-21  1:50 ` redi at gcc dot gnu.org
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: redi at gcc dot gnu.org @ 2021-09-21  1:48 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102280

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I've set the Target Milestone field to indicate is going to be fixed for 10.4

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libstdc++/102280] span's range deduction guide is missing ranges::contiguous_range constraint
  2021-09-10 17:43 [Bug c++/102280] New: span' joeloser93 at gmail dot com
                   ` (6 preceding siblings ...)
  2021-09-21  1:48 ` redi at gcc dot gnu.org
@ 2021-09-21  1:50 ` redi at gcc dot gnu.org
  2021-10-12 10:58 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: redi at gcc dot gnu.org @ 2021-09-21  1:50 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102280

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I.e. please don't mark it as resolved, I'll do that when it's resolved.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libstdc++/102280] span's range deduction guide is missing ranges::contiguous_range constraint
  2021-09-10 17:43 [Bug c++/102280] New: span' joeloser93 at gmail dot com
                   ` (7 preceding siblings ...)
  2021-09-21  1:50 ` redi at gcc dot gnu.org
@ 2021-10-12 10:58 ` cvs-commit at gcc dot gnu.org
  2021-10-12 16:28 ` cvs-commit at gcc dot gnu.org
  2021-10-12 16:31 ` redi at gcc dot gnu.org
  10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-10-12 10:58 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102280

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:95d404d85c53e4ab821ac28cbbbedf0d68cac8da

commit r11-9102-g95d404d85c53e4ab821ac28cbbbedf0d68cac8da
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Sep 15 21:49:29 2021 +0100

    libstdc++: Add missing constraint to std::span deduction guide [PR102280]

    Signed-off-by: Jonathan Wakely <jwakely@redhat.com>

    libstdc++-v3/ChangeLog:

            PR libstdc++/102280
            * include/std/span (span(Range&&)): Add constraint to deduction
            guide.

    (cherry picked from commit e67917f5df9d84f5aed3513b3931a82870d25135)

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libstdc++/102280] span's range deduction guide is missing ranges::contiguous_range constraint
  2021-09-10 17:43 [Bug c++/102280] New: span' joeloser93 at gmail dot com
                   ` (8 preceding siblings ...)
  2021-10-12 10:58 ` cvs-commit at gcc dot gnu.org
@ 2021-10-12 16:28 ` cvs-commit at gcc dot gnu.org
  2021-10-12 16:31 ` redi at gcc dot gnu.org
  10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-10-12 16:28 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102280

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:1a27df25a71bb0d6a5dfb0162d1867d308f8f33f

commit r10-10184-g1a27df25a71bb0d6a5dfb0162d1867d308f8f33f
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Sep 15 21:49:29 2021 +0100

    libstdc++: Add missing constraint to std::span deduction guide [PR102280]

    Signed-off-by: Jonathan Wakely <jwakely@redhat.com>

    libstdc++-v3/ChangeLog:

            PR libstdc++/102280
            * include/std/span (span(Range&&)): Add constraint to deduction
            guide.

    (cherry picked from commit e67917f5df9d84f5aed3513b3931a82870d25135)

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libstdc++/102280] span's range deduction guide is missing ranges::contiguous_range constraint
  2021-09-10 17:43 [Bug c++/102280] New: span' joeloser93 at gmail dot com
                   ` (9 preceding siblings ...)
  2021-10-12 16:28 ` cvs-commit at gcc dot gnu.org
@ 2021-10-12 16:31 ` redi at gcc dot gnu.org
  10 siblings, 0 replies; 12+ messages in thread
From: redi at gcc dot gnu.org @ 2021-10-12 16:31 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102280

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 10.4 and 11.3

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-10-12 16:31 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-10 17:43 [Bug c++/102280] New: span' joeloser93 at gmail dot com
2021-09-10 17:44 ` [Bug c++/102280] span's range deduction guide is missing contiguous_iterator constraint joeloser93 at gmail dot com
2021-09-10 17:47 ` [Bug c++/102280] span's range deduction guide is missing ranges::contiguous_range constraint joeloser93 at gmail dot com
2021-09-13  9:42 ` [Bug libstdc++/102280] " redi at gcc dot gnu.org
2021-09-16 22:05 ` cvs-commit at gcc dot gnu.org
2021-09-16 22:12 ` redi at gcc dot gnu.org
2021-09-20 20:47 ` joeloser93 at gmail dot com
2021-09-21  1:48 ` redi at gcc dot gnu.org
2021-09-21  1:50 ` redi at gcc dot gnu.org
2021-10-12 10:58 ` cvs-commit at gcc dot gnu.org
2021-10-12 16:28 ` cvs-commit at gcc dot gnu.org
2021-10-12 16:31 ` redi at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).