[Bug fortran/102332] New: ICE in select_type_set_tmp, at fortran/match.c:6366

[Bug fortran/102332] New: ICE in select_type_set_tmp, at fortran/match.c:6366

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102332

            Bug ID: 102332
           Summary: ICE in select_type_set_tmp, at fortran/match.c:6366
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

With a missing attribute allocatable or pointer :
(down to at least r5)


$ cat z1.f90
program p
   type t
      real :: a, b
   end type
   class(t) :: x
   select type (y => x)
   type is (t)
      y%a = 0
   end select
end


$ cat z2.f90
program p
   type t
      real :: a, b
   end type
   class(t), allocatable :: x
   select type (y => x)
   type is (t)
      y%a = 0
   end select
end


$ gfortran-12-20210905 -c z2.f90   # ok
$
$ gfortran-12-20210905 -c z1.f90
f951: internal compiler error: Segmentation fault
0xd09e4f crash_signal
        ../../gcc/toplev.c:328
0x78fa67 select_type_set_tmp
        ../../gcc/fortran/match.c:6366
0x798bfc gfc_match_type_is()
        ../../gcc/fortran/match.c:6901
0x7b6e01 match_word
        ../../gcc/fortran/parse.c:65
0x7bc444 decode_statement
        ../../gcc/fortran/parse.c:572
0x7bcada next_free
        ../../gcc/fortran/parse.c:1384
0x7bcada next_statement
        ../../gcc/fortran/parse.c:1616
0x7bfe31 parse_select_type_block
        ../../gcc/fortran/parse.c:4526
0x7bfe31 parse_executable
        ../../gcc/fortran/parse.c:5737
0x7c108f parse_progunit
        ../../gcc/fortran/parse.c:6140
0x7c2771 gfc_parse_file()
        ../../gcc/fortran/parse.c:6655
0x80f57f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:216

[Bug fortran/102332] ICE in select_type_set_tmp, at fortran/match.c:6366

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102332

G. Steinmetz <gscfq@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code

--- Comment #1 from G. Steinmetz <gscfq@t-online.de> ---

And also :


$ cat zz1.f90
program p
   type t
      real :: a, b
   end type
   class(t) :: x
   select type (y => x)
   class is (t)
      y%a = 0
   end select
end


$ cat zz4.f90
program p
   type t
      real :: a, b
   end type
   class(t) :: x
   select type (y => x)
   class default
      y%a = 0
   end select
end


$ cat z3.f90
program p
   type t
      real :: a, b
   end type
   class(t) :: x
   select type (y => x)
   type default
      y%a = 0
   end select
end

[Bug fortran/102332] ICE in select_type_set_tmp, at fortran/match.c:6366

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102332

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-09-15
                 CC|                            |marxin at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

[Bug fortran/102332] ICE in select_type_set_tmp, at fortran/match.c:6366

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102332

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #2 from anlauf at gcc dot gnu.org ---
Created attachment 52071
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52071&action=edit
Tentative patch

There are several NULL pointer dereferences exhibited by the various testcases
which are addressed by this patch.

[Bug fortran/102332] ICE in select_type_set_tmp, at fortran/match.c:6366

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102332

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
           Priority|P3                          |P4
             Status|NEW                         |ASSIGNED

--- Comment #3 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2021-December/057228.html

[Bug fortran/102332] ICE in select_type_set_tmp, at fortran/match.c:6366

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102332

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:d8f6c48ccb85ecc0d97a84c32b7a1b8f43c64fe4

commit r12-6143-gd8f6c48ccb85ecc0d97a84c32b7a1b8f43c64fe4
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Dec 27 23:06:18 2021 +0100

    Fortran: avoid several NULL pointer dereferences during error recovery

    gcc/fortran/ChangeLog:

            PR fortran/102332
            * expr.c (gfc_get_variable_expr): Avoid NULL pointer dereferences
            during handling of errors with invalid uses of CLASS variables.
            * match.c (select_type_set_tmp): Likewise.
            * primary.c (gfc_match_varspec): Likewise.
            * resolve.c (resolve_variable): Likewise.
            (resolve_select_type): Likewise.

    gcc/testsuite/ChangeLog:

            PR fortran/102332
            * gfortran.dg/pr102332.f90: New test.

[Bug fortran/102332] ICE in select_type_set_tmp, at fortran/match.c:6366

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102332

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:718b47e1cd4e667ef3e9b24630f0a2d923d7c802

commit r11-9428-g718b47e1cd4e667ef3e9b24630f0a2d923d7c802
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Dec 27 23:06:18 2021 +0100

    Fortran: avoid several NULL pointer dereferences during error recovery

    gcc/fortran/ChangeLog:

            PR fortran/102332
            * expr.c (gfc_get_variable_expr): Avoid NULL pointer dereferences
            during handling of errors with invalid uses of CLASS variables.
            * match.c (select_type_set_tmp): Likewise.
            * primary.c (gfc_match_varspec): Likewise.
            * resolve.c (resolve_variable): Likewise.
            (resolve_select_type): Likewise.

    gcc/testsuite/ChangeLog:

            PR fortran/102332
            * gfortran.dg/pr102332.f90: New test.

    (cherry picked from commit d8f6c48ccb85ecc0d97a84c32b7a1b8f43c64fe4)

[Bug fortran/102332] ICE in select_type_set_tmp, at fortran/match.c:6366

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102332

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:7bfdbb657919b5049e459e02d130056cfe3777b6

commit r10-10393-g7bfdbb657919b5049e459e02d130056cfe3777b6
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Dec 27 23:06:18 2021 +0100

    Fortran: avoid several NULL pointer dereferences during error recovery

    gcc/fortran/ChangeLog:

            PR fortran/102332
            * expr.c (gfc_get_variable_expr): Avoid NULL pointer dereferences
            during handling of errors with invalid uses of CLASS variables.
            * match.c (select_type_set_tmp): Likewise.
            * primary.c (gfc_match_varspec): Likewise.
            * resolve.c (resolve_variable): Likewise.
            (resolve_select_type): Likewise.

    gcc/testsuite/ChangeLog:

            PR fortran/102332
            * gfortran.dg/pr102332.f90: New test.

    (cherry picked from commit d8f6c48ccb85ecc0d97a84c32b7a1b8f43c64fe4)

[Bug fortran/102332] ICE in select_type_set_tmp, at fortran/match.c:6366

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102332

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |10.4

--- Comment #7 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-12, and on 11- and 10-branch.  Closing.

Thanks for the report!