public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/102374] New: Should ignore spaces in target attribute
@ 2021-09-16 18:25 pinskia at gcc dot gnu.org
2021-09-17 10:06 ` [Bug target/102374] [x86_64] " marxin at gcc dot gnu.org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-16 18:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102374
Bug ID: 102374
Summary: Should ignore spaces in target attribute
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: enhancement
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: pinskia at gcc dot gnu.org
Target Milestone: ---
Take:
void calculate_sse(void) __attribute__ ((__target__ ("no-avx, sse2")));
Currently we error out:
<source>:1:6: error: attribute ' sse2' argument 'target' is unknown
1 | void calculate_sse(void) __attribute__ ((__target__ ("no-avx, sse2")));
| ^~~~~~~~~~~~~
It was not so obvious why though, the problem is there is a space after the
comma.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/102374] [x86_64] Should ignore spaces in target attribute
2021-09-16 18:25 [Bug target/102374] New: Should ignore spaces in target attribute pinskia at gcc dot gnu.org
@ 2021-09-17 10:06 ` marxin at gcc dot gnu.org
2021-10-19 6:51 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-09-17 10:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102374
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2021-09-17
CC| |marxin at gcc dot gnu.org
Status|UNCONFIRMED |ASSIGNED
Ever confirmed|0 |1
Assignee|unassigned at gcc dot gnu.org |marxin at gcc dot gnu.org
--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
I can handle it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/102374] [x86_64] Should ignore spaces in target attribute
2021-09-16 18:25 [Bug target/102374] New: Should ignore spaces in target attribute pinskia at gcc dot gnu.org
2021-09-17 10:06 ` [Bug target/102374] [x86_64] " marxin at gcc dot gnu.org
@ 2021-10-19 6:51 ` cvs-commit at gcc dot gnu.org
2021-10-19 6:52 ` marxin at gcc dot gnu.org
2021-10-20 12:51 ` marxin at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-10-19 6:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102374
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:
https://gcc.gnu.org/g:df592811f950301ed3b10a08e476dad0f2eff26a
commit r12-4489-gdf592811f950301ed3b10a08e476dad0f2eff26a
Author: Martin Liska <mliska@suse.cz>
Date: Mon Oct 4 14:06:14 2021 +0200
target: support spaces in target attribute.
PR target/102374
gcc/ChangeLog:
* config/i386/i386-options.c (ix86_valid_target_attribute_inner_p):
Strip whitespaces.
* system.h (strip_whilespaces): New function.
gcc/testsuite/ChangeLog:
* gcc.target/i386/pr102374.c: New test.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/102374] [x86_64] Should ignore spaces in target attribute
2021-09-16 18:25 [Bug target/102374] New: Should ignore spaces in target attribute pinskia at gcc dot gnu.org
2021-09-17 10:06 ` [Bug target/102374] [x86_64] " marxin at gcc dot gnu.org
2021-10-19 6:51 ` cvs-commit at gcc dot gnu.org
@ 2021-10-19 6:52 ` marxin at gcc dot gnu.org
2021-10-20 12:51 ` marxin at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-10-19 6:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102374
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Implemented.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/102374] [x86_64] Should ignore spaces in target attribute
2021-09-16 18:25 [Bug target/102374] New: Should ignore spaces in target attribute pinskia at gcc dot gnu.org
` (2 preceding siblings ...)
2021-10-19 6:52 ` marxin at gcc dot gnu.org
@ 2021-10-20 12:51 ` marxin at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-10-20 12:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102374
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |WONTFIX
--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Reverted based on the discussion in PR102375.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-20 12:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 18:25 [Bug target/102374] New: Should ignore spaces in target attribute pinskia at gcc dot gnu.org
2021-09-17 10:06 ` [Bug target/102374] [x86_64] " marxin at gcc dot gnu.org
2021-10-19 6:51 ` cvs-commit at gcc dot gnu.org
2021-10-19 6:52 ` marxin at gcc dot gnu.org
2021-10-20 12:51 ` marxin at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).