[Bug target/102376] New: [aarch64] using target("sve") attribute without a + is not very helpful on what is wrong

[Bug target/102376] New: [aarch64] using target("sve") attribute without a + is not very helpful on what is wrong

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102376

            Bug ID: 102376
           Summary: [aarch64] using target("sve") attribute without a + is
                    not very helpful on what is wrong
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: enhancement
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---
            Target: aarch64-*-*

Take:
void calculate(void) __attribute__ ((__target__ ("sve")));

Currently GCC produces:
<source>:1:57: error: pragma or attribute 'target("sve")' is not valid
    1 | void calculate(void) __attribute__ ((__target__ ("sve")));
      |                                                         ^

But maybe it should tell you that you need to add a + in front of sve.

Also this is inconstitant with x86_64 where you don't need the + sign.

[Bug target/102376] [aarch64] using target("sve") attribute without a + is not very helpful on what is wrong

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102376

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-09-17
     Ever confirmed|0                           |1
                 CC|                            |marxin at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
I can handle it. It would be handy recommendation to users.

[Bug target/102376] [aarch64] using target("sve") attribute without a + is not very helpful on what is wrong

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102376

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Prathamesh Kulkarni
<prathamesh3492@gcc.gnu.org>:

https://gcc.gnu.org/g:145be5efaf5674a7d25c723dc5684392a6276834

commit r12-5147-g145be5efaf5674a7d25c723dc5684392a6276834
Author: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Date:   Thu Nov 11 14:37:22 2021 +0530

    [aarch64] PR102376 - Emit better diagnostic for arch extensions in target
attr.

    gcc/ChangeLog:
            PR target/102376
            * config/aarch64/aarch64.c (aarch64_process_target_attr): Check if
            token is arch extension without leading '+' and emit appropriate
            diagnostic for the same.

    gcc/testsuite/ChangeLog:
            PR target/102376
            * gcc.target/aarch64/pr102376.c: New test.

[Bug target/102376] [aarch64] using target("sve") attribute without a + is not very helpful on what is wrong

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102376

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |12.0
         Resolution|---                         |FIXED

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.