public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "msebor at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/102378] missing -Waddress in template code at definition time rather than instantiation
Date: Thu, 16 Sep 2021 22:11:27 +0000	[thread overview]
Message-ID: <bug-102378-4-dikpHSu6l0@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102378-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102378

--- Comment #3 from Martin Sebor <msebor at gcc dot gnu.org> ---
With the correct explicit instantiation directive things look much better:

$ cat pr102378.C && gcc -S -Wall pr102378.C
int f ()
{
  int a[2];
  return &a == 0;      // -Waddress (good)
}

template <class T>
int g ()
{
  {
    int a[2];
    return &a == 0;    // missing -Waddress
  }

  {
    T t;
    return &t == 0;    // no -Waddress for type-dependent expr (good)
  }

  {
    T a[2];
    return &a == 0;    // missing -Waddress
  }
}

template <class T>
int h ()
{
  {
    int a[2];
    return &a == 0;    // -Waddress (good)
  }

  {
    T t;
    return &t == 0;    // -Waddress (good)
  }

  {
    T a[2];
    return &a == 0;    // -Waddress (good)
  }
}

template int h<int> ();
pr102378.C: In function ‘int f()’:
pr102378.C:4:13: warning: the address of ‘a’ will never be NULL [-Waddress]
    4 |   return &a == 0;      // -Waddress (good)
      |          ~~~^~~~
pr102378.C: In instantiation of ‘int h() [with T = int]’:
pr102378.C:45:22:   required from here
pr102378.C:31:15: warning: the address of ‘a’ will never be NULL [-Waddress]
   31 |     return &a == 0;    // -Waddress (good)
      |            ~~~^~~~
pr102378.C:36:15: warning: the address of ‘t’ will never be NULL [-Waddress]
   36 |     return &t == 0;    // -Waddress (good)
      |            ~~~^~~~
pr102378.C:41:15: warning: the address of ‘a’ will never be NULL [-Waddress]
   41 |     return &a == 0;    // -Waddress (good)
      |            ~~~^~~~

  parent reply	other threads:[~2021-09-16 22:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 21:19 [Bug c++/102378] New: missing -Waddress in template code msebor at gcc dot gnu.org
2021-09-16 21:24 ` [Bug c++/102378] " pinskia at gcc dot gnu.org
2021-09-16 21:28 ` [Bug c++/102378] missing -Waddress in template code at definition time rather than instantiation pinskia at gcc dot gnu.org
2021-09-16 22:11 ` msebor at gcc dot gnu.org [this message]
2021-09-16 22:25 ` msebor at gcc dot gnu.org
2022-05-06  8:31 ` jakub at gcc dot gnu.org
2023-05-08 12:22 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102378-4-dikpHSu6l0@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).