public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "msebor at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/102378] New: missing -Waddress in template code Date: Thu, 16 Sep 2021 21:19:54 +0000 [thread overview] Message-ID: <bug-102378-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102378 Bug ID: 102378 Summary: missing -Waddress in template code Product: gcc Version: 12.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: c++ Assignee: unassigned at gcc dot gnu.org Reporter: msebor at gcc dot gnu.org Target Milestone: --- While implementing the suggestion in the review below I noticed that G++ fails to issue -Waddress in template code even when it could: https://gcc.gnu.org/pipermail/gcc-patches/2021-September/579082.html $ cat t.C && gcc -O2 -S -Wall -Waddress t.C int f () { int a[2]; return &a == 0; // -Waddress (good) } template <class T> int g () { { int a[2]; return &a == 0; // missing -Waddress } { T t; return &t == 0; // no -Waddress for type-dependent expr (good) } { T a[2]; return &a == 0; // missing -Waddress } } template <class T> int h () { { int a[2]; return &a == 0; // missing -Waddress } { T t; return &t == 0; // missing -Waddress for T = int } { T a[2]; return &a == 0; // missing -Waddress } } template <int> int h (); t.C: In function ‘int f()’: t.C:4:13: warning: the address of ‘a’ will never be NULL [-Waddress] 4 | return &a == 0; // -Waddress (good) | ~~~^~~~ In contrast, Clang issues three warnings: t.C:4:11: warning: comparison of address of 'a' equal to a null pointer is always false [-Wtautological-pointer-compare] return &a == 0; // -Waddress (good) ^ ~ t.C:12:13: warning: comparison of address of 'a' equal to a null pointer is always false [-Wtautological-pointer-compare] return &a == 0; // missing -Waddress ^ ~ t.C:31:13: warning: comparison of address of 'a' equal to a null pointer is always false [-Wtautological-pointer-compare] return &a == 0; // missing -Waddress ^ ~ 3 warnings generated.
next reply other threads:[~2021-09-16 21:19 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-16 21:19 msebor at gcc dot gnu.org [this message] 2021-09-16 21:24 ` [Bug c++/102378] " pinskia at gcc dot gnu.org 2021-09-16 21:28 ` [Bug c++/102378] missing -Waddress in template code at definition time rather than instantiation pinskia at gcc dot gnu.org 2021-09-16 22:11 ` msebor at gcc dot gnu.org 2021-09-16 22:25 ` msebor at gcc dot gnu.org 2022-05-06 8:31 ` jakub at gcc dot gnu.org 2023-05-08 12:22 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102378-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).