public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/102622] [9 Regression] Wrong code with -O1 and above due to phiopt and signed one bit integer types
Date: Mon, 11 Oct 2021 21:07:48 +0000	[thread overview]
Message-ID: <bug-102622-4-FOwnz126ng@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102622-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102622

--- Comment #26 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Andrew Pinski
<pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:77867cd8185b206124dd24ce8229cc0bf144c078

commit r9-9765-g77867cd8185b206124dd24ce8229cc0bf144c078
Author: Andrew Pinski <apinski@marvell.com>
Date:   Sun Oct 10 23:12:11 2021 +0000

    [GCC 10 branch] tree-optimization: [PR102622]: wrong code due to signed one
bit integer and "a?-1:0"

    So here is the GCC 10 branch version which fixes the wrong code.
    The problem is we create a negation of an one bit signed integer type
    which is undefined if the value was -1.
    This is not needed for GCC 11 branch since the case is handled differently
    there and has been fixed there (and the trunk has now been fixed too).
    So for one bit types, there is no reason to create the negation so just
    setting neg to false for them, just works.

    OK? Bootstrapped and tested on x86_64-linux-gnu.

            PR tree-optimization/102622

    gcc/ChangeLog:

            * tree-ssa-phiopt.c (conditional_replacement): Set neg
            to false for one bit signed types.

    gcc/testsuite/ChangeLog:

            * gcc.c-torture/execute/bitfld-10.c: New test.

    (cherry picked from commit 4111b36079fed95b787fafeed1deaab2dedaf3db)

  parent reply	other threads:[~2021-10-11 21:07 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05 19:37 [Bug tree-optimization/102622] New: Wrong code with -O3 for skylake-avx512 and icelake-server vsevolod.livinskij at frtk dot ru
2021-10-05 22:21 ` [Bug tree-optimization/102622] [12 Regression] " pinskia at gcc dot gnu.org
2021-10-05 22:36 ` pinskia at gcc dot gnu.org
2021-10-05 23:31 ` pinskia at gcc dot gnu.org
2021-10-06  7:23 ` [Bug tree-optimization/102622] [12 Regression] Wrong code with -O3 for skylake-avx512 and icelake-server by r12-3903 aldyh at gcc dot gnu.org
2021-10-06  8:42 ` rguenth at gcc dot gnu.org
2021-10-06 12:55 ` hjl.tools at gmail dot com
2021-10-06 13:04 ` hjl.tools at gmail dot com
2021-10-06 13:10 ` aldyh at gcc dot gnu.org
2021-10-06 13:12 ` aldyh at gcc dot gnu.org
2021-10-06 13:26 ` hjl.tools at gmail dot com
2021-10-06 14:19 ` aldyh at redhat dot com
2021-10-06 14:21 ` hjl.tools at gmail dot com
2021-10-07 16:07 ` aldyh at gcc dot gnu.org
2021-10-07 21:29 ` pinskia at gcc dot gnu.org
2021-10-07 21:31 ` pinskia at gcc dot gnu.org
2021-10-08  6:04 ` pinskia at gcc dot gnu.org
2021-10-09 22:25 ` pinskia at gcc dot gnu.org
2021-10-10  1:05 ` [Bug tree-optimization/102622] [9/10/12 Regression] Wrong code with -O1 and above due to phiopt and signed one bit integer types pinskia at gcc dot gnu.org
2021-10-10  1:54 ` pinskia at gcc dot gnu.org
2021-10-10  5:49 ` pinskia at gcc dot gnu.org
2021-10-10  9:04 ` cvs-commit at gcc dot gnu.org
2021-10-10  9:06 ` [Bug tree-optimization/102622] [9/10 " pinskia at gcc dot gnu.org
2021-10-10  9:18 ` pinskia at gcc dot gnu.org
2021-10-10 23:21 ` pinskia at gcc dot gnu.org
2021-10-11  9:22 ` cvs-commit at gcc dot gnu.org
2021-10-11  9:24 ` [Bug tree-optimization/102622] [9 " pinskia at gcc dot gnu.org
2021-10-11 21:07 ` cvs-commit at gcc dot gnu.org [this message]
2021-10-11 21:08 ` pinskia at gcc dot gnu.org
2021-10-11 21:19 ` cvs-commit at gcc dot gnu.org
2021-11-09 19:03 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102622-4-FOwnz126ng@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).