public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/102622] [9/10 Regression] Wrong code with -O1 and above due to phiopt and signed one bit integer types Date: Sun, 10 Oct 2021 09:18:51 +0000 [thread overview] Message-ID: <bug-102622-4-ZsvCZa3qv2@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-102622-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102622 --- Comment #22 from Andrew Pinski <pinskia at gcc dot gnu.org> --- Here is the simple patch which I will test for both GCC 10 and GCC 9. The question becomes does it make sense to make the same change to GCC 11 even if it cannot be hit. diff --git a/gcc/tree-ssa-phiopt.c b/gcc/tree-ssa-phiopt.c index 9ed26a3d45f..a6c197defea 100644 --- a/gcc/tree-ssa-phiopt.c +++ b/gcc/tree-ssa-phiopt.c @@ -770,9 +770,12 @@ conditional_replacement (basic_block cond_bb, basic_block middle_bb, if ((integer_zerop (arg0) && integer_onep (arg1)) || (integer_zerop (arg1) && integer_onep (arg0))) neg = false; + /* For signed one bit types, the negation is not needed and + should be avoided and is the same as 1 case for non-signed + one bit types. */ else if ((integer_zerop (arg0) && integer_all_onesp (arg1)) || (integer_zerop (arg1) && integer_all_onesp (arg0))) - neg = true; + neg = TYPE_PRECISION (TREE_TYPE (arg0)) != 1; else return false;
next prev parent reply other threads:[~2021-10-10 9:18 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-05 19:37 [Bug tree-optimization/102622] New: Wrong code with -O3 for skylake-avx512 and icelake-server vsevolod.livinskij at frtk dot ru 2021-10-05 22:21 ` [Bug tree-optimization/102622] [12 Regression] " pinskia at gcc dot gnu.org 2021-10-05 22:36 ` pinskia at gcc dot gnu.org 2021-10-05 23:31 ` pinskia at gcc dot gnu.org 2021-10-06 7:23 ` [Bug tree-optimization/102622] [12 Regression] Wrong code with -O3 for skylake-avx512 and icelake-server by r12-3903 aldyh at gcc dot gnu.org 2021-10-06 8:42 ` rguenth at gcc dot gnu.org 2021-10-06 12:55 ` hjl.tools at gmail dot com 2021-10-06 13:04 ` hjl.tools at gmail dot com 2021-10-06 13:10 ` aldyh at gcc dot gnu.org 2021-10-06 13:12 ` aldyh at gcc dot gnu.org 2021-10-06 13:26 ` hjl.tools at gmail dot com 2021-10-06 14:19 ` aldyh at redhat dot com 2021-10-06 14:21 ` hjl.tools at gmail dot com 2021-10-07 16:07 ` aldyh at gcc dot gnu.org 2021-10-07 21:29 ` pinskia at gcc dot gnu.org 2021-10-07 21:31 ` pinskia at gcc dot gnu.org 2021-10-08 6:04 ` pinskia at gcc dot gnu.org 2021-10-09 22:25 ` pinskia at gcc dot gnu.org 2021-10-10 1:05 ` [Bug tree-optimization/102622] [9/10/12 Regression] Wrong code with -O1 and above due to phiopt and signed one bit integer types pinskia at gcc dot gnu.org 2021-10-10 1:54 ` pinskia at gcc dot gnu.org 2021-10-10 5:49 ` pinskia at gcc dot gnu.org 2021-10-10 9:04 ` cvs-commit at gcc dot gnu.org 2021-10-10 9:06 ` [Bug tree-optimization/102622] [9/10 " pinskia at gcc dot gnu.org 2021-10-10 9:18 ` pinskia at gcc dot gnu.org [this message] 2021-10-10 23:21 ` pinskia at gcc dot gnu.org 2021-10-11 9:22 ` cvs-commit at gcc dot gnu.org 2021-10-11 9:24 ` [Bug tree-optimization/102622] [9 " pinskia at gcc dot gnu.org 2021-10-11 21:07 ` cvs-commit at gcc dot gnu.org 2021-10-11 21:08 ` pinskia at gcc dot gnu.org 2021-10-11 21:19 ` cvs-commit at gcc dot gnu.org 2021-11-09 19:03 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102622-4-ZsvCZa3qv2@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).