public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug sanitizer/102632] New: Missing AM_CCASFLAGS in libsanitizer Makefile.am
@ 2021-10-06 18:20 hjl.tools at gmail dot com
  2021-10-08 13:17 ` [Bug sanitizer/102632] " cvs-commit at gcc dot gnu.org
  2021-10-08 13:38 ` hjl.tools at gmail dot com
  0 siblings, 2 replies; 3+ messages in thread
From: hjl.tools at gmail dot com @ 2021-10-06 18:20 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102632

            Bug ID: 102632
           Summary: Missing AM_CCASFLAGS in libsanitizer Makefile.am
           Product: gcc
           Version: 9.4.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hjl.tools at gmail dot com
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org, marxin at gcc dot gnu.org
  Target Milestone: ---
            Target: i386,x86-64

commit 9069eb28d45baaa8baf5e3790b03b0e2cc5b49b3
Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Date:   Fri Nov 17 22:34:50 2017 +0100

    Enable building libsanitizer with Intel CET

    libsanitizer/
            * acinclude.m4: Add enable.m4 and cet.m4.
            * Makefile.in: Regenerate.
            * asan/Makefile.am: Update AM_CXXFLAGS.
            * asan/Makefile.in: Regenerate.
            * configure: Likewise.
            * configure.ac: Set CET_FLAGS. Update EXTRA_CFLAGS,
            EXTRA_CXXFLAGS, EXTRA_ASFLAGS.
            * interception/Makefile.am: Update AM_CXXFLAGS.
            * interception/Makefile.in: Regenerate.
            * libbacktrace/Makefile.am: Update AM_CFLAGS, AM_CXXFLAGS.
            * libbacktrace/Makefile.in: Regenerate.
            * lsan/Makefile.am: Update AM_CXXFLAGS.
            * lsan/Makefile.in: Regenerate.
            * sanitizer_common/Makefile.am: Update AM_CXXFLAGS,
            AM_CCASFLAGS.
            * sanitizer_common/sanitizer_linux_x86_64.S: Include cet.h.
            Add _CET_ENDBR macro.
            * sanitizer_common/Makefile.in: Regenerate.
            * tsan/Makefile.am: Update AM_CXXFLAGS.
            * tsan/Makefile.in: Regenerate.
            * tsan/tsan_rtl_amd64.S Include cet.h. Add _CET_ENDBR macro.
            * ubsan/Makefile.am: Update AM_CXXFLAGS.
            * ubsan/Makefile.in: Regenerate.

failed to add EXTRA_ASFLAGS to AM_CCASFLAGS in all Makefile.am.  As
the result, CET aren't enabled in all assembly codes.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug sanitizer/102632] Missing AM_CCASFLAGS in libsanitizer Makefile.am
  2021-10-06 18:20 [Bug sanitizer/102632] New: Missing AM_CCASFLAGS in libsanitizer Makefile.am hjl.tools at gmail dot com
@ 2021-10-08 13:17 ` cvs-commit at gcc dot gnu.org
  2021-10-08 13:38 ` hjl.tools at gmail dot com
  1 sibling, 0 replies; 3+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-10-08 13:17 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102632

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:a23653c6a683d6a1bb1278aaa32e35247d8c2740

commit r12-4251-ga23653c6a683d6a1bb1278aaa32e35247d8c2740
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Sep 10 06:13:59 2021 -0700

    libsanitizer: Add AM_CCASFLAGS to Makefile.am

    commit 9069eb28d45baaa8baf5e3790b03b0e2cc5b49b3
    Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
    Date:   Fri Nov 17 22:34:50 2017 +0100

        Enable building libsanitizer with Intel CET

        libsanitizer/
                * acinclude.m4: Add enable.m4 and cet.m4.
                * Makefile.in: Regenerate.
                * asan/Makefile.am: Update AM_CXXFLAGS.
                * asan/Makefile.in: Regenerate.
                * configure: Likewise.
                * configure.ac: Set CET_FLAGS. Update EXTRA_CFLAGS,
                EXTRA_CXXFLAGS, EXTRA_ASFLAGS.
                * interception/Makefile.am: Update AM_CXXFLAGS.
                * interception/Makefile.in: Regenerate.
                * libbacktrace/Makefile.am: Update AM_CFLAGS, AM_CXXFLAGS.
                * libbacktrace/Makefile.in: Regenerate.
                * lsan/Makefile.am: Update AM_CXXFLAGS.
                * lsan/Makefile.in: Regenerate.
                * sanitizer_common/Makefile.am: Update AM_CXXFLAGS,
                AM_CCASFLAGS.
                * sanitizer_common/sanitizer_linux_x86_64.S: Include cet.h.
                Add _CET_ENDBR macro.
                * sanitizer_common/Makefile.in: Regenerate.
                * tsan/Makefile.am: Update AM_CXXFLAGS.
                * tsan/Makefile.in: Regenerate.
                * tsan/tsan_rtl_amd64.S Include cet.h. Add _CET_ENDBR macro.
                * ubsan/Makefile.am: Update AM_CXXFLAGS.
                * ubsan/Makefile.in: Regenerate.

    failed to add EXTRA_ASFLAGS to AM_CCASFLAGS in all Makefile.am.  As
    the result, CET aren't enabled in all assembly codes.

    Add AM_CCASFLAGS to Makefile.am to compile assembly codes with $CET_FLAGS.

            PR sanitizer/102632
            * asan/Makefile.am (AM_CCASFLAGS): New.  Set to $(EXTRA_ASFLAGS).
            * hwasan/Makefile.am (AM_CCASFLAGS): Likewise.
            * interception/Makefile.am (AM_CCASFLAGS): Likewise.
            * lsan/Makefile.am (AM_CCASFLAGS): Likewise.
            * tsan/Makefile.am (AM_CCASFLAGS): Likewise.
            * ubsan/Makefile.am (AM_CCASFLAGS): Likewise.
            * asan/Makefile.in: Regenerate.
            * hwasan/Makefile.in: Likewise.
            * interception/Makefile.in: Likewise.
            * lsan/Makefile.in: Likewise.
            * tsan/Makefile.in: Likewise.
            * ubsan/Makefile.in: Likewise.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug sanitizer/102632] Missing AM_CCASFLAGS in libsanitizer Makefile.am
  2021-10-06 18:20 [Bug sanitizer/102632] New: Missing AM_CCASFLAGS in libsanitizer Makefile.am hjl.tools at gmail dot com
  2021-10-08 13:17 ` [Bug sanitizer/102632] " cvs-commit at gcc dot gnu.org
@ 2021-10-08 13:38 ` hjl.tools at gmail dot com
  1 sibling, 0 replies; 3+ messages in thread
From: hjl.tools at gmail dot com @ 2021-10-08 13:38 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102632

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for GCC 12.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-08 13:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06 18:20 [Bug sanitizer/102632] New: Missing AM_CCASFLAGS in libsanitizer Makefile.am hjl.tools at gmail dot com
2021-10-08 13:17 ` [Bug sanitizer/102632] " cvs-commit at gcc dot gnu.org
2021-10-08 13:38 ` hjl.tools at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).