public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "egallager at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug other/102664] contrib/gcc-git-customization.sh uses echo -n, which isn't portable
Date: Thu, 20 Jan 2022 12:05:38 +0000	[thread overview]
Message-ID: <bug-102664-4-DrspjcjSYB@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102664-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102664

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iains at gcc dot gnu.org,
                   |                            |jakub at gcc dot gnu.org

--- Comment #6 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #5)
> (In reply to Eric Gallager from comment #3)
> > Along these lines, there's also some non-portable usage of `expr` in the
> > file, too (which I brought up on IRC), but I forget what exactly it was...
> 
> Do you know what exactly is problematic regarding the portability?

Ah, I found my IRC log; apparently it was the `expr match` part:

 1635762461 31<egallager>30     hm, looks like I need to use gexpr instead of
just-plain expr
T 1635762474 31<egallager>30    I guess it's a GNU vs. BSD thing 
T 1635762672 31<egallager>30    so I guess that's a separate bug to file
T 1635762691 31<egallager>30    I guess the g:hash syntax will do for now for
the other one I was filing 
T 1635762767 18<iains>  yes, there are some non-portable parts in the
customisation … 
T 1635762803 18<jakub>  expr is used twice there, is the problem with expr
match or with expr x - y
T 1635762865 18*        iains thought the initial problem was with the match ..
but ICBW
T 1635762967 18<jakub>  I guess it can be replaced with echo | grep -q too, but
for bash that is unnecessary slowdown...; perhaps gcc-git-customization.sh
could check if expr match works and if not, use something different...
T 1635763046 31<egallager>30    I think it's the expr match part

  parent reply	other threads:[~2022-01-20 12:05 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 16:03 [Bug other/102664] New: " egallager at gcc dot gnu.org
2021-10-09 18:26 ` [Bug other/102664] " pinskia at gcc dot gnu.org
2021-11-02  5:41 ` egallager at gcc dot gnu.org
2021-11-17 23:45 ` egallager at gcc dot gnu.org
2022-01-19 16:52 ` egallager at gcc dot gnu.org
2022-01-20  8:07 ` marxin at gcc dot gnu.org
2022-01-20 12:05 ` egallager at gcc dot gnu.org [this message]
2022-01-20 12:47 ` redi at gcc dot gnu.org
2022-01-27 21:05 ` redi at gcc dot gnu.org
2022-03-08 16:21 ` egallager at gcc dot gnu.org
2022-03-08 16:25 ` marxin at gcc dot gnu.org
2022-03-08 16:37 ` redi at gcc dot gnu.org
2022-03-08 16:40 ` redi at gcc dot gnu.org
2022-03-08 16:41 ` redi at gcc dot gnu.org
2022-03-08 16:42 ` marxin at gcc dot gnu.org
2022-03-08 16:45 ` redi at gcc dot gnu.org
2022-03-08 16:47 ` redi at gcc dot gnu.org
2022-03-08 16:48 ` cvs-commit at gcc dot gnu.org
2022-03-08 16:48 ` redi at gcc dot gnu.org
2022-03-08 17:07 ` egallager at gcc dot gnu.org
2022-03-08 17:16 ` redi at gcc dot gnu.org
2022-03-08 17:22 ` redi at gcc dot gnu.org
2022-03-08 17:35 ` redi at gcc dot gnu.org
2022-03-08 17:46 ` redi at gcc dot gnu.org
2022-03-08 17:58 ` redi at gcc dot gnu.org
2022-03-09  0:20 ` cvs-commit at gcc dot gnu.org
2022-03-09  0:21 ` redi at gcc dot gnu.org
2022-03-09  0:25 ` egallager at gcc dot gnu.org
2022-03-09 11:48 ` rearnsha at gcc dot gnu.org
2022-03-09 12:17 ` rearnsha at gcc dot gnu.org
2022-03-09 14:09 ` redi at gcc dot gnu.org
2022-03-09 14:10 ` redi at gcc dot gnu.org
2022-03-09 14:13 ` redi at gcc dot gnu.org
2022-03-09 17:14 ` redi at gcc dot gnu.org
2022-03-10  8:43 ` cvs-commit at gcc dot gnu.org
2022-03-10 11:49 ` cvs-commit at gcc dot gnu.org
2022-03-11 11:37 ` rearnsha at gcc dot gnu.org
2022-03-11 12:25 ` marxin at gcc dot gnu.org
2022-03-11 14:32 ` egallager at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102664-4-DrspjcjSYB@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).