public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libbacktrace/102742] New: ERROR: descriptor 3 still open after tests complete
@ 2021-10-14  7:40 marxin at gcc dot gnu.org
  2021-10-21  7:50 ` [Bug testsuite/102742] " marxin at gcc dot gnu.org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-10-14  7:40 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102742

            Bug ID: 102742
           Summary: ERROR: descriptor 3 still open after tests complete
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libbacktrace
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: ian at gcc dot gnu.org
  Target Milestone: ---

>From time to time, I see this failure when I run tests when I run e.g.

make -j16 check -k RUNTESTFLAGS="dg.exp=pr64637.c"

ERROR: descriptor 3 still open after tests complete
ERROR: descriptor 4 still open after tests complete

However, running with -j1 it's gone. I'm pretty sure these FDs belong to
jobserver and I can prove it with:

diff --git a/libbacktrace/btest.c b/libbacktrace/btest.c
index 9f9c03babf3..f9be9a26db4 100644
--- a/libbacktrace/btest.c
+++ b/libbacktrace/btest.c
@@ -482,6 +482,9 @@ check_open_files (void)
 int
 main (int argc ATTRIBUTE_UNUSED, char **argv)
 {
+  const char *makeflags = getenv ("MAKEFLAGS");
+  fprintf (stderr, "XXX: %s\n", makeflags);
+
   state = backtrace_create_state (argv[0], BACKTRACE_SUPPORTS_THREADS,
                                  error_callback_create, NULL);

Then I see:

XXX: kw -j16 --jobserver-auth=3,4

in test-suite.log.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug testsuite/102742] ERROR: descriptor 3 still open after tests complete
  2021-10-14  7:40 [Bug libbacktrace/102742] New: ERROR: descriptor 3 still open after tests complete marxin at gcc dot gnu.org
@ 2021-10-21  7:50 ` marxin at gcc dot gnu.org
  2021-10-22 19:12 ` cvs-commit at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-10-21  7:50 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102742

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2021-10-21
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
I've just sent a patch for it:
https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582230.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug testsuite/102742] ERROR: descriptor 3 still open after tests complete
  2021-10-14  7:40 [Bug libbacktrace/102742] New: ERROR: descriptor 3 still open after tests complete marxin at gcc dot gnu.org
  2021-10-21  7:50 ` [Bug testsuite/102742] " marxin at gcc dot gnu.org
@ 2021-10-22 19:12 ` cvs-commit at gcc dot gnu.org
  2021-10-22 19:13 ` marxin at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-10-22 19:12 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102742

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:690180eb4b35df3f4b5def690878ecaeb5492e41

commit r12-4630-g690180eb4b35df3f4b5def690878ecaeb5492e41
Author: Martin Liska <mliska@suse.cz>
Date:   Fri Oct 22 10:12:56 2021 +0200

    Handle jobserver file descriptors in btest.

            PR testsuite/102742

    libbacktrace/ChangeLog:

            * btest.c (MIN_DESCRIPTOR): New.
            (MAX_DESCRIPTOR): Likewise.
            (check_available_files): Likewise.
            (check_open_files): Check only file descriptors that
            were not available at the entry.
            (main): Call check_available_files.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug testsuite/102742] ERROR: descriptor 3 still open after tests complete
  2021-10-14  7:40 [Bug libbacktrace/102742] New: ERROR: descriptor 3 still open after tests complete marxin at gcc dot gnu.org
  2021-10-21  7:50 ` [Bug testsuite/102742] " marxin at gcc dot gnu.org
  2021-10-22 19:12 ` cvs-commit at gcc dot gnu.org
@ 2021-10-22 19:13 ` marxin at gcc dot gnu.org
  2022-05-12  9:37 ` pinskia at gcc dot gnu.org
  2022-05-12  9:39 ` pinskia at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-10-22 19:13 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102742

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug testsuite/102742] ERROR: descriptor 3 still open after tests complete
  2021-10-14  7:40 [Bug libbacktrace/102742] New: ERROR: descriptor 3 still open after tests complete marxin at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2021-10-22 19:13 ` marxin at gcc dot gnu.org
@ 2022-05-12  9:37 ` pinskia at gcc dot gnu.org
  2022-05-12  9:39 ` pinskia at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-05-12  9:37 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102742

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug testsuite/102742] ERROR: descriptor 3 still open after tests complete
  2021-10-14  7:40 [Bug libbacktrace/102742] New: ERROR: descriptor 3 still open after tests complete marxin at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2022-05-12  9:37 ` pinskia at gcc dot gnu.org
@ 2022-05-12  9:39 ` pinskia at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-05-12  9:39 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102742

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lidehua5 at huawei dot com

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 105579 has been marked as a duplicate of this bug. ***

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-05-12  9:39 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-14  7:40 [Bug libbacktrace/102742] New: ERROR: descriptor 3 still open after tests complete marxin at gcc dot gnu.org
2021-10-21  7:50 ` [Bug testsuite/102742] " marxin at gcc dot gnu.org
2021-10-22 19:12 ` cvs-commit at gcc dot gnu.org
2021-10-22 19:13 ` marxin at gcc dot gnu.org
2022-05-12  9:37 ` pinskia at gcc dot gnu.org
2022-05-12  9:39 ` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).