[Bug c/102759] New: ICE: Segmentation fault, contains_struct_check(tree_node*, tree_node_structure_enum, char const*, int, char const*), maybe_check_access_sizes

[Bug c/102759] New: ICE: Segmentation fault, contains_struct_check(tree_node*, tree_node_structure_enum, char const*, int, char const*), maybe_check_access_sizes

[cnsun at uwaterloo dot ca]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102759

            Bug ID: 102759
           Summary: ICE: Segmentation fault,
                    contains_struct_check(tree_node*,
                    tree_node_structure_enum, char const*, int, char
                    const*), maybe_check_access_sizes
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: cnsun at uwaterloo dot ca
  Target Milestone: ---

This might be a duplicate to PR 100784

$ gcc-trunk -v
Using built-in specs.
COLLECT_GCC=gcc-trunk
COLLECT_LTO_WRAPPER=/scratch/software/gcc-trunk/libexec/gcc/x86_64-pc-linux-gnu/12.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /tmp/tmp.gzh6IUhxke-gcc-builder/gcc/configure
--enable-languages=c,c++,lto --enable-checking-yes --enable-multiarch
--prefix=/scratch/software/gcc-trunk --disable-bootstrap
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 12.0.0 20211014 (experimental) [master -gee9fa8a57] (GCC)

$ cat mutant.c
a4() { void fa4(int[]); }
void fa4();
call_fa4() { fa4(a4); }

$ gcc-trunk -w mutant.c
during GIMPLE pass: waccess
mutant.c: In function ‘call_fa4’:
mutant.c:3:1: internal compiler error: Segmentation fault
    3 | call_fa4() { fa4(a4); }
      | ^~~~~~~~
0xf8c8d3 crash_signal
        /tmp/tmp.gzh6IUhxke-gcc-builder/gcc/gcc/toplev.c:326
0x72b653 contains_struct_check(tree_node*, tree_node_structure_enum, char
const*, int, char const*)
        /tmp/tmp.gzh6IUhxke-gcc-builder/gcc/gcc/tree.h:3546
0x72b653 maybe_check_access_sizes
        /tmp/tmp.gzh6IUhxke-gcc-builder/gcc/gcc/gimple-ssa-warn-access.cc:2880
0xc822f4 check_call
        /tmp/tmp.gzh6IUhxke-gcc-builder/gcc/gcc/gimple-ssa-warn-access.cc:3151
0xc822f4 check
        /tmp/tmp.gzh6IUhxke-gcc-builder/gcc/gcc/gimple-ssa-warn-access.cc:3310
0xc822f4 check
        /tmp/tmp.gzh6IUhxke-gcc-builder/gcc/gcc/gimple-ssa-warn-access.cc:3326
0xc822f4 execute
        /tmp/tmp.gzh6IUhxke-gcc-builder/gcc/gcc/gimple-ssa-warn-access.cc:3340
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug ipa/102759] [12 Regression] ICE: Segmentation fault in maybe_check_access_sizes

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102759

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org
   Target Milestone|---                         |12.0
     Ever confirmed|0                           |1
          Component|c                           |ipa
            Summary|ICE: Segmentation fault,    |[12 Regression] ICE:
                   |contains_struct_check(tree_ |Segmentation fault in
                   |node*,                      |maybe_check_access_sizes
                   |tree_node_structure_enum,   |
                   |char const*, int, char      |
                   |const*),                    |
                   |maybe_check_access_sizes    |
   Last reconfirmed|                            |2021-10-15
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This code is wildly undefined ....

Confirmed, doubt it is a dup because GCC 11.2.0 does not ICE.

[Bug tree-optimization/102759] [12 Regression] ICE: Segmentation fault in maybe_check_access_sizes since r12-2976-gb48d4e6818674898

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102759

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[12 Regression] ICE:        |[12 Regression] ICE:
                   |Segmentation fault in       |Segmentation fault in
                   |maybe_check_access_sizes    |maybe_check_access_sizes
                   |                            |since
                   |                            |r12-2976-gb48d4e6818674898

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-2976-gb48d4e6818674898.

[Bug tree-optimization/102759] [12 Regression] ICE: Segmentation fault in maybe_check_access_sizes since r12-2976-gb48d4e6818674898

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102759

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|diagnostic                  |ice-on-valid-code
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |msebor at gcc dot gnu.org

--- Comment #3 from Martin Sebor <msebor at gcc dot gnu.org> ---
The code is certainly undefined but (appallingly), it's syntactically valid C.

The correspondingly hideous C++ version is also accepted without a diagnostic
but doesn't ICE:

void a4 () { void fa4 (int[]); }
void fa4 (...);
void call_fa4 (void) { fa4 (a4); }

[Bug tree-optimization/102759] [12 Regression] ICE: Segmentation fault in maybe_check_access_sizes since r12-2976-gb48d4e6818674898

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102759

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug tree-optimization/102759] [12 Regression] ICE: Segmentation fault in maybe_check_access_sizes since r12-2976-gb48d4e6818674898

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102759

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #4 from Martin Sebor <msebor at gcc dot gnu.org> ---
Patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/584516.html

[Bug tree-optimization/102759] [12 Regression] ICE: Segmentation fault in maybe_check_access_sizes since r12-2976-gb48d4e6818674898

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102759

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Sebor <msebor@gcc.gnu.org>:

https://gcc.gnu.org/g:ea9e0d6c27405d256b4888e9e860e469037c911d

commit r12-5354-gea9e0d6c27405d256b4888e9e860e469037c911d
Author: Martin Sebor <msebor@redhat.com>
Date:   Wed Nov 17 15:09:23 2021 -0700

    Avoid pathological function redeclarations when checking access sizes
[PR102759].

    Resolves:
    PR tree-optimization/102759 - ICE: Segmentation fault in
maybe_check_access_sizes since r12-2976-gb48d4e6818674898

    gcc/ChangeLog:

            PR tree-optimization/102759
            * gimple-array-bounds.cc (build_printable_array_type): Move...
            * gimple-ssa-warn-access.cc (build_printable_array_type): Avoid
            pathological function redeclarations that remove a previously
            declared prototype.
            Improve formatting of function arguments in informational notes.
            * pointer-query.cc (build_printable_array_type): ...to here.
            * pointer-query.h (build_printable_array_type): Declared.

    gcc/testsuite/ChangeLog:

            PR tree-optimization/102759
            * gcc.dg/Warray-parameter-10.c: New test.
            * gcc.dg/Wstringop-overflow-82.c: New test.

[Bug tree-optimization/102759] [12 Regression] ICE: Segmentation fault in maybe_check_access_sizes since r12-2976-gb48d4e6818674898

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102759

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Martin Sebor <msebor at gcc dot gnu.org> ---
Fixed.