public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/102835] New: gcc.target/i386/avx512fp16-trunchf.c FAILs
@ 2021-10-19 11:41 ro at gcc dot gnu.org
2021-10-19 11:42 ` [Bug target/102835] " ro at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: ro at gcc dot gnu.org @ 2021-10-19 11:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102835
Bug ID: 102835
Summary: gcc.target/i386/avx512fp16-trunchf.c FAILs
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: ro at gcc dot gnu.org
CC: wwwhhhyyy333 at gmail dot com
Target Milestone: ---
Target: i?86-pc-solaris2.11, x86_64-pc-solaris2.11
The gcc.target/i386/avx512fp16-trunchf.c test has been FAILing on 32-bit
Solaris/x86
since it was installed:
FAIL: gcc.target/i386/avx512fp16-trunchf.c scan-assembler-times vcvttsh2si[
\\\\t]+[^{\\n]*(?:%xmm[0-9]|\\\\(%esp\\\\))+, %eax(?:\\n|[ \\\\t]+#) 3
FAIL: gcc.target/i386/avx512fp16-trunchf.c scan-assembler-times vcvttsh2usi[
\\\\t]+[^{\\n]*(?:%xmm[0-9]|\\\\(%esp\\\\))+, %eax(?:\\n|[ \\\\t]+#) 2
On Solaris, the assembler output contains
vcvttsh2si 8(%ebp), %eax
vcvttsh2si 8(%ebp), %eax
vcvttsh2si 8(%ebp), %eax
vcvttsh2usi 8(%ebp), %eax
vcvttsh2usi 8(%ebp), %eax
while Linux has
vcvttsh2si 4(%esp), %eax
vcvttsh2si 4(%esp), %eax
vcvttsh2si 4(%esp), %eax
vcvttsh2usi 4(%esp), %eax
vcvttsh2usi 4(%esp), %eax
As it turns out, the difference occurs because Solaris/x86 default to
-fno-omit-frame-pointer. With -fomit-frame-pointer added, the output matches.
I wonder what's the best way to handle the difference? Just add
-fomit-frame-pointer
to the testcase or allow for the %ebp vs. %esp difference?
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/102835] gcc.target/i386/avx512fp16-trunchf.c FAILs
2021-10-19 11:41 [Bug target/102835] New: gcc.target/i386/avx512fp16-trunchf.c FAILs ro at gcc dot gnu.org
@ 2021-10-19 11:42 ` ro at gcc dot gnu.org
2021-10-19 13:13 ` wwwhhhyyy333 at gmail dot com
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ro at gcc dot gnu.org @ 2021-10-19 11:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102835
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/102835] gcc.target/i386/avx512fp16-trunchf.c FAILs
2021-10-19 11:41 [Bug target/102835] New: gcc.target/i386/avx512fp16-trunchf.c FAILs ro at gcc dot gnu.org
2021-10-19 11:42 ` [Bug target/102835] " ro at gcc dot gnu.org
@ 2021-10-19 13:13 ` wwwhhhyyy333 at gmail dot com
2021-10-25 13:54 ` [Bug testsuite/102835] " ro at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: wwwhhhyyy333 at gmail dot com @ 2021-10-19 13:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102835
--- Comment #1 from Hongyu Wang <wwwhhhyyy333 at gmail dot com> ---
(In reply to Rainer Orth from comment #0)
>
> I wonder what's the best way to handle the difference? Just add
> -fomit-frame-pointer
> to the testcase or allow for the %ebp vs. %esp difference?
For this test we just want to check mnemonics are properly generated, so I
think we can allow either esp/ebp output for different system.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug testsuite/102835] gcc.target/i386/avx512fp16-trunchf.c FAILs
2021-10-19 11:41 [Bug target/102835] New: gcc.target/i386/avx512fp16-trunchf.c FAILs ro at gcc dot gnu.org
2021-10-19 11:42 ` [Bug target/102835] " ro at gcc dot gnu.org
2021-10-19 13:13 ` wwwhhhyyy333 at gmail dot com
@ 2021-10-25 13:54 ` ro at gcc dot gnu.org
2021-10-26 12:28 ` cvs-commit at gcc dot gnu.org
2021-10-26 12:29 ` ro at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: ro at gcc dot gnu.org @ 2021-10-25 13:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102835
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
URL| |https://gcc.gnu.org/piperma
| |il/gcc-patches/2021-October
| |/582495.html
Ever confirmed|0 |1
Last reconfirmed| |2021-10-25
Assignee|unassigned at gcc dot gnu.org |ro at gcc dot gnu.org
--- Comment #2 from Rainer Orth <ro at gcc dot gnu.org> ---
Mine, patch posted.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug testsuite/102835] gcc.target/i386/avx512fp16-trunchf.c FAILs
2021-10-19 11:41 [Bug target/102835] New: gcc.target/i386/avx512fp16-trunchf.c FAILs ro at gcc dot gnu.org
` (2 preceding siblings ...)
2021-10-25 13:54 ` [Bug testsuite/102835] " ro at gcc dot gnu.org
@ 2021-10-26 12:28 ` cvs-commit at gcc dot gnu.org
2021-10-26 12:29 ` ro at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-10-26 12:28 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102835
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Rainer Orth <ro@gcc.gnu.org>:
https://gcc.gnu.org/g:2243f6cf4d18f8793eb3e77c444a191763509285
commit r12-4712-g2243f6cf4d18f8793eb3e77c444a191763509285
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date: Tue Oct 26 14:23:06 2021 +0200
testsuite: i386: Fix gcc.target/i386/avx512fp16-trunchf.c on Solaris
[PR102835]
The gcc.target/i386/avx512fp16-trunchf.c test FAILs on 32-bit Solaris/x86:
FAIL: gcc.target/i386/avx512fp16-trunchf.c scan-assembler-times vcvttsh2si[
\\\\t]+[^{\\n]*(?:%xmm[0-9]|\\\\(%esp\\\\))+, %eax(?:\\n|[ \\\\t]+#) 3
FAIL: gcc.target/i386/avx512fp16-trunchf.c scan-assembler-times
vcvttsh2usi[ \\\\t]+[^{\\n]*(?:%xmm[0-9]|\\\\(%esp\\\\))+, %eax(?:\\n|[
\\\\t]+#) 2
This happens because Solaris defaults to -fno-omit-frame-pointer, so it
uses %ebp instead of the expected %esp. As Hongyu Wang suggested in the
PR, this can be fixed by accepting both forms, which this patch does.
Tested on i386-pc-solaris2.11 and x86_64-pc-linux-gnu.
2021-10-20 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
gcc/testsuite:
PR testsuite/102835
* gcc.target/i386/avx512fp16-trunchf.c: Allow for %esp instead of
%ebp.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug testsuite/102835] gcc.target/i386/avx512fp16-trunchf.c FAILs
2021-10-19 11:41 [Bug target/102835] New: gcc.target/i386/avx512fp16-trunchf.c FAILs ro at gcc dot gnu.org
` (3 preceding siblings ...)
2021-10-26 12:28 ` cvs-commit at gcc dot gnu.org
@ 2021-10-26 12:29 ` ro at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: ro at gcc dot gnu.org @ 2021-10-26 12:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102835
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> ---
Fixed for GCC 12.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-26 12:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 11:41 [Bug target/102835] New: gcc.target/i386/avx512fp16-trunchf.c FAILs ro at gcc dot gnu.org
2021-10-19 11:42 ` [Bug target/102835] " ro at gcc dot gnu.org
2021-10-19 13:13 ` wwwhhhyyy333 at gmail dot com
2021-10-25 13:54 ` [Bug testsuite/102835] " ro at gcc dot gnu.org
2021-10-26 12:28 ` cvs-commit at gcc dot gnu.org
2021-10-26 12:29 ` ro at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).