[Bug middle-end/102857] New: [12 regression] r12-4526 caused regressions on vect/bb-slp-16.c and ssa-dom-thread-7.c

[Bug middle-end/102857] New: [12 regression] r12-4526 caused regressions on vect/bb-slp-16.c and ssa-dom-thread-7.c

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

            Bug ID: 102857
           Summary: [12 regression] r12-4526 caused regressions on
                    vect/bb-slp-16.c and ssa-dom-thread-7.c
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: clyon at gcc dot gnu.org
  Target Milestone: ---

r12-4526 (g:d8edfadfc7a9795b65177a50ce44fd348858e844) caused regressions.

On aarch64 and arm-none-linux-gnueabihf with-arch armv7-a+mp+sec+neon-fp16
FAIL: gcc.dg/vect/bb-slp-16.c execution test

On both aarch64/arm
FAIL: gcc.dg/tree-ssa/ssa-dom-thread-7.c scan-tree-dump thread3 "Jumps
threaded: 12"

On arm-none-linux-gnueabihf --with-arch armv7-a+mp+sec+neon-fp16
FAIL: gcc.target/arm/ivopts-4.c object-size text <= 36

The last one is very fragile and depends on the actual target/flags.

[Bug middle-end/102857] [12 regression] r12-4526 caused regressions on vect/bb-slp-16.c and ssa-dom-thread-7.c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug middle-end/102857] [12 regression] r12-4526 caused regressions on vect/bb-slp-16.c and ssa-dom-thread-7.c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
For me on x86_64 I get:
gcc.dg/tree-ssa/ssa-dom-thread-7.c: dump file does not exist
UNRESOLVED: gcc.dg/tree-ssa/ssa-dom-thread-7.c scan-tree-dump-not vrp-thread2
"Jumps threaded"

[Bug middle-end/102857] [12 regression] r12-4526 caused regressions on vect/bb-slp-16.c and ssa-dom-thread-7.c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
vect/bb-slp-16.c has been fixed.

[Bug middle-end/102857] [12 regression] r12-4526 caused regressions on ssa-dom-thread-7.c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[12 regression] r12-4526    |[12 regression] r12-4526
                   |caused regressions on       |caused regressions on
                   |vect/bb-slp-16.c and        |ssa-dom-thread-7.c
                   |ssa-dom-thread-7.c          |

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I can confirm ssa-dom-thread-7.c

FAIL: gcc.dg/tree-ssa/ssa-dom-thread-7.c scan-tree-dump thread3 "Jumps
threaded: 12"

[Bug testsuite/102857] [12 regression] r12-4526 caused regressions on ssa-dom-thread-7.c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|middle-end                  |testsuite
                 CC|                            |aldyh at gcc dot gnu.org,
                   |                            |pinskia at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
           Keywords|wrong-code                  |
   Last reconfirmed|                            |2021-10-22
     Ever confirmed|0                           |1

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
/* { dg-final { scan-tree-dump "Jumps threaded: 12"  "thread3" } } */
/* { dg-final { scan-tree-dump-not "Jumps threaded"  "dom2" } } */

/* aarch64 has the highest CASE_VALUES_THRESHOLD in GCC.  It's high enough
   to change decisions in switch expansion which in turn can expose new
   jump threading opportunities.  Skip the later tests on aarch64.  */
/* { dg-final { scan-tree-dump-not "Jumps threaded"  "dom3" { target { !
aarch64*-*-* } } } } */
/* { dg-final { scan-tree-dump-not "Jumps threaded"  "vrp-thread2" { target { !
aarch64*-*-* } } } } */

Someone didn't update this for aarch64 which is why you get:

gcc.dg/tree-ssa/ssa-dom-thread-7.c: dump file does not exist
UNRESOLVED: gcc.dg/tree-ssa/ssa-dom-thread-7.c scan-tree-dump-not vrp-thread2
"Jumps threaded"

On x86_64 also.

Christophe,
  Can you file gcc.target/arm/ivopts-4.c seperately? Since it seems unrelated
to others. And this one can be for the ssa-dom-thread-7.c failure only.

[Bug testsuite/102857] [12 regression] r12-4526 caused regressions on ssa-dom-thread-7.c

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

--- Comment #5 from Christophe Lyon <clyon at gcc dot gnu.org> ---
Sure, I just filed PR 102906 for the ivopts-4.c issue on arm.

[Bug testsuite/102857] [12 regression] r12-4526 caused regressions on ssa-dom-thread-7.c

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

--- Comment #6 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Created attachment 51654
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51654&action=edit
proposed patch

Does this fix the problem on aarch64?

[Bug testsuite/102857] [12 regression] r12-4526 caused regressions on ssa-dom-thread-7.c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Aldy Hernandez from comment #6)
> Created attachment 51654 [details]
> proposed patch
> 
> Does this fix the problem on aarch64?

I get:
Running
/home/ubuntu/src/upstream-gcc-aarch64/gcc/gcc/testsuite/gcc.dg/tree-ssa/tree-ssa.exp
...
FAIL: gcc.dg/tree-ssa/ssa-dom-thread-7.c scan-tree-dump thread3 "Jumps
threaded: 12"
Let me attach the dump files.

[Bug testsuite/102857] [12 regression] r12-4526 caused regressions on ssa-dom-thread-7.c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 51655
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51655&action=edit
Dump files for aarch64

[Bug testsuite/102857] [12 regression] r12-4526 caused regressions on ssa-dom-thread-7.c

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

--- Comment #9 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #7)
> (In reply to Aldy Hernandez from comment #6)
> > Created attachment 51654 [details]
> > proposed patch
> > 
> > Does this fix the problem on aarch64?
> 
> I get:
> Running
> /home/ubuntu/src/upstream-gcc-aarch64/gcc/gcc/testsuite/gcc.dg/tree-ssa/tree-
> ssa.exp ...
> FAIL: gcc.dg/tree-ssa/ssa-dom-thread-7.c scan-tree-dump thread3 "Jumps
> threaded: 12"
> Let me attach the dump files.

$ grep Jumps.threaded *thread3
Jumps threaded: 20

The regex matches 12 but aarch64 20.

I really hate this test.  It never catches anything, and only creates an
endless amount of busy work.

[Bug testsuite/102857] [12 regression] r12-4526 caused regressions on ssa-dom-thread-7.c

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51654|0                           |1
        is obsolete|                            |

--- Comment #10 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Created attachment 51656
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51656&action=edit
proposed patch 2

How about this?

[Bug testsuite/102857] [12 regression] r12-4526 caused regressions on ssa-dom-thread-7.c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

--- Comment #11 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Aldy Hernandez from comment #10)
> Created attachment 51656 [details]
> proposed patch 2
> 
> How about this?

I can confirm the patch works on aarch64-linux-gnu and x86_64-linux-gnu.

[Bug testsuite/102857] [12 regression] r12-4526 caused regressions on ssa-dom-thread-7.c

[aldyh at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

--- Comment #12 from Aldy Hernandez <aldyh at redhat dot com> ---
Thank you for your help on this (and the myriad of other PRs ;-)).
I'll submit upstream.

On Sat, Oct 23, 2021 at 11:06 AM pinskia at gcc dot gnu.org
<gcc-bugzilla@gcc.gnu.org> wrote:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857
>
> --- Comment #11 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
> (In reply to Aldy Hernandez from comment #10)
> > Created attachment 51656 [details]
> > proposed patch 2
> >
> > How about this?
>
> I can confirm the patch works on aarch64-linux-gnu and x86_64-linux-gnu.
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
>

[Bug testsuite/102857] [12 regression] r12-4526 caused regressions on ssa-dom-thread-7.c

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Aldy Hernandez <aldyh@gcc.gnu.org>:

https://gcc.gnu.org/g:4e417eea8f3f14131f7370f9bd5dd568611d11df

commit r12-4701-g4e417eea8f3f14131f7370f9bd5dd568611d11df
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Sat Oct 23 08:59:24 2021 +0200

    [PR testsuite/102857] Tweak ssa-dom-thread-7.c for aarch64.

    First, ssa-dom-thread-7 was looking at a dump file that was not
    being generated.  This probably happened in the detangling of the VRP
    threader from VRP, and I didn't notice because the test came back as
    with UNRESOLVED instead of FAIL.

    Second, aarch64 gets far more threads than other architectures (20
    versus 12).  The difference is sufficiently different to make the
    regex awkward.

    We already have special casing for aarch64 in other parts of this
    test, so perhaps it's simplest to have an arch specific test
    for the thread3 count.

    I don't know perhaps there's a better way.  I wake up with chills in
    the middle of the night thinking about this test ;-).

    Tested on x86-64 Linux and aarch64 Linux.

    gcc/testsuite/ChangeLog:

            PR testsuite/102857
            * gcc.dg/tree-ssa/ssa-dom-thread-7.c: Add -fdump-tree-vrp2-stats.
            Tweak for aarch64.

[Bug testsuite/102857] [12 regression] r12-4526 caused regressions on ssa-dom-thread-7.c

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102857

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
fixed