public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/102876] GCC fails to use constant initialization even when it knows the value to initialize Date: Tue, 26 Oct 2021 11:38:32 +0000 [thread overview] Message-ID: <bug-102876-4-Pvs9PllfPV@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-102876-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102876 --- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> --- (In reply to Mathias Stearn from comment #12) > (In reply to Jakub Jelinek from comment #10) > > So we'd just punt at optimizing that, we don't know if b is read or written > > by foo (and, note, it doesn't have to be just the case of explicitly being > > passed address of some var, it can get the address through other means). > > On the other side, we can't optimize b to b: .long 2, because bar can use > > the variable and/or modify it, so by using 2 as static initializer bar would > > be miscompiled. > > I'm pretty sure that that is explicitly allowed by > https://eel.is/c++draft/basic.start.static#3, so it should *not* be > considered a miscompilation. The example only shows reading from another > static-duration variable's initializer, but I believe writing would also be > covered. You are clearly talking about a different case than I was. Once a variable is initialized, dynamic initializers which are ordered after that certainly can't see a different value of the var than it should. What you refer to is that because of the foo call in my testcase the optimizer can still optimize b's initialization from dynamic to static b = 1 initialization. But, when bar is called, b needs to be 1, not 2. >From what you wrote, I bet llvm implements what I was talking about in #c8 before "But I'm worried", i.e. if the static initialization function is optimized into just a series of constant stores, all the vars in it can be optimized. With the markers I've mentioned, we could consider each dynamic initialization individually, rather than just are all initializations constant, then optimize, otherwise punt.
next prev parent reply other threads:[~2021-10-26 11:38 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-21 11:48 [Bug c++/102876] New: " redbeard0531 at gmail dot com 2021-10-21 12:37 ` [Bug c++/102876] " redi at gcc dot gnu.org 2021-10-21 12:52 ` rguenth at gcc dot gnu.org 2021-10-21 13:43 ` redbeard0531 at gmail dot com 2021-10-21 14:50 ` ppalka at gcc dot gnu.org 2021-10-21 15:20 ` jakub at gcc dot gnu.org 2021-10-21 18:36 ` jason at gcc dot gnu.org 2021-10-21 19:32 ` jason at gcc dot gnu.org 2021-10-22 21:35 ` pinskia at gcc dot gnu.org 2021-10-25 9:55 ` jakub at gcc dot gnu.org 2021-10-25 21:19 ` jason at gcc dot gnu.org 2021-10-26 8:41 ` jakub at gcc dot gnu.org 2021-10-26 8:46 ` jakub at gcc dot gnu.org 2021-10-26 11:04 ` redbeard0531 at gmail dot com 2021-10-26 11:38 ` jakub at gcc dot gnu.org [this message] 2021-10-27 17:11 ` jakub at gcc dot gnu.org 2021-11-03 18:25 ` jakub at gcc dot gnu.org 2022-10-17 14:11 ` ppalka at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102876-4-Pvs9PllfPV@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).