public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jason at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/102876] GCC fails to use constant initialization even when it knows the value to initialize
Date: Mon, 25 Oct 2021 21:19:01 +0000	[thread overview]
Message-ID: <bug-102876-4-nb9zFT7htA@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102876-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102876

--- Comment #9 from Jason Merrill <jason at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #8)
> But I'm worried about larger TUs where not all dynamic initialization can be
> optimized into constants.  E.g. if there remain any function calls where the
> alias analysis could think they can read or modify the vars or their
> subobjects etc., we'd need to punt.

Would we?  If the variable isn't const, it's OK for later initializers to
modify its value, I wouldn't think that would prevent us from turning its
initializer into a constant value.

> Perhaps we could when generating these functions wrap the dynamic
> initialization of each var by calls into some new IFN that would take
> address of the variable and for alias analysis say it reads it but doesn't
> modify and doesn't escape the address.  In C++ one can't read the var in
> other initializers until it has been constructed, right?  So the opening IFN
> would stand as the first stmt that may read or write the variable and
> similarly everything after the closing IFN would be considered unrelated
> code to that.

This seems like a more general issue: after a variable declared const has
completed its initialization, it can't be modified.  Would this be useful to
mark, kind of like we use a clobber for end of life?

> Not sure if we can reliably detect that the variable was declared read-only
> and isn't TREE_READONLY only because it has dynamic initialization (and that
> it is safe to optimize it into a .rodata var).

Can't you just look at the type?

  parent reply	other threads:[~2021-10-25 21:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 11:48 [Bug c++/102876] New: " redbeard0531 at gmail dot com
2021-10-21 12:37 ` [Bug c++/102876] " redi at gcc dot gnu.org
2021-10-21 12:52 ` rguenth at gcc dot gnu.org
2021-10-21 13:43 ` redbeard0531 at gmail dot com
2021-10-21 14:50 ` ppalka at gcc dot gnu.org
2021-10-21 15:20 ` jakub at gcc dot gnu.org
2021-10-21 18:36 ` jason at gcc dot gnu.org
2021-10-21 19:32 ` jason at gcc dot gnu.org
2021-10-22 21:35 ` pinskia at gcc dot gnu.org
2021-10-25  9:55 ` jakub at gcc dot gnu.org
2021-10-25 21:19 ` jason at gcc dot gnu.org [this message]
2021-10-26  8:41 ` jakub at gcc dot gnu.org
2021-10-26  8:46 ` jakub at gcc dot gnu.org
2021-10-26 11:04 ` redbeard0531 at gmail dot com
2021-10-26 11:38 ` jakub at gcc dot gnu.org
2021-10-27 17:11 ` jakub at gcc dot gnu.org
2021-11-03 18:25 ` jakub at gcc dot gnu.org
2022-10-17 14:11 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102876-4-nb9zFT7htA@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).