public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "segher at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libffi/102923] [12 Regression] powerpc64 (BE) linux all languages bootstrap broken after libffi 3.4.2 import. Date: Mon, 25 Oct 2021 15:50:11 +0000 [thread overview] Message-ID: <bug-102923-4-qDQvY9SdaG@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-102923-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102923 --- Comment #4 from Segher Boessenkool <segher at gcc dot gnu.org> --- (In reply to Jakub Jelinek from comment #1) > The stvx stuff is guarded by #ifdef __VEC__, so perhaps the lvx stuff should > be too, or there should be .machine push; .machine power7; ... .machine pop; > or something similar around it? Just .machine altivec is enough, no push/pop shenanigans needed. This can be either inside or outside an #ifdef __VEC__ block, just personal style preference really :-) I would put it at the start of the file. > At least in linux64_closure.S, perhaps guarding it with #ifdef __VEC__ might > be ok, because the C code will not use that code if __VEC__ isn't defined: > #elif !defined(__VEC__) > /* If compiled without vector register support (used by assembly)... */ > if ((cif->abi & FFI_LINUX_LONG_DOUBLE_IEEE128) != 0) > return FFI_BAD_ABI; > But not sure about linux64.S if it doesn't suffer from the same problem. Note that __VEC__ does not mean the current CPU can execute those insns, of course, so these #ifdefs are only good if you compile this file twice, or similar?
next prev parent reply other threads:[~2021-10-25 15:50 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-25 8:45 [Bug bootstrap/102923] New: " iains at gcc dot gnu.org 2021-10-25 8:52 ` [Bug bootstrap/102923] " rguenth at gcc dot gnu.org 2021-10-25 9:08 ` jakub at gcc dot gnu.org 2021-10-25 9:11 ` iains at gcc dot gnu.org 2021-10-25 13:07 ` [Bug libffi/102923] " hjl.tools at gmail dot com 2021-10-25 15:50 ` segher at gcc dot gnu.org [this message] 2021-10-25 15:59 ` jakub at gcc dot gnu.org 2021-10-25 17:07 ` hjl.tools at gmail dot com 2021-10-25 17:11 ` hjl.tools at gmail dot com 2021-10-25 21:28 ` segher at gcc dot gnu.org 2021-12-29 15:36 ` jakub at gcc dot gnu.org 2021-12-29 19:46 ` segher at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102923-4-qDQvY9SdaG@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).