public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "aldyh at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/102981] [12 Regression] Dead Code Elimination Regression at -O3 (trunk vs 11.2.0)
Date: Wed, 17 Nov 2021 09:49:57 +0000	[thread overview]
Message-ID: <bug-102981-4-tSThqYB9mM@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102981-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102981

--- Comment #6 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
This looks like a class of problems we could easily get if we wanted.  The
pattern is:

PREHEADER
    |
    |
    V
  HEADER --> LOOPEXIT
    |
    |
    V
   SUCC
    |  \
    |   \
   DEAD  \
     |   /
     |  /
     | v
   XXXXXX

On the PREHEADER->HEADER->SUCC path we want to know if the edge out of SUCC can
be statically determined.  The threader can't do this for a number of reasons. 
First, we'd be essentially peeling an iteration.  Second, IIUC, we'd be
rotating the loop.

However, there's no reason we can't catch this in a loop optimizer like we did
with the loopch pass.  This is the exact type of problem that is trivially
handled by the path solver, which is quite cheap when you don't have to do full
path discovery like the threader has to do.

Something like:

gimple *control = gimple_outgoing_range_stmt_p (succ);
if (control) {
  auto_vec<basic_block> bbs (3);
  bbs.quick_push (preheader);
  bbs.quick_push (header);
  bbs.quick_push (succ);

  int_range<2> r;
  path_range_query query;
  query.compute_ranges (bbs);
  query.range_of_stmt (r, control);
  if (r == desired_static_value...)
    peel();
...
}

If "dead code on the first iteration" is something we want to handle, I could
help with the ranger bits if someone gives me a hand with the loop bits.

  parent reply	other threads:[~2021-11-17  9:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28  9:38 [Bug tree-optimization/102981] New: " theodort at inf dot ethz.ch
2021-10-28 11:45 ` [Bug tree-optimization/102981] " rguenth at gcc dot gnu.org
2021-10-30  7:03 ` aldyh at gcc dot gnu.org
2021-10-30 17:42 ` aldyh at gcc dot gnu.org
2021-10-30 18:08 ` aldyh at gcc dot gnu.org
2021-11-04 18:47 ` law at gcc dot gnu.org
2021-11-16 20:08 ` aldyh at gcc dot gnu.org
2021-11-17  9:49 ` aldyh at gcc dot gnu.org [this message]
2021-11-23 19:19 ` aldyh at gcc dot gnu.org
2022-05-06  8:31 ` [Bug tree-optimization/102981] [12/13 " jakub at gcc dot gnu.org
2023-05-08 12:22 ` [Bug tree-optimization/102981] [12/13/14 " rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102981-4-tSThqYB9mM@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).