[Bug middle-end/103059] New: [10 regression][VAX] ICE in postreload with the ASHIFT form of scaled indexed addressing

[Bug middle-end/103059] New: [10 regression][VAX] ICE in postreload with the ASHIFT form of scaled indexed addressing

[macro at orcam dot me.uk]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103059

            Bug ID: 103059
           Summary: [10 regression][VAX] ICE in postreload with the ASHIFT
                    form of scaled indexed addressing
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: macro at orcam dot me.uk
          Reporter: macro at orcam dot me.uk
  Target Milestone: ---
            Target: vax-netbsdelf

We have a `vax-netbsdelf' target regression ultimately caused by commit
c605a8bf9270 ("VAX: Accept ASHIFT in address expressions") (needed for
LRA) and as of commit 4a960d548b7d ("Avoid invalid loop transformations
in jump threading registry.") causing a build error in libgcc:

.../libgcc/libgcov-driver.c: In function 'gcov_do_dump':
.../libgcc/libgcov-driver.c:686:1: error: insn does not satisfy its
constraints:
  686 | }
      | ^
(insn 2051 2050 2052 185 (set (reg/f:SI 0 %r0 [555])
        (plus:SI (ashift:SI (mem/c:SI (plus:SI (reg/f:SI 13 %fp)
                        (const_int -28 [0xffffffffffffffe4])) [40 %sfp+-28 S4
A32])
                (const_int 3 [0x3]))
            (plus:SI (reg/v/f:SI 9 %r9 [orig:176 fn_buffer ] [176])
                (const_int 24 [0x18])))) ".../libgcc/libgcov-driver.c":172:40
614 {movaddrdi}
     (nil))
during RTL pass: postreload
.../libgcc/libgcov-driver.c:686:1: internal compiler error: in
extract_constrain_insn, at recog.c:2670
0x1122a5ff _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
        .../gcc/rtl-error.c:108
0x1122a697 _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
        .../gcc/rtl-error.c:118
0x111b5f2f extract_constrain_insn(rtx_insn*)
        .../gcc/recog.c:2670
0x11143eef reload_cse_simplify_operands
        .../gcc/postreload.c:407
0x11142fdb reload_cse_simplify
        .../gcc/postreload.c:132
0x11143533 reload_cse_regs_1
        .../gcc/postreload.c:238
0x11142ce7 reload_cse_regs
        .../gcc/postreload.c:66
0x1114af33 execute
        .../gcc/postreload.c:2355
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

This is because reload does not recognize the ASHIFT form of scaled 
indexed addressing that the offending commit enabled the backend to 
produce, and as seen in the RTL above lets the pseudo holding the 
index part become the original memory reference rather than reloading it 
into a hard register.

Cf. <https://gcc.gnu.org/pipermail/gcc-patches/2021-March/567256.html>, 
and commit 6b3034eaba83 ("lra: Canonicalize mult to shift in address 
reloads").

Bug filed for tracking purposes, posting a fix right away.

[Bug middle-end/103059] [10 regression][VAX] ICE in postreload with the ASHIFT form of scaled indexed addressing

[macro at orcam dot me.uk]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103059

Maciej W. Rozycki <macro at orcam dot me.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-11-03
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1

[Bug middle-end/103059] [12 regression][VAX] ICE in postreload with the ASHIFT form of scaled indexed addressing

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103059

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11 regression][VAX] ICE in |[12 regression][VAX] ICE in
                   |postreload with the ASHIFT  |postreload with the ASHIFT
                   |form of scaled indexed      |form of scaled indexed
                   |addressing                  |addressing
   Target Milestone|---                         |12.0

[Bug middle-end/103059] [12 regression][VAX] ICE in postreload with the ASHIFT form of scaled indexed addressing

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103059

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Maciej W. Rozycki <macro@gcc.gnu.org>:

https://gcc.gnu.org/g:29e1cbdc0c6e7d3de10478ef2b881900545c2a55

commit r12-5500-g29e1cbdc0c6e7d3de10478ef2b881900545c2a55
Author: Maciej W. Rozycki <macro@embecosm.com>
Date:   Wed Nov 24 13:15:06 2021 +0000

    PR middle-end/103059: reload: Also accept ASHIFT with indexed addressing

    Correct a `vax-netbsdelf' target regression ultimately caused by commit
    c605a8bf9270 ("VAX: Accept ASHIFT in address expressions") (needed for
    LRA) and as of commit 4a960d548b7d ("Avoid invalid loop transformations
    in jump threading registry.") causing a build error in libgcc:

    .../libgcc/libgcov-driver.c: In function 'gcov_do_dump':
    .../libgcc/libgcov-driver.c:686:1: error: insn does not satisfy its
constraints:
      686 | }
          | ^
    (insn 2051 2050 2052 185 (set (reg/f:SI 0 %r0 [555])
            (plus:SI (ashift:SI (mem/c:SI (plus:SI (reg/f:SI 13 %fp)
                            (const_int -28 [0xffffffffffffffe4])) [40 %sfp+-28
S4 A32])
                    (const_int 3 [0x3]))
                (plus:SI (reg/v/f:SI 9 %r9 [orig:176 fn_buffer ] [176])
                    (const_int 24 [0x18]))))
".../libgcc/libgcov-driver.c":172:40 614 {movaddrdi}
         (nil))
    during RTL pass: postreload
    .../libgcc/libgcov-driver.c:686:1: internal compiler error: in
extract_constrain_insn, at recog.c:2670
    0x1122a5ff _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
            .../gcc/rtl-error.c:108
    0x1122a697 _fatal_insn_not_found(rtx_def const*, char const*, int, char
const*)
            .../gcc/rtl-error.c:118
    0x111b5f2f extract_constrain_insn(rtx_insn*)
            .../gcc/recog.c:2670
    0x11143eef reload_cse_simplify_operands
            .../gcc/postreload.c:407
    0x11142fdb reload_cse_simplify
            .../gcc/postreload.c:132
    0x11143533 reload_cse_regs_1
            .../gcc/postreload.c:238
    0x11142ce7 reload_cse_regs
            .../gcc/postreload.c:66
    0x1114af33 execute
            .../gcc/postreload.c:2355
    Please submit a full bug report,
    with preprocessed source if appropriate.
    Please include the complete backtrace with any bug report.
    See <https://gcc.gnu.org/bugs/> for instructions.

    This is because reload does not recognize the ASHIFT form of scaled
    indexed addressing that the offending commit enabled the backend to
    produce, and as seen in the RTL above lets the pseudo holding the
    index part become the original memory reference rather than reloading it
    into a hard register.

    Fix it then by adding said form to reload, removing the build failure
    and numerous similar regressions throughout `vax-netbsdelf' test suites
    run with the source as at right before the build regression.

    Cf. <https://gcc.gnu.org/pipermail/gcc-patches/2021-March/567256.html>,
    and commit 6b3034eaba83 ("lra: Canonicalize mult to shift in address
    reloads").

            gcc/
            PR middle-end/103059
            * reload.c (find_reloads_address_1): Also accept the ASHIFT form
            of indexed addressing.
            (find_reloads): Adjust accordingly.

[Bug middle-end/103059] [12 regression][VAX] ICE in postreload with the ASHIFT form of scaled indexed addressing

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103059

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Maciej W. Rozycki
<macro@gcc.gnu.org>:

https://gcc.gnu.org/g:78421afafde5156d6d4c6c7073653e4b92f88e3d

commit r11-9306-g78421afafde5156d6d4c6c7073653e4b92f88e3d
Author: Maciej W. Rozycki <macro@embecosm.com>
Date:   Wed Nov 24 13:15:06 2021 +0000

    PR middle-end/103059: reload: Also accept ASHIFT with indexed addressing

    Correct a `vax-netbsdelf' target regression ultimately caused by commit
    c605a8bf9270 ("VAX: Accept ASHIFT in address expressions") (needed for
    LRA) and as of commit 4a960d548b7d ("Avoid invalid loop transformations
    in jump threading registry.") causing a build error in libgcc:

    .../libgcc/libgcov-driver.c: In function 'gcov_do_dump':
    .../libgcc/libgcov-driver.c:686:1: error: insn does not satisfy its
constraints:
      686 | }
          | ^
    (insn 2051 2050 2052 185 (set (reg/f:SI 0 %r0 [555])
            (plus:SI (ashift:SI (mem/c:SI (plus:SI (reg/f:SI 13 %fp)
                            (const_int -28 [0xffffffffffffffe4])) [40 %sfp+-28
S4 A32])
                    (const_int 3 [0x3]))
                (plus:SI (reg/v/f:SI 9 %r9 [orig:176 fn_buffer ] [176])
                    (const_int 24 [0x18]))))
".../libgcc/libgcov-driver.c":172:40 614 {movaddrdi}
         (nil))
    during RTL pass: postreload
    .../libgcc/libgcov-driver.c:686:1: internal compiler error: in
extract_constrain_insn, at recog.c:2670
    0x1122a5ff _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
            .../gcc/rtl-error.c:108
    0x1122a697 _fatal_insn_not_found(rtx_def const*, char const*, int, char
const*)
            .../gcc/rtl-error.c:118
    0x111b5f2f extract_constrain_insn(rtx_insn*)
            .../gcc/recog.c:2670
    0x11143eef reload_cse_simplify_operands
            .../gcc/postreload.c:407
    0x11142fdb reload_cse_simplify
            .../gcc/postreload.c:132
    0x11143533 reload_cse_regs_1
            .../gcc/postreload.c:238
    0x11142ce7 reload_cse_regs
            .../gcc/postreload.c:66
    0x1114af33 execute
            .../gcc/postreload.c:2355
    Please submit a full bug report,
    with preprocessed source if appropriate.
    Please include the complete backtrace with any bug report.
    See <https://gcc.gnu.org/bugs/> for instructions.

    This is because reload does not recognize the ASHIFT form of scaled
    indexed addressing that the offending commit enabled the backend to
    produce, and as seen in the RTL above lets the pseudo holding the
    index part become the original memory reference rather than reloading it
    into a hard register.

    Fix it then by adding said form to reload, removing the build failure
    and numerous similar regressions throughout `vax-netbsdelf' test suites
    run with the source as at right before the build regression.

    Cf. <https://gcc.gnu.org/pipermail/gcc-patches/2021-March/567256.html>,
    and commit 6b3034eaba83 ("lra: Canonicalize mult to shift in address
    reloads").

            gcc/
            PR middle-end/103059
            * reload.c (find_reloads_address_1): Also accept the ASHIFT form
            of indexed addressing.
            (find_reloads): Adjust accordingly.

    (cherry picked from commit 29e1cbdc0c6e7d3de10478ef2b881900545c2a55)

[Bug middle-end/103059] [12 regression][VAX] ICE in postreload with the ASHIFT form of scaled indexed addressing

[macro at orcam dot me.uk]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103059

Maciej W. Rozycki <macro at orcam dot me.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Maciej W. Rozycki <macro at orcam dot me.uk> ---
Fixed on trunk and backported to GCC 11.  Closing bug.