public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "thiago at kde dot org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/103069] cmpxchg isn't optimized Date: Wed, 03 Nov 2021 20:53:13 +0000 [thread overview] Message-ID: <bug-103069-4-afQFOapnFw@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-103069-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103069 --- Comment #1 from Thiago Macieira <thiago at kde dot org> --- (the assembly doesn't match the source code, but we got your point) Another possible improvement for the __atomic_fetch_{and,nand,or} functions is that it can check whether the fetched value is already correct and branch out. In your example, the __atomic_fetch_or with 0x40000000 can check if that bit is already set and, if so, not execute the CMPXCHG at all. This is a valid solution for x86 on memory orderings up to acq_rel. For other architectures, they may still need barriers. For seq_cst, we either need a barrier or we need to execute the CMPXCHG at least once. Therefore, the emitted code might want to optimistically execute the operation once and, if it fails, enter the load loop. That's a slightly longer codegen. Whether we want that under -Os or not, you'll have to be the judge. Prior art: glibc/sysdeps/x86_64/nptl/pthread_spin_lock.S: ENTRY(__pthread_spin_lock) 1: LOCK decl 0(%rdi) jne 2f xor %eax, %eax ret .align 16 2: rep nop cmpl $0, 0(%rdi) jg 1b jmp 2b END(__pthread_spin_lock) This does the atomic operation once, hoping it'll succeed. If it fails, it enters the PAUSE+CMP+JG loop until the value is suitable.
next prev parent reply other threads:[~2021-11-03 20:53 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-03 19:08 [Bug target/103069] New: " hjl.tools at gmail dot com 2021-11-03 20:53 ` thiago at kde dot org [this message] 2021-11-04 21:25 ` [Bug target/103069] " thiago at kde dot org 2021-11-15 11:10 ` cvs-commit at gcc dot gnu.org 2021-11-15 14:26 ` hjl.tools at gmail dot com 2021-11-18 8:31 ` cvs-commit at gcc dot gnu.org 2022-01-24 23:49 ` hjl.tools at gmail dot com 2022-01-24 23:52 ` hjl.tools at gmail dot com 2022-01-24 23:53 ` hjl.tools at gmail dot com 2022-01-24 23:55 ` hjl.tools at gmail dot com 2022-01-25 0:04 ` thiago at kde dot org 2022-02-15 8:59 ` wwwhhhyyy333 at gmail dot com 2022-02-22 3:36 ` cvs-commit at gcc dot gnu.org 2022-02-22 3:38 ` wwwhhhyyy333 at gmail dot com 2022-02-22 4:16 ` thiago at kde dot org 2022-02-22 8:21 ` wwwhhhyyy333 at gmail dot com 2022-02-22 18:05 ` thiago at kde dot org 2022-02-22 18:41 ` jakub at gcc dot gnu.org 2022-02-22 20:25 ` thiago at kde dot org 2022-02-23 3:35 ` wwwhhhyyy333 at gmail dot com 2022-02-23 4:06 ` thiago at kde dot org 2022-04-13 8:18 ` cvs-commit at gcc dot gnu.org 2022-05-06 8:31 ` jakub at gcc dot gnu.org 2023-05-08 12:23 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-103069-4-afQFOapnFw@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).