public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/103069] cmpxchg isn't optimized
Date: Thu, 18 Nov 2021 08:31:07 +0000	[thread overview]
Message-ID: <bug-103069-4-hX2ExjVyCt@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103069-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103069

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Hongyu Wang <hongyuw@gcc.gnu.org>:

https://gcc.gnu.org/g:15f5e70cbb33b40c97325ef9d55557747a148d39

commit r12-5363-g15f5e70cbb33b40c97325ef9d55557747a148d39
Author: Hongyu Wang <hongyu.wang@intel.com>
Date:   Thu Nov 18 14:45:23 2021 +0800

    i386: Fix wrong codegen for -mrelax-cmpxchg-loop

    For -mrelax-cmpxchg-loop introduced by PR 103069/r12-5265, it would
    produce infinite loop. The correct code should be

    .L84:
            movl    (%rdi), %ecx
            movl    %eax, %edx
            orl     %esi, %edx
            cmpl    %eax, %ecx
            jne     .L82
            lock cmpxchgl   %edx, (%rdi)
            jne     .L84
            movl    %r8d, %eax  <<< retval is missing in previous impl
            ret
    .L82:
            rep nop
            jmp     .L84

    Adjust corresponding expander to fix such issue, and fix runtime test
    so the problem would be exposed.

    gcc/ChangeLog:

            * config/i386/i386-expand.c (ix86_expand_atomic_fetch_op_loop):
            Adjust generated cfg to avoid infinite loop.

    gcc/testsuite/ChangeLog:

            * gcc.target/i386/pr103069-2.c: Adjust.

  parent reply	other threads:[~2021-11-18  8:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 19:08 [Bug target/103069] New: " hjl.tools at gmail dot com
2021-11-03 20:53 ` [Bug target/103069] " thiago at kde dot org
2021-11-04 21:25 ` thiago at kde dot org
2021-11-15 11:10 ` cvs-commit at gcc dot gnu.org
2021-11-15 14:26 ` hjl.tools at gmail dot com
2021-11-18  8:31 ` cvs-commit at gcc dot gnu.org [this message]
2022-01-24 23:49 ` hjl.tools at gmail dot com
2022-01-24 23:52 ` hjl.tools at gmail dot com
2022-01-24 23:53 ` hjl.tools at gmail dot com
2022-01-24 23:55 ` hjl.tools at gmail dot com
2022-01-25  0:04 ` thiago at kde dot org
2022-02-15  8:59 ` wwwhhhyyy333 at gmail dot com
2022-02-22  3:36 ` cvs-commit at gcc dot gnu.org
2022-02-22  3:38 ` wwwhhhyyy333 at gmail dot com
2022-02-22  4:16 ` thiago at kde dot org
2022-02-22  8:21 ` wwwhhhyyy333 at gmail dot com
2022-02-22 18:05 ` thiago at kde dot org
2022-02-22 18:41 ` jakub at gcc dot gnu.org
2022-02-22 20:25 ` thiago at kde dot org
2022-02-23  3:35 ` wwwhhhyyy333 at gmail dot com
2022-02-23  4:06 ` thiago at kde dot org
2022-04-13  8:18 ` cvs-commit at gcc dot gnu.org
2022-05-06  8:31 ` jakub at gcc dot gnu.org
2023-05-08 12:23 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103069-4-hX2ExjVyCt@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).