[Bug c++/103133] New: Binary built with -static using std::thread crashes

[Bug c++/103133] New: Binary built with -static using std::thread crashes

[loximann at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

            Bug ID: 103133
           Summary: Binary built with -static using std::thread crashes
           Product: gcc
           Version: 11.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: loximann at gmail dot com
  Target Milestone: ---

The following program crashes when built with -static on Fedora 35:

    #include <thread>

    int main(int argc, char *argv[])
    {
        std::thread foo{[](){}};
        foo.join();

        return 0;
    }

Dynamic linking works fine though:

    $ g++ f35_thread_static_broken.cpp
    $ ./a.out 
    $ g++ -static f35_thread_static_broken.cpp
    $ ./a.out
    zsh: segmentation fault (core dumped)  ./a.out

[Bug libstdc++/103133] Binary built with -static using std::thread crashes

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-11-08

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The binary doesn't have a definition of pthread_join.

[Bug libstdc++/103133] Binary built with -static using std::thread crashes

[fw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

Florian Weimer <fw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fw at gcc dot gnu.org

--- Comment #2 from Florian Weimer <fw at gcc dot gnu.org> ---
libstdc++.a still uses weak symbols. I assumed we had already removed all that
weak symbol stuff from libstdc++ for __GLIBC_PREREQ (2, 34).

[Bug libstdc++/103133] Binary built with -static using std::thread crashes

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Still a user error - you should link with -pthread

[Bug libstdc++/103133] Binary built with -static using std::thread crashes

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #3)
> Still a user error - you should link with -pthread

That doesn't help here though.

[Bug libstdc++/103133] Binary built with -static using std::thread crashes

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Florian Weimer from comment #2)
> libstdc++.a still uses weak symbols. I assumed we had already removed all
> that weak symbol stuff from libstdc++ for __GLIBC_PREREQ (2, 34).

No, none of that work has even started yet.

[Bug libstdc++/103133] Binary built with -static using std::thread crashes

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
             Status|NEW                         |ASSIGNED
   Target Milestone|---                         |11.3

[Bug libstdc++/103133] Binary built with -static using std::thread crashes

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:80fe172ba9820199c2bbce5d0611ffca27823049

commit r12-5108-g80fe172ba9820199c2bbce5d0611ffca27823049
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Nov 9 23:45:36 2021 +0000

    libstdc++: Disable gthreads weak symbols for glibc 2.34 [PR103133]

    Since Glibc 2.34 all pthreads symbols are defined directly in libc not
    libpthread, and since Glibc 2.32 we have used __libc_single_threaded to
    avoid unnecessary locking in single-threaded programs. This means there
    is no reason to avoid linking to libpthread now, and so no reason to use
    weak symbols defined in gthr-posix.h for all the pthread_xxx functions.

    libstdc++-v3/ChangeLog:

            PR libstdc++/100748
            PR libstdc++/103133
            * config/os/gnu-linux/os_defines.h (_GLIBCXX_GTHREAD_USE_WEAK):
            Define for glibc 2.34 and later.

[Bug libstdc++/103133] Binary built with -static using std::thread crashes

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed on trunk, backports needed too.

[Bug libstdc++/103133] Binary built with -static using std::thread crashes

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
For the record, musl does the same, since
g:85da5c3024f731e719c4093314da8edcd1056527

[Bug libstdc++/103133] Binary built with -static using std::thread crashes

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:293075002a7eaf1e9d457a1839bcaf83f8626824

commit r11-9301-g293075002a7eaf1e9d457a1839bcaf83f8626824
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Nov 9 23:45:36 2021 +0000

    libstdc++: Disable gthreads weak symbols for glibc 2.34 [PR103133]

    Since Glibc 2.34 all pthreads symbols are defined directly in libc not
    libpthread, and since Glibc 2.32 we have used __libc_single_threaded to
    avoid unnecessary locking in single-threaded programs. This means there
    is no reason to avoid linking to libpthread now, and so no reason to use
    weak symbols defined in gthr-posix.h for all the pthread_xxx functions.

    libstdc++-v3/ChangeLog:

            PR libstdc++/100748
            PR libstdc++/103133
            * config/os/gnu-linux/os_defines.h (_GLIBCXX_GTHREAD_USE_WEAK):
            Define for glibc 2.34 and later.

    (cherry picked from commit 80fe172ba9820199c2bbce5d0611ffca27823049)

[Bug libstdc++/103133] Binary built with -static using std::thread crashes

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for GCC 11.3

[Bug libstdc++/103133] Binary built with -static using std::thread crashes

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:18eecb8c4a97716d4bc4890b05c91f172fadc7b3

commit r10-10928-g18eecb8c4a97716d4bc4890b05c91f172fadc7b3
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Nov 9 23:45:36 2021 +0000

    libstdc++: Disable gthreads weak symbols for glibc 2.34 [PR103133]

    Since Glibc 2.34 all pthreads symbols are defined directly in libc not
    libpthread, and since Glibc 2.32 we have used __libc_single_threaded to
    avoid unnecessary locking in single-threaded programs. This means there
    is no reason to avoid linking to libpthread now, and so no reason to use
    weak symbols defined in gthr-posix.h for all the pthread_xxx functions.

    libstdc++-v3/ChangeLog:

            PR libstdc++/100748
            PR libstdc++/103133
            * config/os/gnu-linux/os_defines.h (_GLIBCXX_GTHREAD_USE_WEAK):
            Define for glibc 2.34 and later.

    (cherry picked from commit 80fe172ba9820199c2bbce5d0611ffca27823049)

[Bug libstdc++/103133] Binary built with -static using std::thread crashes

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103133

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|11.3                        |10.5

--- Comment #12 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Also fixed for 10.5