public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "crazylht at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/103194] [12 Regression] ice in optimize_atomic_bit_test_and with __sync_fetch_and_and since r12-5102-gfb161782545224f5
Date: Mon, 15 Nov 2021 09:06:00 +0000	[thread overview]
Message-ID: <bug-103194-4-loaYauxgrC@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103194-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103194

--- Comment #10 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to Hongtao.liu from comment #9)
> (In reply to H.J. Lu from comment #6)
> > Created attachment 51785 [details]
> > The v2 incomplete patch
> > 
> > Hongtao, please finish it.  Thanks.
> 
> I'm trying to handle narrowing part in match.pd and add else return; when
> precision is not equal.
> 
> (for bit_op (bit_and bit_xor bit_ior)
>  (simplify
>   (bit_op (convert@0 @1) (convert@2 @3))
>   (if (INTEGRAL_TYPE_P (type)
>       && INTEGRAL_TYPE_P (TREE_TYPE (@1))
>       && tree_nop_conversion_p (TREE_TYPE (@1), TREE_TYPE (@3))
>       && single_use (@0)
>       && single_use (@2)
>       && TYPE_PRECISION (type) < TYPE_PRECISION (TREE_TYPE (@1)))
>    (with { tree type1 = TREE_TYPE (@1); }
>     (convert (bit_op @1 (convert:type1 @3)))))))
> 
> (for bit_op (bit_and bit_xor bit_ior)
>  (simplify
>   (bit_op (convert@0 @1) INTEGER_CST@2)
>   (if (INTEGRAL_TYPE_P (type)
>       && INTEGRAL_TYPE_P (TREE_TYPE (@1))
>       && single_use (@0)
>       && TYPE_PRECISION (type) < TYPE_PRECISION (TREE_TYPE (@1)))
>    (convert (bit_op @1 { fold_convert (TREE_TYPE (@1), @2); })))))

hmm, cause infinite loop because of

      /* Convert (T)(x & c) into (T)x & (T)c, if c is an integer
         constants (if x has signed type, the sign bit cannot be set
         in c).  This folds extension into the BIT_AND_EXPR.
         ??? We don't do it for BOOLEAN_TYPE or ENUMERAL_TYPE because they
         very likely don't have maximal range for their precision and this
         transformation effectively doesn't preserve non-maximal ranges.  */
      if (TREE_CODE (type) == INTEGER_TYPE
          && TREE_CODE (op0) == BIT_AND_EXPR
          && TREE_CODE (TREE_OPERAND (op0, 1)) == INTEGER_CST)

  parent reply	other threads:[~2021-11-15  9:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 16:48 [Bug c/103194] New: ice in optimize_atomic_bit_test_and, at tree-ssa-ccp.c:3626 dcb314 at hotmail dot com
2021-11-11 16:50 ` [Bug c/103194] " dcb314 at hotmail dot com
2021-11-11 17:20 ` [Bug tree-optimization/103194] [12 Regression] ice in optimize_atomic_bit_test_and with __sync_fetch_and_and pinskia at gcc dot gnu.org
2021-11-11 18:56 ` hjl.tools at gmail dot com
2021-11-12  7:35 ` rguenth at gcc dot gnu.org
2021-11-12  9:29 ` [Bug tree-optimization/103194] [12 Regression] ice in optimize_atomic_bit_test_and with __sync_fetch_and_and since r12-5102-gfb161782545224f5 marxin at gcc dot gnu.org
2021-11-12 13:43 ` hjl.tools at gmail dot com
2021-11-13 15:04 ` hjl.tools at gmail dot com
2021-11-13 15:11 ` hjl.tools at gmail dot com
2021-11-15  1:23 ` crazylht at gmail dot com
2021-11-15  2:47 ` crazylht at gmail dot com
2021-11-15  8:32 ` crazylht at gmail dot com
2021-11-15  9:06 ` crazylht at gmail dot com [this message]
2021-11-15  9:12 ` pinskia at gcc dot gnu.org
2021-11-16  1:30 ` crazylht at gmail dot com
2021-11-16  1:49 ` hjl.tools at gmail dot com
2021-11-16  1:51 ` hjl.tools at gmail dot com
2021-11-16  2:24 ` crazylht at gmail dot com
2021-11-16  2:39 ` hjl.tools at gmail dot com
2021-11-16  3:26 ` hjl.tools at gmail dot com
2021-11-16  6:19 ` crazylht at gmail dot com
2021-11-16  6:45 ` crazylht at gmail dot com
2021-11-24  1:01 ` cvs-commit at gcc dot gnu.org
2021-11-24  1:02 ` crazylht at gmail dot com
2021-12-15 12:47 ` jakub at gcc dot gnu.org
2021-12-16  1:27 ` crazylht at gmail dot com
2021-12-19 23:47 ` hjl.tools at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103194-4-loaYauxgrC@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).