public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/103194] [12 Regression] ice in optimize_atomic_bit_test_and with __sync_fetch_and_and since r12-5102-gfb161782545224f5
Date: Wed, 24 Nov 2021 01:01:13 +0000	[thread overview]
Message-ID: <bug-103194-4-x3gFbshFFv@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103194-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103194

--- Comment #20 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>:

https://gcc.gnu.org/g:7df89377a7ae3906255e38a79be8e5d962c3a0df

commit r12-5486-g7df89377a7ae3906255e38a79be8e5d962c3a0df
Author: liuhongt <hongtao.liu@intel.com>
Date:   Tue Nov 16 13:36:36 2021 +0800

    Enhance optimize_atomic_bit_test_and to handle truncation.

    r12-5102-gfb161782545224f5 improves integer bit test on
    __atomic_fetch_[or|and]_* returns only for nop_convert, .i.e.

    transfrom

      mask_5 = 1 << bit_4(D);
      mask.0_1 = (unsigned int) mask_5;
      _2 = __atomic_fetch_or_4 (a_7(D), mask.0_1, 0);
      t1_9 = (int) _2;
      t2_10 = mask_5 & t1_9;

    to

      mask_5 = 1 << n_4(D);
      mask.1_1 = (unsigned int) mask_5;
      _11 = .ATOMIC_BIT_TEST_AND_SET (&pscc_a_1_4, n_4(D), 0);
      _8 = (int) _11;

    And this patch extend the original patch to handle truncation.
    .i.e.

    transform

      long int mask;
      mask_8 = 1 << n_7(D);
      mask.0_1 = (long unsigned int) mask_8;
      _2 = __sync_fetch_and_or_8 (&pscc_a_2_3, mask.0_1);
      _3 = (unsigned int) _2;
      _4 = (unsigned int) mask_8;
      _5 = _3 & _4;
      _6 = (int) _5;

    to

      long int mask;
      mask_8 = 1 << n_7(D);
      mask.0_1 = (long unsigned int) mask_8;
      _14 = .ATOMIC_BIT_TEST_AND_SET (&pscc_a_2_3, n_7(D), 0);
      _5 = (unsigned int) _14;
      _6 = (int) _5;

    2021-11-17  Hongtao Liu  <hongtao.liu@intel.com>
                H.J. Lu  <hongjiu.lu@intel.com>

    gcc/ChangeLog:

            PR tree-optimization/103194
            * match.pd (gimple_nop_atomic_bit_test_and_p): Extended to
            match truncation.
            * tree-ssa-ccp.c (gimple_nop_convert): Declare.
            (optimize_atomic_bit_test_and): Enhance
            optimize_atomic_bit_test_and to handle truncation.

    gcc/testsuite/ChangeLog:

            * gcc.target/i386/pr103194-2.c: New test.
            * gcc.target/i386/pr103194-3.c: New test.
            * gcc.target/i386/pr103194-4.c: New test.
            * gcc.target/i386/pr103194-5.c: New test.
            * gcc.target/i386/pr103194.c: New test.

  parent reply	other threads:[~2021-11-24  1:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 16:48 [Bug c/103194] New: ice in optimize_atomic_bit_test_and, at tree-ssa-ccp.c:3626 dcb314 at hotmail dot com
2021-11-11 16:50 ` [Bug c/103194] " dcb314 at hotmail dot com
2021-11-11 17:20 ` [Bug tree-optimization/103194] [12 Regression] ice in optimize_atomic_bit_test_and with __sync_fetch_and_and pinskia at gcc dot gnu.org
2021-11-11 18:56 ` hjl.tools at gmail dot com
2021-11-12  7:35 ` rguenth at gcc dot gnu.org
2021-11-12  9:29 ` [Bug tree-optimization/103194] [12 Regression] ice in optimize_atomic_bit_test_and with __sync_fetch_and_and since r12-5102-gfb161782545224f5 marxin at gcc dot gnu.org
2021-11-12 13:43 ` hjl.tools at gmail dot com
2021-11-13 15:04 ` hjl.tools at gmail dot com
2021-11-13 15:11 ` hjl.tools at gmail dot com
2021-11-15  1:23 ` crazylht at gmail dot com
2021-11-15  2:47 ` crazylht at gmail dot com
2021-11-15  8:32 ` crazylht at gmail dot com
2021-11-15  9:06 ` crazylht at gmail dot com
2021-11-15  9:12 ` pinskia at gcc dot gnu.org
2021-11-16  1:30 ` crazylht at gmail dot com
2021-11-16  1:49 ` hjl.tools at gmail dot com
2021-11-16  1:51 ` hjl.tools at gmail dot com
2021-11-16  2:24 ` crazylht at gmail dot com
2021-11-16  2:39 ` hjl.tools at gmail dot com
2021-11-16  3:26 ` hjl.tools at gmail dot com
2021-11-16  6:19 ` crazylht at gmail dot com
2021-11-16  6:45 ` crazylht at gmail dot com
2021-11-24  1:01 ` cvs-commit at gcc dot gnu.org [this message]
2021-11-24  1:02 ` crazylht at gmail dot com
2021-12-15 12:47 ` jakub at gcc dot gnu.org
2021-12-16  1:27 ` crazylht at gmail dot com
2021-12-19 23:47 ` hjl.tools at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103194-4-x3gFbshFFv@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).