public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/103195] [12 Regression] tfft2 text grows by 70% with -Ofast since r12-5113-gd70ef65692fced7a
Date: Fri, 12 Nov 2021 21:25:12 +0000	[thread overview]
Message-ID: <bug-103195-4-pzZsYIsLts@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103195-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103195

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjambor at suse dot cz

--- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
OK, quite surprisingly the code size growth is due to ipa-cp.
Due to early modref, we get two aggregate jump functions:

          value: 0x0, mask: 0xffffffffffffffe0
          VR  [1, -1]
        param 3: UNKNOWN
+         Aggregate passed by reference:
+           offset: 0, type: integer(kind=4), CONST: 33554432
          value: 0x0, mask: 0xfffffffffffffffc
          VR  [1, -1]
        param 4: CONST: &C.4517 -> -1
@@ -747,6 +744,8 @@
          value: 0x0, mask: 0xffffffffffffffe0
          VR  [1, -1]
        param 3: UNKNOWN
+         Aggregate passed by reference:
+           offset: 0, type: integer(kind=4), CONST: 33554432
          value: 0x0, mask: 0xfffffffffffffffc
          VR  [1, -1]
        param 4: CONST: &C.4512 -> 1

and later we decide to clone:

+   Estimating body: rfft/1
+   Known to be false: op3[ref offset: 0] <= 0, op3[ref offset: 0] == 1,
op3[ref offset: 0] == 2, op3[ref offset: 0] changed
+   size:602 time:9868.835632 nonspec time:9884.134781 loops with known
iterations:0.470881 known strides:0.000000
+ - estimates for value 33554432 for param #3 npts[ref offset: 0]:
time_benefit: 109.299, size: 602

so the cost metric says that cloning will speed up the function by 0.1%
however good clonning oportunity seems happy:

+ - considering value 33554432 for param #3 npts, offset: 0 (caller_count: 2)
+     good_cloning_opportunity_p (time: 109.299, size: 602, freq_sum: 16.1818)
-> evaluation: 2937.97, threshold: 500

and we clone

+  Creating a specialized node of rfft/1.
+    adding an extra known scalar value &x for param #0 x
+    adding an extra known scalar value &trg for param #1 trg
+    adding an extra known scalar value &ibi for param #2 ibi
+    replacing param #0 x with const &x
+    replacing param #1 trg with const &trg
+    replacing param #2 ibi with const &ibi

  parent reply	other threads:[~2021-11-12 21:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 17:44 [Bug tree-optimization/103195] New: tfft2 text grows by 70% with -Ofast between g:52fa771758635d9c53cddb9116e5a66fae592230...a97fdde627e64202940112009d45d17f85e4cc61 hubicka at gcc dot gnu.org
2021-11-12  7:39 ` [Bug tree-optimization/103195] " rguenth at gcc dot gnu.org
2021-11-12 10:12 ` [Bug tree-optimization/103195] [12 Regression] tfft2 text grows by 70% with -Ofast since r12-5113-gd70ef65692fced7a marxin at gcc dot gnu.org
2021-11-12 10:27 ` hubicka at kam dot mff.cuni.cz
2021-11-12 21:25 ` hubicka at gcc dot gnu.org [this message]
2021-11-16 13:10 ` rguenth at gcc dot gnu.org
2022-01-18 14:29 ` rguenth at gcc dot gnu.org
2022-01-18 14:31   ` Jan Hubicka
2022-01-18 14:31 ` hubicka at kam dot mff.cuni.cz
2022-02-17 22:33 ` jamborm at gcc dot gnu.org
2022-05-06  8:31 ` [Bug tree-optimization/103195] [12/13 " jakub at gcc dot gnu.org
2022-07-26 13:10 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103195-4-pzZsYIsLts@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).