* [Bug bootstrap/103306] parallel build hangs since r12-5234-g04c5a91d068c4ca2f09c2bc206fce00db9d1790b
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
@ 2021-11-17 20:18 ` pinskia at gcc dot gnu.org
2021-11-17 20:22 ` pinskia at gcc dot gnu.org
` (20 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-11-17 20:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I have done a -j16 and -j24 build after this change on x86_64-linux with the
build directory on nfs mounted filesystem and got no hang.
What file system are you using?
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] parallel build hangs since r12-5234-g04c5a91d068c4ca2f09c2bc206fce00db9d1790b
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
2021-11-17 20:18 ` [Bug bootstrap/103306] parallel build hangs since r12-5234-g04c5a91d068c4ca2f09c2bc206fce00db9d1790b pinskia at gcc dot gnu.org
@ 2021-11-17 20:22 ` pinskia at gcc dot gnu.org
2021-11-17 21:14 ` zsojka at seznam dot cz
` (19 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-11-17 20:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Plus this change removes code which was questionable 🤔. And replaces it with
an abort. If the access is failing, then something is really wrong.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] parallel build hangs since r12-5234-g04c5a91d068c4ca2f09c2bc206fce00db9d1790b
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
2021-11-17 20:18 ` [Bug bootstrap/103306] parallel build hangs since r12-5234-g04c5a91d068c4ca2f09c2bc206fce00db9d1790b pinskia at gcc dot gnu.org
2021-11-17 20:22 ` pinskia at gcc dot gnu.org
@ 2021-11-17 21:14 ` zsojka at seznam dot cz
2021-11-17 23:06 ` pinskia at gcc dot gnu.org
` (18 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: zsojka at seznam dot cz @ 2021-11-17 21:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #3 from Zdenek Sojka <zsojka at seznam dot cz> ---
Thank you for having a look at this. I am using btrfs.
I will re-check with ccache disabled if this commit is really the one causing
the issue for me.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] parallel build hangs since r12-5234-g04c5a91d068c4ca2f09c2bc206fce00db9d1790b
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (2 preceding siblings ...)
2021-11-17 21:14 ` zsojka at seznam dot cz
@ 2021-11-17 23:06 ` pinskia at gcc dot gnu.org
2021-11-18 6:36 ` zsojka at seznam dot cz
` (17 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-11-17 23:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2021-11-17
Status|UNCONFIRMED |WAITING
Ever confirmed|0 |1
--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Also what version of make are you using?
Can you provide the full log of where it hangs?
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] parallel build hangs since r12-5234-g04c5a91d068c4ca2f09c2bc206fce00db9d1790b
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (3 preceding siblings ...)
2021-11-17 23:06 ` pinskia at gcc dot gnu.org
@ 2021-11-18 6:36 ` zsojka at seznam dot cz
2021-11-18 7:49 ` zsojka at seznam dot cz
` (16 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: zsojka at seznam dot cz @ 2021-11-18 6:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #5 from Zdenek Sojka <zsojka at seznam dot cz> ---
$ make --version
GNU Make 4.3
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
$ grep -C5 'Cannot access ' gcccompile.log
Applying io_quotes_use to xorg/xorgVersion.h
Applying io_quotes_use to xorg/xf86Module.h
Applying strict_ansi_only to xorg/compiler.h
Fixed: xorg/compiler.h
Quoted includes in xorg/compiler.h
Cannot access CL/cl_ext.h: No such file or directory
Cleaning up unneeded directories:
fixincludes is done
echo timestamp > stmp-fixinc
if [ -d include ] ; then true; else mkdir include; chmod a+rx include; fi
if [ -d include-fixed ] ; then true; else mkdir include-fixed; chmod a+rx
include-fixed; fi
I might be hitting the "Some really strange error happened." situation
Disabling ccache does not help.
Reverting the fixincludes patch on current master (r12-5347) fixes the parallel
build for me.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] parallel build hangs since r12-5234-g04c5a91d068c4ca2f09c2bc206fce00db9d1790b
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (4 preceding siblings ...)
2021-11-18 6:36 ` zsojka at seznam dot cz
@ 2021-11-18 7:49 ` zsojka at seznam dot cz
2021-11-18 7:53 ` rguenth at gcc dot gnu.org
` (15 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: zsojka at seznam dot cz @ 2021-11-18 7:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #6 from Zdenek Sojka <zsojka at seznam dot cz> ---
With 04c5a91d068c4ca2f09c2bc206fce00db9d1790b reverted, the output is:
$ grep -C5 'Cannot access ' gcccompile-REVERT.log
Applying io_quotes_use to xorg/xorgVersion.h
Applying io_quotes_use to xorg/xf86Module.h
Applying strict_ansi_only to xorg/compiler.h
Fixed: xorg/compiler.h
Quoted includes in xorg/compiler.h
Cannot access CL/cl_ext.h from /usr/include
error 2 (No such file or directory)
Cannot access CL/cl_gl_ext.h from /usr/include
error 2 (No such file or directory)
Cannot access CL/cl_gl.h from /usr/include
error 2 (No such file or directory)
Cannot access CL/cl.h from /usr/include
error 2 (No such file or directory)
Cannot access CL/cl_platform.h from /usr/include
error 2 (No such file or directory)
Cannot access CL/opencl.h from /usr/include
error 2 (No such file or directory)
Applying io_quotes_def to SDL2/SDL_version.h
Applying io_quotes_def to libssh/libssh_version.h
Applying io_quotes_use to libssh/libssh_version.h
Applying io_quotes_use to vulkan/vulkan_core.h
Applying io_quotes_def to
libsoup-2.4/libsoup/soup-websocket-connection.h
Cannot access cblas.h from /usr/include
error 2 (No such file or directory)
Applying io_quotes_use to fuse3/fuse_common.h
Applying io_quotes_def to mozjs-78/mozilla/HelperMacros.h
Applying io_quotes_use to brotli/port.h
Applying io_quotes_def to wx-3.0-gtk3/wx/variant.h
eg. we don't give up after the first failure
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] parallel build hangs since r12-5234-g04c5a91d068c4ca2f09c2bc206fce00db9d1790b
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (5 preceding siblings ...)
2021-11-18 7:49 ` zsojka at seznam dot cz
@ 2021-11-18 7:53 ` rguenth at gcc dot gnu.org
2021-11-18 7:57 ` jakub at gcc dot gnu.org
` (14 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-11-18 7:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|1 |0
Status|WAITING |UNCONFIRMED
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] parallel build hangs since r12-5234-g04c5a91d068c4ca2f09c2bc206fce00db9d1790b
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (6 preceding siblings ...)
2021-11-18 7:53 ` rguenth at gcc dot gnu.org
@ 2021-11-18 7:57 ` jakub at gcc dot gnu.org
2021-11-18 8:01 ` pinskia at gcc dot gnu.org
` (13 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-11-18 7:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |xry111 at mengyan1223 dot wang
--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I guess that means the r12-5234 change is incorrect, we don't or shouldn't
require that a user has installed all the headers that have fixincl rules, the
traditional behavior has been that it fixes up those headers that user has
installed and skips the others.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] parallel build hangs since r12-5234-g04c5a91d068c4ca2f09c2bc206fce00db9d1790b
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (7 preceding siblings ...)
2021-11-18 7:57 ` jakub at gcc dot gnu.org
@ 2021-11-18 8:01 ` pinskia at gcc dot gnu.org
2021-11-18 8:03 ` zsojka at seznam dot cz
` (12 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-11-18 8:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Zdenek Sojka from comment #6)
> With 04c5a91d068c4ca2f09c2bc206fce00db9d1790b reverted, the output is:
>
> $ grep -C5 'Cannot access ' gcccompile-REVERT.log
> Applying io_quotes_use to xorg/xorgVersion.h
> Applying io_quotes_use to xorg/xf86Module.h
> Applying strict_ansi_only to xorg/compiler.h
> Fixed: xorg/compiler.h
> Quoted includes in xorg/compiler.h
> Cannot access CL/cl_ext.h from /usr/include
> error 2 (No such file or directory)
> Cannot access CL/cl_gl_ext.h from /usr/include
> error 2 (No such file or directory)
> Cannot access CL/cl_gl.h from /usr/include
> error 2 (No such file or directory)
> Cannot access CL/cl.h from /usr/include
> error 2 (No such file or directory)
> Cannot access CL/cl_platform.h from /usr/include
> error 2 (No such file or directory)
> Cannot access CL/opencl.h from /usr/include
> error 2 (No such file or directory)
can you do:
ls -latR /usr/include/CL ?
Because I think your filesystem is corrupted. There are no references to CL or
cl_ext.h in fixincludes at all.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] parallel build hangs since r12-5234-g04c5a91d068c4ca2f09c2bc206fce00db9d1790b
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (8 preceding siblings ...)
2021-11-18 8:01 ` pinskia at gcc dot gnu.org
@ 2021-11-18 8:03 ` zsojka at seznam dot cz
2021-11-18 8:07 ` pinskia at gcc dot gnu.org
` (11 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: zsojka at seznam dot cz @ 2021-11-18 8:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #9 from Zdenek Sojka <zsojka at seznam dot cz> ---
(In reply to Andrew Pinski from comment #8)
> (In reply to Zdenek Sojka from comment #6)
> > With 04c5a91d068c4ca2f09c2bc206fce00db9d1790b reverted, the output is:
> >
> > $ grep -C5 'Cannot access ' gcccompile-REVERT.log
> > Applying io_quotes_use to xorg/xorgVersion.h
> > Applying io_quotes_use to xorg/xf86Module.h
> > Applying strict_ansi_only to xorg/compiler.h
> > Fixed: xorg/compiler.h
> > Quoted includes in xorg/compiler.h
> > Cannot access CL/cl_ext.h from /usr/include
> > error 2 (No such file or directory)
> > Cannot access CL/cl_gl_ext.h from /usr/include
> > error 2 (No such file or directory)
> > Cannot access CL/cl_gl.h from /usr/include
> > error 2 (No such file or directory)
> > Cannot access CL/cl.h from /usr/include
> > error 2 (No such file or directory)
> > Cannot access CL/cl_platform.h from /usr/include
> > error 2 (No such file or directory)
> > Cannot access CL/opencl.h from /usr/include
> > error 2 (No such file or directory)
>
> can you do:
> ls -latR /usr/include/CL ?
>
> Because I think your filesystem is corrupted. There are no references to CL
> or cl_ext.h in fixincludes at all.
$ ls -latR /usr/include/CL
/usr/include/CL:
total 28
drwxr-xr-x 1 root root 15388 Nov 17 08:32 ..
drwxr-xr-x 1 root root 114 Jan 23 2017 .
lrwxrwxrwx 1 root root 43 Jan 23 2017 cl.hpp ->
../../lib64/OpenCL/global/include/CL/cl.hpp
lrwxrwxrwx 1 root root 41 Jan 23 2017 cl.h ->
../../lib64/OpenCL/global/include/CL/cl.h
lrwxrwxrwx 1 root root 50 Jan 23 2017 cl_platform.h ->
../../lib64/OpenCL/global/include/CL/cl_platform.h
lrwxrwxrwx 1 root root 45 Jan 23 2017 opencl.h ->
../../lib64/OpenCL/global/include/CL/opencl.h
lrwxrwxrwx 1 root root 45 Jan 23 2017 cl_ext.h ->
../../lib64/OpenCL/global/include/CL/cl_ext.h
lrwxrwxrwx 1 root root 48 Jan 23 2017 cl_gl_ext.h ->
../../lib64/OpenCL/global/include/CL/cl_gl_ext.h
lrwxrwxrwx 1 root root 44 Jan 23 2017 cl_gl.h ->
../../lib64/OpenCL/global/include/CL/cl_gl.h
thank you for pointing that out; these are broken symlinks (maybe there was a
package providing these, which was removed later)
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] parallel build hangs since r12-5234-g04c5a91d068c4ca2f09c2bc206fce00db9d1790b
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (9 preceding siblings ...)
2021-11-18 8:03 ` zsojka at seznam dot cz
@ 2021-11-18 8:07 ` pinskia at gcc dot gnu.org
2021-11-18 8:07 ` [Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links pinskia at gcc dot gnu.org
` (10 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-11-18 8:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The question comes should we abort on broken /usr/include directories entry or
just continue.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (10 preceding siblings ...)
2021-11-18 8:07 ` pinskia at gcc dot gnu.org
@ 2021-11-18 8:07 ` pinskia at gcc dot gnu.org
2021-11-18 8:10 ` zsojka at seznam dot cz
` (9 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-11-18 8:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|parallel build hangs since |[12 Regression] parallel
|r12-5234-g04c5a91d068c4ca2f |build hangs since
|09c2bc206fce00db9d1790b |r12-5234-g04c5a9 when
| |/usr/include includes
| |broken symbolic links
Target Milestone|--- |12.0
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (11 preceding siblings ...)
2021-11-18 8:07 ` [Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links pinskia at gcc dot gnu.org
@ 2021-11-18 8:10 ` zsojka at seznam dot cz
2021-11-18 10:22 ` xry111 at mengyan1223 dot wang
` (8 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: zsojka at seznam dot cz @ 2021-11-18 8:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #11 from Zdenek Sojka <zsojka at seznam dot cz> ---
I can observe broken header symlinks on other long-standing Gentoo systems. I
don't know what's the situation like for other distros.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (12 preceding siblings ...)
2021-11-18 8:10 ` zsojka at seznam dot cz
@ 2021-11-18 10:22 ` xry111 at mengyan1223 dot wang
2021-11-18 10:23 ` zsojka at seznam dot cz
` (7 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: xry111 at mengyan1223 dot wang @ 2021-11-18 10:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #12 from Xi Ruoyao <xry111 at mengyan1223 dot wang> ---
I'll make a workaround in maybe an hour...
But why should a distro ship broken symlinks?
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (13 preceding siblings ...)
2021-11-18 10:22 ` xry111 at mengyan1223 dot wang
@ 2021-11-18 10:23 ` zsojka at seznam dot cz
2021-11-18 10:39 ` jakub at gcc dot gnu.org
` (6 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: zsojka at seznam dot cz @ 2021-11-18 10:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #13 from Zdenek Sojka <zsojka at seznam dot cz> ---
(In reply to Xi Ruoyao from comment #12)
> I'll make a workaround in maybe an hour...
>
> But why should a distro ship broken symlinks?
It broke during on of the updates, probably around 2017.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (14 preceding siblings ...)
2021-11-18 10:23 ` zsojka at seznam dot cz
@ 2021-11-18 10:39 ` jakub at gcc dot gnu.org
2021-11-18 11:02 ` xry111 at mengyan1223 dot wang
` (5 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-11-18 10:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
No matter what, IMO assertions or aborts should be for bugs in the tool
(fixincl in this case), something that shouldn't happen if the tool doesn't
have bugs, while errors or possibly ignored errors should be for the case where
the bug is outside of the tool like in this case. And, for a tool like
fixincl, the big question is if it should be a fatal error or just warning or
non-fatal error, something the tool can survive and continue with next header.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (15 preceding siblings ...)
2021-11-18 10:39 ` jakub at gcc dot gnu.org
@ 2021-11-18 11:02 ` xry111 at mengyan1223 dot wang
2021-11-19 4:56 ` zsojka at seznam dot cz
` (4 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: xry111 at mengyan1223 dot wang @ 2021-11-18 11:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #15 from Xi Ruoyao <xry111 at mengyan1223 dot wang> ---
patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/584815.html
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (16 preceding siblings ...)
2021-11-18 11:02 ` xry111 at mengyan1223 dot wang
@ 2021-11-19 4:56 ` zsojka at seznam dot cz
2021-11-20 13:18 ` xry111 at mengyan1223 dot wang
` (3 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: zsojka at seznam dot cz @ 2021-11-19 4:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #16 from Zdenek Sojka <zsojka at seznam dot cz> ---
(In reply to Xi Ruoyao from comment #15)
> patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/584815.html
Thank you for the patch; it fixes non-bootstrap build for me. I didn't check
full bootstrap yet.
Is there a chance to check why is there the strange behavior now, with the
abort() in fixincludes?
- parallel build hangs (eg. no "Error" or "Waiting for unfinished jobs" message
from make)
- non-parallel build succeeds (even though fixincludes aborted)
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (17 preceding siblings ...)
2021-11-19 4:56 ` zsojka at seznam dot cz
@ 2021-11-20 13:18 ` xry111 at mengyan1223 dot wang
2021-11-23 19:20 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: xry111 at mengyan1223 dot wang @ 2021-11-20 13:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
Xi Ruoyao <xry111 at mengyan1223 dot wang> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bkorb at gnu dot org
--- Comment #17 from Xi Ruoyao <xry111 at mengyan1223 dot wang> ---
(In reply to Zdenek Sojka from comment #16)
> (In reply to Xi Ruoyao from comment #15)
> > patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/584815.html
>
> Thank you for the patch; it fixes non-bootstrap build for me. I didn't check
> full bootstrap yet.
>
> Is there a chance to check why is there the strange behavior now, with the
> abort() in fixincludes?
> - parallel build hangs (eg. no "Error" or "Waiting for unfinished jobs"
> message from make)
> - non-parallel build succeeds (even though fixincludes aborted)
I think the reason is when fixinc.sh invokes fixincl executable, it does not
check if fixincl succeeds. Then if fixincl fails, it may leave the building
into a inconsistent status.
On my system the parallel build fails with "cannot find config.status".
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (18 preceding siblings ...)
2021-11-20 13:18 ` xry111 at mengyan1223 dot wang
@ 2021-11-23 19:20 ` cvs-commit at gcc dot gnu.org
2021-11-23 19:21 ` xry111 at mengyan1223 dot wang
2021-11-28 1:27 ` pinskia at gcc dot gnu.org
21 siblings, 0 replies; 23+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-23 19:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #18 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Xi Ruoyao <xry111@gcc.gnu.org>:
https://gcc.gnu.org/g:3363022ed810a2797c47867890547c8f73163257
commit r12-5477-g3363022ed810a2797c47867890547c8f73163257
Author: Xi Ruoyao <xry111@mengyan1223.wang>
Date: Thu Nov 18 18:46:12 2021 +0800
fixincludes: don't abort() on access failure [PR103306]
Some distro may ship dangling symlinks in include directories, triggers
the access failure. Skip it and continue to next header instead of
being to panic.
Restore to old behavior before r12-5234 but without resurrecting the
problematic getcwd() call, by using the environment variable "INPUT"
exported by fixinc.sh.
Tested on x86_64-linux-gnu, with a dangling symlink intentionally
injected into /usr/include.
fixincludes/
PR bootstrap/103306
* fixincl.c (process): Don't call abort().
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (19 preceding siblings ...)
2021-11-23 19:20 ` cvs-commit at gcc dot gnu.org
@ 2021-11-23 19:21 ` xry111 at mengyan1223 dot wang
2021-11-28 1:27 ` pinskia at gcc dot gnu.org
21 siblings, 0 replies; 23+ messages in thread
From: xry111 at mengyan1223 dot wang @ 2021-11-23 19:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
--- Comment #19 from Xi Ruoyao <xry111 at mengyan1223 dot wang> ---
Fixed on trunk.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
2021-11-17 19:14 [Bug bootstrap/103306] New: parallel build hangs since 04c5a91d068c4ca2f09c2bc206fce00db9d1790b zsojka at seznam dot cz
` (20 preceding siblings ...)
2021-11-23 19:21 ` xry111 at mengyan1223 dot wang
@ 2021-11-28 1:27 ` pinskia at gcc dot gnu.org
21 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-11-28 1:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #20 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed so closing.
^ permalink raw reply [flat|nested] 23+ messages in thread