[Bug target/103307] New: Unused "%!" before return

[Bug target/103307] New: Unused "%!" before return

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103307

            Bug ID: 103307
           Summary: Unused "%!" before return
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hjl.tools at gmail dot com
                CC: ubizjak at gmail dot com
  Target Milestone: ---
            Target: i386, x86-64

x86 backend has

i386.c:      output_asm_insn ("%!ret", NULL);
i386.c:    return "%!ret";
i386.md:  "%!ret\t%0"

Before MPX was removed, "%!" was mapped to

        case '!':
          if (ix86_bnd_prefixed_insn_p (current_output_insn))
            fputs ("bnd ", file);
          return;

After CET was added and MPX was removed, "%!" was mapped to

       case '!':
          if (ix86_notrack_prefixed_insn_p (current_output_insn))
            fputs ("notrack ", file);
          return;

ix86_notrack_prefixed_insn_p always returns false on RET since the
notrack prefix is only for indirect branches.  Therefore, "%!" before
RET is unused.

[Bug target/103307] Unused "%!" before return

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103307

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:8e410de43ce039bbe08f1e0195e3b6ec24f68cae

commit r12-5352-g8e410de43ce039bbe08f1e0195e3b6ec24f68cae
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Nov 17 11:41:12 2021 -0800

    x86: Remove "%!" before ret

    Before MPX was removed, "%!" was mapped to

            case '!':
              if (ix86_bnd_prefixed_insn_p (current_output_insn))
                fputs ("bnd ", file);
              return;

    After CET was added and MPX was removed, "%!" was mapped to

           case '!':
              if (ix86_notrack_prefixed_insn_p (current_output_insn))
                fputs ("notrack ", file);
              return;

    ix86_notrack_prefixed_insn_p always returns false on ret since the
    notrack prefix is only for indirect branches.  Remove the unused "%!"
    before ret.

            PR target/103307
            * config/i386/i386.c (ix86_code_end): Remove "%!" before ret.
            (ix86_output_function_return): Likewise.
            * config/i386/i386.md (simple_return_pop_internal): Likewise.

[Bug target/103307] Unused "%!" before return

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103307

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug target/103307] Unused "%!" before return

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103307

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:c604b03126722b419073a97e97ed844677058714

commit r11-9574-gc604b03126722b419073a97e97ed844677058714
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Nov 17 11:41:12 2021 -0800

    x86: Remove "%!" before ret

    Before MPX was removed, "%!" was mapped to

            case '!':
              if (ix86_bnd_prefixed_insn_p (current_output_insn))
                fputs ("bnd ", file);
              return;

    After CET was added and MPX was removed, "%!" was mapped to

           case '!':
              if (ix86_notrack_prefixed_insn_p (current_output_insn))
                fputs ("notrack ", file);
              return;

    ix86_notrack_prefixed_insn_p always returns false on ret since the
    notrack prefix is only for indirect branches.  Remove the unused "%!"
    before ret.

            PR target/103307
            * config/i386/i386.c (ix86_code_end): Remove "%!" before ret.
            (ix86_output_function_return): Likewise.
            * config/i386/i386.md (simple_return_pop_internal): Likewise.

    (cherry picked from commit 8e410de43ce039bbe08f1e0195e3b6ec24f68cae)