[Bug target/103330] New: [12 Regression] FAIL: gcc.target/i386/avx512fp16-vector-complex-float.c by r12-5378

[Bug target/103330] New: [12 Regression] FAIL: gcc.target/i386/avx512fp16-vector-complex-float.c by r12-5378

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103330

            Bug ID: 103330
           Summary: [12 Regression] FAIL:
                    gcc.target/i386/avx512fp16-vector-complex-float.c by
                    r12-5378
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hjl.tools at gmail dot com
                CC: crazylht at gmail dot com, tamar.christina at arm dot com
  Target Milestone: ---

On Linux/x86, r12-5378 caused:

FAIL: gcc.target/i386/avx512fp16-vector-complex-float.c scan-assembler-not
vfmadd[123]*ph[ \\t]
FAIL: gcc.target/i386/avx512fp16-vector-complex-float.c scan-assembler-times
vfcmaddcph[ \\t] 1
FAIL: gcc.target/i386/avx512fp16-vector-complex-float.c scan-assembler-times
vfmaddcph[ \\t] 1

[Bug target/103330] [12 Regression] FAIL: gcc.target/i386/avx512fp16-vector-complex-float.c by r12-5378

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103330

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-11-19
     Ever confirmed|0                           |1
   Target Milestone|---                         |12.0
             Status|UNCONFIRMED                 |NEW

[Bug target/103330] [12 Regression] FAIL: gcc.target/i386/avx512fp16-vector-complex-float.c by r12-5378

[tnfchris at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103330

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tnfchris at gcc dot gnu.org

--- Comment #1 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Already posted a patch to ML to fix it. Will commit when I get back to a
computer.

[Bug target/103330] [12 Regression] FAIL: gcc.target/i386/avx512fp16-vector-complex-float.c by r12-5378

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103330

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:

https://gcc.gnu.org/g:487d604b6fa0f0a981eadc216d9e481d08ed7e7b

commit r12-5407-g487d604b6fa0f0a981eadc216d9e481d08ed7e7b
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Fri Nov 19 15:12:38 2021 +0000

    middle-end: Handle FMA_CONJ correctly after SLP layout update.

    Apologies, I got dinged by the i386 regressions bot for a test I didn't
have in
    my tree at the time I made the previous patch.  The bot was telling me that
FMA
    stopped working after I strengthened the FMA check in the previous patch.

    The reason is that the check is slightly early.  The first check can indeed
only
    exit early when either node isn't a mult.  However we need to delay till we
know
    if the node is a MUL or FMA before enforcing that both nodes must be a MULT
    since the node to inspect is different if the operation is a MUL or FMA.

    Also with the update patch for GCC 11 tree layout update to the new GCC 12
one
    I had missed that the difference in which node is conjucated is not
symmetrical.

    So the test for it can just be testing the inverse order.  It was Currently
    no detecting when the first node was conjucated instead of the second one.

    This also made me wonder why my own test didn't detect this.  It turns out
that
    the tests, being copied from the _Float16 ones were incorrectly marked as
    xfail.  The _Float16 ones are marked as xfail since C doesn't have a conj
    operation for _Float16, which means you get extra type-casts in between.

    While you could use the GCC _Complex extension here I opted to mark them
xfail
    since I wanted to include detection over the widenings next year.

    Secondly the double tests were being skipped because Adv. SIMD was missing
from
    targets supporting Complex Double vectorization.

    With these changes all other tests run and pass and only XFAIL ones are
    correctly the _Float16 ones.  Sorry for missing this before, testing should
now
    cover all cases.

    gcc/ChangeLog:

            PR tree-optimization/103311
            PR target/103330
            * tree-vect-slp-patterns.c (vect_validate_multiplication): Fix CONJ
            test to new codegen.
            (complex_mul_pattern::matches): Move check downwards.

    gcc/testsuite/ChangeLog:

            PR tree-optimization/103311
            PR target/103330
            * gcc.dg/vect/complex/fast-math-bb-slp-complex-mla-double.c: Fix
it.
            * gcc.dg/vect/complex/fast-math-bb-slp-complex-mla-float.c:
Likewise.
            * gcc.dg/vect/complex/fast-math-bb-slp-complex-mls-double.c:
Likewise.
            * gcc.dg/vect/complex/fast-math-bb-slp-complex-mls-float.c:
Likewise.
            * gcc.dg/vect/complex/fast-math-bb-slp-complex-mul-double.c:
Likewise.
            * gcc.dg/vect/complex/fast-math-bb-slp-complex-mul-float.c:
Likewise.
            * lib/target-supports.exp
            (check_effective_target_vect_complex_add_double): Add Adv. SIMD.

[Bug target/103330] [12 Regression] FAIL: gcc.target/i386/avx512fp16-vector-complex-float.c by r12-5378

[tnfchris at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103330

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Fixed