public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/103384] [OpenMP] declare variant with device={kind(nohost)} does not use GPU, kind(gpu) works Date: Tue, 23 Nov 2021 14:59:45 +0000 [thread overview] Message-ID: <bug-103384-4-Am02Y0Cnb2@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-103384-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103384 --- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Would --- gcc/omp-general.c.jj 2021-10-15 11:59:16.135683948 +0200 +++ gcc/omp-general.c 2021-11-23 15:45:32.761468592 +0100 @@ -1487,16 +1487,22 @@ omp_context_selector_matches (tree ctx) continue; if (!strcmp (prop, "host")) { +#ifdef ACCEL_COMPILER + return 0; +#else if (omp_maybe_offloaded ()) ret = -1; continue; +#endif } if (!strcmp (prop, "nohost")) { +#ifndef ACCEL_COMPILER if (omp_maybe_offloaded ()) ret = -1; else return 0; +#endif continue; } int r = 0; fix this? In ACCEL_COMPILER we know that it is nohost, so for host we should return 0 even if we earlier on the host side said it might be offloaded and so defer, and for host we know it is ok. I don't really like the test, in the SOLLVE test it just relies on no host fallback without ensuring it, in your attached test omp_get_num_devices () doesn't guarantee no host fallback either. Check omp_is_initial_device () in the target region instead?
next prev parent reply other threads:[~2021-11-23 14:59 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-23 14:27 [Bug middle-end/103384] New: " burnus at gcc dot gnu.org 2021-11-23 14:59 ` jakub at gcc dot gnu.org [this message] 2021-11-24 9:35 ` [Bug middle-end/103384] " cvs-commit at gcc dot gnu.org 2021-11-24 10:00 ` jakub at gcc dot gnu.org 2021-11-29 8:50 ` cvs-commit at gcc dot gnu.org 2022-05-10 8:22 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-103384-4-Am02Y0Cnb2@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).