public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/103384] [OpenMP] declare variant with device={kind(nohost)} does not use GPU, kind(gpu) works
Date: Tue, 10 May 2022 08:22:04 +0000	[thread overview]
Message-ID: <bug-103384-4-zMsMbRMPs8@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103384-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103384

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:279e48e9d8e8d99a73d5ca69f829b83638419c56

commit r10-10658-g279e48e9d8e8d99a73d5ca69f829b83638419c56
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Nov 24 10:30:32 2021 +0100

    openmp: Fix up handling of kind(host) and kind(nohost) in ACCEL_COMPILERs
[PR103384]

    As the testcase shows, we weren't handling kind(host) and kind(nohost)
properly
    in the ACCEL_COMPILERs, the code written in there is valid for the host
    compiler only, where if we are maybe offloaded, we defer resolution after
IPA,
    otherwise return 0 for kind(nohost) and accept it for kind(host).  Note,
    omp_maybe_offloaded is false after IPA.  If ACCEL_COMPILER is defined, it
is
    the other way around, but also we know we are after IPA.

    2021-11-24  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/103384
    gcc/
            * omp-general.c (omp_context_selector_matches): For ACCEL_COMPILER,
            return 0 for kind(host) and continue for kind(nohost).
    libgomp/
            * testsuite/libgomp.c/declare-variant-2.c: New test.

    (cherry picked from commit 5bca26742cf3357bf4e20ec97eee4c7f7de17ce0)

      parent reply	other threads:[~2022-05-10  8:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 14:27 [Bug middle-end/103384] New: " burnus at gcc dot gnu.org
2021-11-23 14:59 ` [Bug middle-end/103384] " jakub at gcc dot gnu.org
2021-11-24  9:35 ` cvs-commit at gcc dot gnu.org
2021-11-24 10:00 ` jakub at gcc dot gnu.org
2021-11-29  8:50 ` cvs-commit at gcc dot gnu.org
2022-05-10  8:22 ` cvs-commit at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103384-4-zMsMbRMPs8@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).