[Bug fortran/103473] New: [11/12 Regression] ICE in simplify_minmaxloc_nodim, at fortran/simplify.c:5287

[Bug fortran/103473] New: [11/12 Regression] ICE in simplify_minmaxloc_nodim, at fortran/simplify.c:5287

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103473

            Bug ID: 103473
           Summary: [11/12 Regression] ICE in simplify_minmaxloc_nodim, at
                    fortran/simplify.c:5287
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

There seems to be a difference between minloc/maxloc and other intrinsics.
This started recently between 20211031 and 20211107 :
(gcc configured with --enable-checking=yes)


$ cat z1.f90
subroutine s
   integer, parameter :: a(+'1') = [1]
   print *, minloc(a)
   print *, maxloc(a)
end


$ gfortran-12-20211128 -c z1.f90
z1.f90:2:27:

    2 |    integer, parameter :: a(+'1') = [1]
      |                           1
Error: Operand of unary numeric operator '+' at (1) is UNKNOWN
z1.f90:2:32:

    2 |    integer, parameter :: a(+'1') = [1]
      |                                1
Error: Parameter array 'a' at (1) cannot be automatic or of deferred shape
f951: internal compiler error: Segmentation fault
0xf0942f crash_signal
        ../../gcc/toplev.c:322
0x8650d0 simplify_minmaxloc_nodim
        ../../gcc/fortran/simplify.c:5287
0x86ed27 gfc_simplify_minmaxloc
        ../../gcc/fortran/simplify.c:5584
0x7ee3d2 do_simplify
        ../../gcc/fortran/intrinsic.c:4669
0x7f94aa gfc_intrinsic_func_interface(gfc_expr*, int)
        ../../gcc/fortran/intrinsic.c:5034
0x84d41c resolve_unknown_f
        ../../gcc/fortran/resolve.c:2972
0x84d41c resolve_function
        ../../gcc/fortran/resolve.c:3329
0x84d41c gfc_resolve_expr(gfc_expr*)
        ../../gcc/fortran/resolve.c:7166
0x853944 gfc_resolve_expr(gfc_expr*)
        ../../gcc/fortran/resolve.c:7133
0x853944 gfc_resolve_code(gfc_code*, gfc_namespace*)
        ../../gcc/fortran/resolve.c:11928
0x85228f gfc_resolve_blocks(gfc_code*, gfc_namespace*)
        ../../gcc/fortran/resolve.c:10944
0x852658 gfc_resolve_code(gfc_code*, gfc_namespace*)
        ../../gcc/fortran/resolve.c:11918
0x854f97 resolve_codes
        ../../gcc/fortran/resolve.c:17536
0x85505e gfc_resolve(gfc_namespace*)
        ../../gcc/fortran/resolve.c:17571
0x83d314 resolve_all_program_units
        ../../gcc/fortran/parse.c:6573
0x83d314 gfc_parse_file()
        ../../gcc/fortran/parse.c:6829
0x88b37f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:216

[Bug fortran/103473] [11/12 Regression] ICE in simplify_minmaxloc_nodim, at fortran/simplify.c:5287

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103473

G. Steinmetz <gscfq@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code

--- Comment #1 from G. Steinmetz <gscfq@t-online.de> ---

No ICE :

$ cat z2.f90
subroutine s
   integer, parameter :: a(+'1') = 1
   print *, minloc(a)
   print *, maxloc(a)
end

$ cat z3.f90
subroutine s
   integer, parameter :: a(+'1') = [1]
   print *, rank(a)
   print *, sum(a)
end

[Bug fortran/103473] [11/12 Regression] ICE in simplify_minmaxloc_nodim, at fortran/simplify.c:5287

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103473

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-11-29
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #2 from anlauf at gcc dot gnu.org ---
Untested patch:

diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c
index c9e13b59da9..fb7b7814603 100644
--- a/gcc/fortran/simplify.c
+++ b/gcc/fortran/simplify.c
@@ -5280,6 +5280,9 @@ simplify_minmaxloc_nodim (gfc_expr *result, gfc_expr
*extremum,
       && !mask->value.logical)
     goto finish;

+  if (array->shape == NULL)
+    goto finish;
+
   for (i = 0; i < array->rank; i++)
     {
       count[i] = 0;

[Bug fortran/103473] [11/12 Regression] ICE in simplify_minmaxloc_nodim, at fortran/simplify.c:5287

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103473

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

--- Comment #3 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2021-November/057080.html

[Bug fortran/103473] [11/12 Regression] ICE in simplify_minmaxloc_nodim, at fortran/simplify.c:5287

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103473

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.3
           Priority|P3                          |P4

[Bug fortran/103473] [11/12 Regression] ICE in simplify_minmaxloc_nodim, at fortran/simplify.c:5287

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103473

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-4967-gbcf3728abe848888.

[Bug fortran/103473] [11/12 Regression] ICE in simplify_minmaxloc_nodim, at fortran/simplify.c:5287

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103473

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-4967-gbcf3728abe848888.

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-4967-gbcf3728abe848888.

[Bug fortran/103473] [11/12 Regression] ICE in simplify_minmaxloc_nodim, at fortran/simplify.c:5287

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103473

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:36421e76a7150621f2a5c7060ddd3f80aa825a40

commit r12-5635-g36421e76a7150621f2a5c7060ddd3f80aa825a40
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Nov 29 22:56:30 2021 +0100

    Fortran: error recovery when simplifying MINLOC/MAXLOC

    gcc/fortran/ChangeLog:

            PR fortran/103473
            * simplify.c (simplify_minmaxloc_nodim): Avoid NULL pointer
            dereference when shape is not set.

    gcc/testsuite/ChangeLog:

            PR fortran/103473
            * gfortran.dg/minmaxloc_15.f90: New test.

[Bug fortran/103473] [11/12 Regression] ICE in simplify_minmaxloc_nodim, at fortran/simplify.c:5287

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103473

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:3c1bcaa6224f79c6532dca28ebc7b466acbbc468

commit r11-9356-g3c1bcaa6224f79c6532dca28ebc7b466acbbc468
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Nov 29 22:56:30 2021 +0100

    Fortran: error recovery when simplifying MINLOC/MAXLOC

    gcc/fortran/ChangeLog:

            PR fortran/103473
            * simplify.c (simplify_minmaxloc_nodim): Avoid NULL pointer
            dereference when shape is not set.

    gcc/testsuite/ChangeLog:

            PR fortran/103473
            * gfortran.dg/minmaxloc_15.f90: New test.

    (cherry picked from commit 36421e76a7150621f2a5c7060ddd3f80aa825a40)

[Bug fortran/103473] [11/12 Regression] ICE in simplify_minmaxloc_nodim, at fortran/simplify.c:5287

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103473

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from anlauf at gcc dot gnu.org ---
Fixed on mainline and 11-branch.  Closing.

Thanks for the report!