[Bug c++/103499] New: C++20 modules error: invalid use of non-static member function

[Bug c++/103499] New: C++20 modules error: invalid use of non-static member function

[oleg at smolsky dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103499

            Bug ID: 103499
           Summary: C++20 modules error: invalid use of non-static member
                    function
           Product: gcc
           Version: 11.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: oleg at smolsky dot net
  Target Milestone: ---

There seems to be a bug when exporting a class hierarchy from a module. Here is
the GCC11 output:

/opt/gcc-11/bin/g++ -std=c++20 -fmodules-ts -c -o main.o main.cpp
main.cpp: In function ‘int main()’:
main.cpp:6:12: error: invalid use of non-static member function ‘virtual
Derived@task::~Derived()’
    6 |     delete p;

$ cat task.cpp
export module task;

#include "b.h"
#include "d.h"

$ cat b.h
#pragma once

export struct Base {
  virtual ~Base() = default;

  void DoStuff();
};

$ cat d.h
#include "b.h"

export struct Derived : Base {
  ~Derived();
};

$ cat main.cpp
import task;

int main() {
    auto p = new Derived;
    p->DoStuff();
    delete p;
}

[Bug c++/103499] C++20 modules error: invalid use of non-static member function

[markmigm at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103499

Mark Millard <markmigm at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |markmigm at gmail dot com

--- Comment #1 from Mark Millard <markmigm at gmail dot com> ---
I see this in G++ 12.2.0 on FreeBSD. Reduced to a small example below.
Compiled via:

// g++12 -std=c++20 -fmodules-ts -xc++-system-header type_traits
// g++12 -std=c++20 -fmodules-ts -xc++ -c gpp12_module_iostream_failure.cppm
// g++12 -freport-bug -std=c++20 -fmodules-ts -c
gpp12_module_iostream_failure.cpp

# more gpp12_module_is_nothrow_constructible_v_failure.cppm
export module derived_interface;

export struct base
{
        virtual ~base() noexcept = default;
};

export struct derived : base
{
};

# more /tmp/ccrTCTqv.out
// Target: aarch64-portbld-freebsd14.0
// Configured with: /wrkdirs/usr/ports/lang/gcc12/work/gcc-12.2.0/configure
--disable-multilib --disable-bootstrap --disable-nls
--enable-gnu-indirect-function --enable-host-shared --enable-plugin
--libdir=/usr/local/lib/gcc12 --libexecdir=/usr/local/libexec/gcc12
--program-suffix=12 --with-as=/usr/local/bin/as --with-gmp=/usr/local
--with-gxx-include-dir=/usr/local/lib/gcc12/include/c++/
--with-gxx-libcxx-include-dir=/usr/include/c++/v1 --with-ld=/usr/local/bin/ld
--with-pkgversion='FreeBSD Ports Collection' --with-system-zlib --without-zstd
--enable-languages=c,c++,objc,fortran,jit --prefix=/usr/local
--localstatedir=/var --mandir=/usr/local/man
--infodir=/usr/local/share/info/gcc12 --build=aarch64-portbld-freebsd14.0
// Thread model: posix
// Supported LTO compression algorithms: zlib
// gcc version 12.2.0 (FreeBSD Ports Collection) 
// 
// In module /usr/local/lib/gcc12/include/c++/type_traits, imported at
gpp12_module_is_nothrow_constructible_v_failure.cpp:7:
// /usr/local/lib/gcc12/include/c++/type_traits: In substitution of
'template<class _Tp, class ... _Args> using __is_nothrow_constructible_impl =
std::__bool_constant<__is_nothrow_constructible(_Tp)> [with _Tp =
derived@derived_interface; _Args = {}]':
// /usr/local/lib/gcc12/include/c++/type_traits:1047:12:   required from
'struct std::is_nothrow_constructible<derived@derived_interface>'
// /usr/local/lib/gcc12/include/c++/type_traits:3243:46:   required from
'constexpr const bool
std::is_nothrow_constructible_v<derived@derived_interface>'
// gpp12_module_is_nothrow_constructible_v_failure.cpp:11:11:   required from
here
// /usr/local/lib/gcc12/include/c++/type_traits:1041:11: error: invalid use of
non-static member function 'virtual constexpr
derived@derived_interface::~derived()'
//  1041 |     using __is_nothrow_constructible_impl
//       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
// In module derived_interface, imported at
gpp12_module_is_nothrow_constructible_v_failure.cpp:5:
// gpp12_module_is_nothrow_constructible_v_failure.cppm:10:15: note: declared
here
//    10 | export struct derived : base
//       |               ^~~~~~~
// /usr/local/lib/gcc12/include/c++/type_traits:1041: confused by earlier
errors, bailing out

// /usr/local/libexec/gcc12/gcc/aarch64-portbld-freebsd14.0/12.2.0/cc1plus
-quiet gpp12_module_is_nothrow_constructible_v_failure.cpp -quiet -dumpbase
gpp12_module_is_nothrow_constructible_v_failure.cpp -dumpbase-ext .cpp
-mlittle-endian -mabi=lp64 -std=c++20 -freport-bug -fmodules-ts -o -
-frandom-seed=0 -fdump-noaddr

# 0 "gpp12_module_is_nothrow_constructible_v_failure.cpp"
# 0 "<built-in>"
# 0 "<command-line>"
# 1 "gpp12_module_is_nothrow_constructible_v_failure.cpp"




import  derived_interface;

import  "/usr/local/lib/gcc12/include/c++/type_traits";

void test()
{
 if (std::is_nothrow_constructible_v<derived>);
}

[Bug c++/103499] C++20 modules error: invalid use of non-static member function

[markmigm at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103499

--- Comment #2 from Mark Millard <markmigm at gmail dot com> ---
(In reply to Mark Millard from comment #1)
> // g++12 -std=c++20 -fmodules-ts -xc++ -c gpp12_module_iostream_failure.cppm
> // g++12 -freport-bug -std=c++20 -fmodules-ts -c
> gpp12_module_iostream_failure.cpp

The iostream based file names were from before I reduced
the test to the smaller test case. The updated comments are:

// g++12 -std=c++20 -fmodules-ts -xc++ -c
gpp12_module_is_nothrow_constructible_v_failure.cppm
// g++12 -std=c++20 -fmodules-ts -xc++ -c
gpp12_module_is_nothrow_constructible_v_failure.cpp

On Fedora 26, where "c++" is g++ 12.2.1, I've tried the same,
with the copies of the source code, and it gets the same error.
The -freport-bug outout is shown below.

# more /tmp/ccRnanx8.out
// Target: aarch64-redhat-linux
// Configured with: ../configure --enable-bootstrap
--enable-languages=c,c++,fortran,objc,obj-c++,ada,go,lto --prefix=/usr
--mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzil
la.redhat.com/bugzilla --enable-shared --enable-threads=posix
--enable-checking=release --enable-multilib --with-system-zlib
--enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-ob
ject --enable-linker-build-id --with-gcc-major-version-only
--enable-libstdcxx-backtrace --with-linker-hash-style=gnu --enable-plugin
--enable-initfini-array --with-isl=/builddir/build/BUILD/gcc-12.2.
1-20220819/obj-aarch64-redhat-linux/isl-install --enable-gnu-indirect-function
--build=aarch64-redhat-linux --with-build-config=bootstrap-lto
--enable-link-serialization=1
// Thread model: posix
// Supported LTO compression algorithms: zlib zstd
// gcc version 12.2.1 20220819 (Red Hat 12.2.1-1) (GCC) 
// 
// In module /usr/include/c++/12/type_traits, imported at
gpp12_module_is_nothrow_constructible_v_failure.cpp:7:
// /usr/include/c++/12/type_traits: In substitution of ‘template<class _Tp,
class ... _Args> using __is_nothrow_constructible_impl =
std::__bool_constant<__is_nothrow_constructible(_Tp)> [with _Tp = d
erived@derived_interface; _Args = {}]’:
// /usr/include/c++/12/type_traits:1047:12:   required from ‘struct
std::is_nothrow_constructible<derived@derived_interface>’
// /usr/include/c++/12/type_traits:3243:46:   required from ‘constexpr const
bool std::is_nothrow_constructible_v<derived@derived_interface>’
// gpp12_module_is_nothrow_constructible_v_failure.cpp:11:11:   required from
here
// /usr/include/c++/12/type_traits:1041:11: error: invalid use of non-static
member function ‘virtual constexpr derived@derived_interface::~derived()’
//  1041 |     using __is_nothrow_constructible_impl
//       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
// In module derived_interface, imported at
gpp12_module_is_nothrow_constructible_v_failure.cpp:5:
// gpp12_module_is_nothrow_constructible_v_failure.cppm:10:15: note: declared
here
//    10 | export struct derived : base
//       |               ^~~~~~~
// /usr/include/c++/12/type_traits:1041: confused by earlier errors, bailing
out

// /usr/libexec/gcc/aarch64-redhat-linux/12/cc1plus -quiet -D_GNU_SOURCE
gpp12_module_is_nothrow_constructible_v_failure.cpp -quiet -dumpbase
gpp12_module_is_nothrow_constructible_v_failure.cpp -dumpb
ase-ext .cpp -mlittle-endian -mabi=lp64 -std=c++20 -freport-bug -fmodules-ts -o
- -frandom-seed=0 -fdump-noaddr

# 0 "gpp12_module_is_nothrow_constructible_v_failure.cpp"
# 0 "<built-in>"
# 0 "<command-line>"
# 1 "/usr/include/stdc-predef.h" 1 3 4
# 0 "<command-line>" 2
# 1 "gpp12_module_is_nothrow_constructible_v_failure.cpp"




import  derived_interface;

import  "/usr/include/c++/12/type_traits";

void test()
{
 if (std::is_nothrow_constructible_v<derived>);
}

[Bug c++/103499] C++20 modules error: invalid use of non-static member function

[markmigm at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103499

--- Comment #3 from Mark Millard <markmigm at gmail dot com> ---
(In reply to Mark Millard from comment #2 and #1)

Since my example shows that std::is_nothrow_constructible_v<. . .>
can run into the problem, adding bugzilla 99227 ("[meta] [modules]
Bugs relating to header-units of STL header files") to the Blocks
list might be appropriate here. (Not something I can do.)

[Bug c++/103499] C++20 modules error: invalid use of non-static member function

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103499

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bmlushma at uwaterloo dot ca

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 110097 has been marked as a duplicate of this bug. ***

[Bug c++/103499] C++20 modules error: invalid use of non-static member function

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103499

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-06-05
           Keywords|                            |ice-checking
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Mark Millard from comment #3)
> Since my example shows that std::is_nothrow_constructible_v<. . .>
> can run into the problem, adding bugzilla 99227 ("[meta] [modules]
> Bugs relating to header-units of STL header files") to the Blocks
> list might be appropriate here. (Not something I can do.)

I don't think this is related to header-units. Anything that uses the derived
destructor hits the problem. But by that metric, nearly every modules bug would
affect header-units for the standard library, since you can use type traits to
test all kinds of things.

It gives an ICE on trunk with checking enabled:

$ cat export.cc
export module derived_interface;

export struct base
{
        virtual ~base() noexcept = default;
};

export struct derived : base
{
};

$ cat import.cc 
import  derived_interface;

void test(derived* p)
{
 delete p;
}

$ ~/gcc/14/bin/g++ -fmodules-ts -c export.cc
tmp$ ~/gcc/14/bin/g++ -fmodules-ts -c import.cc
import.cc: In function ‘void test(derived@derived_interface*)’:
import.cc:5:9: error: invalid use of non-static member function ‘virtual
derived@derived_interface::~derived()’
    5 |  delete p;
      |         ^
In module derived_interface, imported at import.cc:1:
export.cc:8:15: note: declared here
    8 | export struct derived : base
      |               ^~~~~~~
import.cc:5:9: internal compiler error: in fold_convert_loc, at
fold-const.cc:2574
    5 |  delete p;
      |         ^
0x7f72f9 fold_convert_loc(unsigned int, tree_node*, tree_node*)
        /home/jwakely/src/gcc/gcc/gcc/fold-const.cc:2574
0x9c9f0e build_vfn_ref(tree_node*, tree_node*)
        /home/jwakely/src/gcc/gcc/gcc/cp/class.cc:781
0x9a9578 build_over_call
        /home/jwakely/src/gcc/gcc/gcc/cp/call.cc:10415
0x9a6615 build_new_method_call(tree_node*, tree_node*, vec<tree_node*, va_gc,
vl_embed>**, tree_node*, int, tree_node**, int)
        /home/jwakely/src/gcc/gcc/gcc/cp/call.cc:11702
0x9a77fa build_special_member_call(tree_node*, tree_node*, vec<tree_node*,
va_gc, vl_embed>**, tree_node*, int, int)
        /home/jwakely/src/gcc/gcc/gcc/cp/call.cc:11180
0xa8ad3d build_dtor_call
        /home/jwakely/src/gcc/gcc/gcc/cp/init.cc:5059
0xa8ad3d build_delete(unsigned int, tree_node*, tree_node*,
special_function_kind, int, int, int)
        /home/jwakely/src/gcc/gcc/gcc/cp/init.cc:5255
0xa6772b delete_sanity(unsigned int, tree_node*, tree_node*, bool, int, int)
        /home/jwakely/src/gcc/gcc/gcc/cp/decl2.cc:691
0xb546e8 cp_parser_unary_expression
        /home/jwakely/src/gcc/gcc/gcc/cp/parser.cc:9002
0xb1fc5b cp_parser_binary_expression
        /home/jwakely/src/gcc/gcc/gcc/cp/parser.cc:10147
0xb20b72 cp_parser_assignment_expression
        /home/jwakely/src/gcc/gcc/gcc/cp/parser.cc:10491
0xb23093 cp_parser_expression
        /home/jwakely/src/gcc/gcc/gcc/cp/parser.cc:10661
0xb27227 cp_parser_expression_statement
        /home/jwakely/src/gcc/gcc/gcc/cp/parser.cc:12849
0xb322dd cp_parser_statement
        /home/jwakely/src/gcc/gcc/gcc/cp/parser.cc:12629
0xb335cd cp_parser_statement_seq_opt
        /home/jwakely/src/gcc/gcc/gcc/cp/parser.cc:13000
0xb336a7 cp_parser_compound_statement
        /home/jwakely/src/gcc/gcc/gcc/cp/parser.cc:12952
0xb57cd5 cp_parser_function_body
        /home/jwakely/src/gcc/gcc/gcc/cp/parser.cc:25368
0xb57cd5 cp_parser_ctor_initializer_opt_and_function_body
        /home/jwakely/src/gcc/gcc/gcc/cp/parser.cc:25419
0xb59d0e cp_parser_function_definition_after_declarator
        /home/jwakely/src/gcc/gcc/gcc/cp/parser.cc:32054
0xb5b180 cp_parser_function_definition_from_specifiers_and_declarator
        /home/jwakely/src/gcc/gcc/gcc/cp/parser.cc:31971
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug c++/103499] C++20 modules error: invalid use of non-static member function

[markmigm at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103499

--- Comment #6 from Mark Millard <markmigm at gmail dot com> ---
(In reply to Jonathan Wakely from comment #5)

The relationship I was thinking of was that, without this
being fixed, the full set of header units for the standard
library probably could not be completed: a blocking issue
relative to completing "header-units of STL header files".
(Likely necessary but not sufficient for such completion.)

I was not trying to say that the issue was limited to just
"header-units of STL header files".

As long as the problem is fixed, the relationship would
be handled, just more implicitly relative to the
completion of the "header-units of STL header files".

It is good to have examples that do not involve materials
from /usr/include/c++/ , for sure.

[Bug c++/103499] C++20 modules error: invalid use of non-static member function

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103499

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathan Sidwell <nathan@gcc.gnu.org>:

https://gcc.gnu.org/g:14979dd31c887ba5ba573f2cdb0647b37e09641a

commit r14-5461-g14979dd31c887ba5ba573f2cdb0647b37e09641a
Author: Nathaniel Shead <nathanieloshead@gmail.com>
Date:   Tue Nov 14 11:26:03 2023 -0500

    c++: Stream virtual dtor vtable indices

    Virtual cloned functions have distinct vtable indices, stream them
    explicitly.

    As such, this patch ensures that DECL_VINDEX is properly passed on for
    cloned functions as well to prevent this from causing issues.

            PR c++/103499

    gcc/cp/ChangeLog:

            * module.cc (trees_out::decl_node): Write DECL_VINDEX for
            virtual clones.
            (trees_in::tree_node): Read DECL_VINDEX for virtual clones.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/pr103499_a.C: New test.
            * g++.dg/modules/pr103499_b.C: New test.

    Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>
    Signed-off-by: Nathan Sidwell <nathan@acm.org>

[Bug c++/103499] C++20 modules error: invalid use of non-static member function

[nshead at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103499

Nathaniel Shead <nshead at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |14.0
           Assignee|unassigned at gcc dot gnu.org      |nshead at gcc dot gnu.org
                 CC|                            |nshead at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #8 from Nathaniel Shead <nshead at gcc dot gnu.org> ---
Fixed in GCC 14.

[Bug c++/103499] C++20 modules error: invalid use of non-static member function

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103499

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.cross13 at yahoo dot com

--- Comment #9 from Patrick Palka <ppalka at gcc dot gnu.org> ---
*** Bug 101224 has been marked as a duplicate of this bug. ***