public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "msebor at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/103534] [12 regression] Spurious -Wstringop-overflow warning with std::string concatencation Date: Fri, 10 Dec 2021 16:53:38 +0000 [thread overview] Message-ID: <bug-103534-4-1dACTxkzIQ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-103534-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103534 --- Comment #8 from Martin Sebor <msebor at gcc dot gnu.org> --- We discussed before (e.g., in PR 93971) the idea of annotating std::string with some attribute telling the optimizer the internal pointer doesn't alias with anything except for the this->_M_local_buf or the result of operator new(). Richi seemed open to it but was concerned about correctness. I'm experimenting with two things to improve the context of all these warnings. One is to print the folded condition under which the warning triggers. This would include the conditions involved in all the ranges used to make decisions. I posted the result for this warning here (I'm not sure it's complete, it's just a POC): https://gcc.gnu.org/pipermail/gcc-patches/2021-December/586524.html Another is to print the path through the code (the CFG actually) leading up to the warning site, like the static analyzer does. This will show each GIMPLE_COND after optimization, so it won't correspond exactly to the original source. For libstdc++ code it will show libstdc++ internal conditions that may not be of much use to users. I'll have to see how bad it is to decide if it's a viable approach.
next prev parent reply other threads:[~2021-12-10 16:53 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-02 19:47 [Bug c++/103534] New: " sss@li-snyder.org 2021-12-02 21:03 ` [Bug c++/103534] " msebor at gcc dot gnu.org 2021-12-02 21:53 ` pinskia at gcc dot gnu.org 2021-12-02 23:02 ` redi at gcc dot gnu.org 2021-12-02 23:19 ` msebor at gcc dot gnu.org 2021-12-06 8:16 ` rguenth at gcc dot gnu.org 2021-12-10 16:29 ` jason at gcc dot gnu.org 2021-12-10 16:30 ` jason at gcc dot gnu.org 2021-12-10 16:37 ` jason at gcc dot gnu.org 2021-12-10 16:53 ` msebor at gcc dot gnu.org [this message] 2021-12-10 17:04 ` jakub at gcc dot gnu.org 2021-12-11 4:58 ` cvs-commit at gcc dot gnu.org 2021-12-13 16:11 ` jason at gcc dot gnu.org 2021-12-13 16:11 ` jason at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-103534-4-1dACTxkzIQ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).