public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pc at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/103605] New: [PowerPC] fmin/fmax should be inlined always with xsmindp/xsmaxdp
Date: Tue, 07 Dec 2021 16:21:05 +0000	[thread overview]
Message-ID: <bug-103605-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103605

            Bug ID: 103605
           Summary: [PowerPC] fmin/fmax should be inlined always with
                    xsmindp/xsmaxdp
           Product: gcc
           Version: 11.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pc at gcc dot gnu.org
  Target Milestone: ---

--
$ gcc --version
gcc (GCC) 11.2.1 20210728 (Red Hat 11.2.1-2)
[...]
$ gcc -c -O2 fmin.c && objdump -dr fmin.o
   0:   00 00 4c 3c     addis   r2,r12,0
                        0: R_PPC64_REL16_HA     .TOC.
   4:   00 00 42 38     addi    r2,r2,0
                        4: R_PPC64_REL16_LO     .TOC.+0x4
   8:   a6 02 08 7c     mflr    r0
   c:   10 00 01 f8     std     r0,16(r1)
  10:   e1 ff 21 f8     stdu    r1,-32(r1)
  14:   01 00 00 48     bl      14 <fm+0x14>
                        14: R_PPC64_REL24       fmin
  18:   00 00 00 60     nop
  1c:   20 00 21 38     addi    r1,r1,32
  20:   10 00 01 e8     ld      r0,16(r1)
  24:   a6 03 08 7c     mtlr    r0
  28:   20 00 80 4e     blr
$ gcc -c -O2 fmin.c -ffast-math && objdump -dr fmin.o
   0:   40 14 21 f0     xsmincdp vs1,vs1,vs2
   4:   20 00 80 4e     blr
--

And it appears that a better instruction choice in the above case is xsmindp,
and it can be used with and without "-ffast-math", as it matches the semantics
required of fmin.  Similarly, xsmaxdp with fmax.

             reply	other threads:[~2021-12-07 16:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07 16:21 pc at gcc dot gnu.org [this message]
2021-12-07 16:21 ` [Bug target/103605] " pc at gcc dot gnu.org
2022-04-26  9:27 ` guihaoc at gcc dot gnu.org
2022-04-26 18:35 ` pc at gcc dot gnu.org
2022-04-26 18:46 ` joseph at codesourcery dot com
2022-04-26 20:45 ` pc at gcc dot gnu.org
2022-04-27  5:32 ` guihaoc at gcc dot gnu.org
2022-04-28  3:22 ` linkw at gcc dot gnu.org
2022-05-10 12:21 ` segher at gcc dot gnu.org
2023-07-25  2:43 ` cvs-commit at gcc dot gnu.org
2023-08-17  5:26 ` guihaoc at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103605-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).