[Bug target/103624] New: ICE: unrecognizable insn

[Bug target/103624] New: ICE: unrecognizable insn

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103624

            Bug ID: 103624
           Summary: ICE: unrecognizable insn
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---
            Target: powerpc-e300c3-linux-gnu

gcc 12.0.0 20211205 snapshot (g:c9419faef0bfaf31e6a6f744baa064892e0d105c) ICEs
when compiling gcc/testsuite/gcc.target/powerpc/darn-2.c w/ -mcpu=power9 by a
compiler configured for a 32-bit BE target:

% powerpc-e300c3-linux-gnu-gcc-12.0.0 -mcpu=power9 -c
gcc/testsuite/gcc.target/powerpc/darn-2.c
gcc/testsuite/gcc.target/powerpc/darn-2.c: In function 'get_raw_random':
gcc/testsuite/gcc.target/powerpc/darn-2.c:12:1: error: unrecognizable insn:
   12 | }
      | ^
(insn 5 2 8 2 (set (reg:DI 117 [ _3 ])
        (unspec_volatile:DI [
                (const_int 0 [0])
            ] UNSPECV_DARN_RAW))
"gcc/testsuite/gcc.target/powerpc/darn-2.c":11:10 -1
     (nil))
during RTL pass: vregs
gcc/testsuite/gcc.target/powerpc/darn-2.c:12:1: internal compiler error: in
extract_insn, at recog.c:2769
0x6ac6f5 _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-12.0.0_p20211205/work/gcc-12-20211205/gcc/rtl-error.c:108
0x6ac715 _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-12.0.0_p20211205/work/gcc-12-20211205/gcc/rtl-error.c:116
0x6aad23 extract_insn(rtx_insn*)
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-12.0.0_p20211205/work/gcc-12-20211205/gcc/recog.c:2769
0xb253f3 instantiate_virtual_regs_in_insn
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-12.0.0_p20211205/work/gcc-12-20211205/gcc/function.c:1611
0xb253f3 instantiate_virtual_regs
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-12.0.0_p20211205/work/gcc-12-20211205/gcc/function.c:1985
0xb253f3 execute
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-12.0.0_p20211205/work/gcc-12-20211205/gcc/function.c:2034

[Bug target/103624] ICE: in extract_insn, at recog.c:2769 (error: unrecognizable insn)

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103624

Kewen Lin <linkw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bergner at gcc dot gnu.org,
                   |                            |linkw at gcc dot gnu.org,
                   |                            |segher at gcc dot gnu.org,
                   |                            |wschmidt at gcc dot gnu.org

--- Comment #1 from Kewen Lin <linkw at gcc dot gnu.org> ---
Probably started to fail from r12-5752.

In the previous bif support, __builtin_darn_raw is guarded under mask
RS6000_BTM_64BIT. In the new bif support, it seems to require attribute no32bit
to guard it. __builtin_darn may have the same issue, since both have some
guards in previous support.

[Bug target/103624] ICE: in extract_insn, at recog.c:2769 (error: unrecognizable insn)

[wschmidt at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103624

Bill Schmidt <wschmidt at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |wschmidt at gcc dot gnu.org
   Target Milestone|---                         |12.0

--- Comment #2 from Bill Schmidt <wschmidt at gcc dot gnu.org> ---
Mine.

[Bug target/103624] ICE: in extract_insn, at recog.c:2769 (error: unrecognizable insn)

[wschmidt at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103624

Bill Schmidt <wschmidt at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-12-12
     Ever confirmed|0                           |1

--- Comment #3 from Bill Schmidt <wschmidt at gcc dot gnu.org> ---
Hm, I see a slightly different error (just a seg fault), but still, confirmed.

[Bug target/103624] ICE: in extract_insn, at recog.c:2769 (error: unrecognizable insn)

[wschmidt at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103624

--- Comment #4 from Bill Schmidt <wschmidt at gcc dot gnu.org> ---
__builtin_darn and __builtin_darn_raw are in the wrong stanza.  Moving them to
[power9-64] fixes it on my cross:

diff --git a/gcc/config/rs6000/rs6000-builtin-new.def
b/gcc/config/rs6000/rs6000-builtin-new.def
index 30556e5c7f2..2becd96a36c 100644
--- a/gcc/config/rs6000/rs6000-builtin-new.def
+++ b/gcc/config/rs6000/rs6000-builtin-new.def
@@ -2799,15 +2799,9 @@

 ; Miscellaneous P9 functions
 [power9]
-  signed long long __builtin_darn ();
-    DARN darn {}
-
   signed int __builtin_darn_32 ();
     DARN_32 darn_32 {}

-  signed long long __builtin_darn_raw ();
-    DARN_RAW darn_raw {}
-
   const signed int __builtin_dtstsfi_eq_dd (const int<6>, _Decimal64);
     TSTSFI_EQ_DD dfptstsfi_eq_dd {}

@@ -2840,6 +2834,12 @@
   void __builtin_altivec_stxvl (vsc, void *, long);
     STXVL stxvl {}

+  signed long long __builtin_darn ();
+    DARN darn {}
+
+  signed long long __builtin_darn_raw ();
+    DARN_RAW darn_raw {}
+
   const signed int __builtin_scalar_byte_in_set (signed int, signed long
long);
     CMPEQB cmpeqb {}

[Bug target/103624] ICE: in extract_insn, at recog.c:2769 (error: unrecognizable insn)

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103624

--- Comment #5 from Segher Boessenkool <segher at gcc dot gnu.org> ---
It should work for 32-bit though?

[Bug target/103624] ICE: in extract_insn, at recog.c:2769 (error: unrecognizable insn)

[wschmidt at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103624

--- Comment #6 from Bill Schmidt <wschmidt at gcc dot gnu.org> ---
We have __builtin_darn_32 for the 32-bit case.  The changes for the two
64-bit-only interfaces reflect the previous behavior.

[Bug target/103624] ICE: in extract_insn, at recog.c:2769 (error: unrecognizable insn)

[wschmidt at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103624

--- Comment #7 from Bill Schmidt <wschmidt at gcc dot gnu.org> ---
Patch posted here:

https://gcc.gnu.org/pipermail/gcc-patches/2021-December/586711.html

[Bug target/103624] ICE: in extract_insn, at recog.c:2769 (error: unrecognizable insn)

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103624

--- Comment #8 from Segher Boessenkool <segher at gcc dot gnu.org> ---
(In reply to Bill Schmidt from comment #6)
> We have __builtin_darn_32 for the 32-bit case.  The changes for the two
> 64-bit-only interfaces reflect the previous behavior.

No, that has nothing to do with SF=0.  darn_32 means darn with L=0,
nothing more, nothing less.

[Bug target/103624] ICE: in extract_insn, at recog.c:2769 (error: unrecognizable insn)

[wschmidt at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103624

Bill Schmidt <wschmidt at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|wschmidt at gcc dot gnu.org        |unassigned at gcc dot gnu.org

--- Comment #9 from Bill Schmidt <wschmidt at gcc dot gnu.org> ---
After some discussion, Segher will take a run at this one, so unassigning
myself.

[Bug target/103624] ICE: in extract_insn, at recog.c:2769 (error: unrecognizable insn)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103624

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Segher Boessenkool <segher@gcc.gnu.org>:

https://gcc.gnu.org/g:7194397966e6a007cee42360f96834377c3121a4

commit r12-6047-g7194397966e6a007cee42360f96834377c3121a4
Author: Segher Boessenkool <segher@kernel.crashing.org>
Date:   Fri Dec 17 16:59:55 2021 +0000

    rs6000: Redo darn (PR103624)

    The builtins now all return "long".  The patterns have :GPR as the
    output mode, so they can be 32-bit as well (the instruction makes sense
    in 32 bit just fine).  The builtins expand to the DImode version
    normally, but to the SImode if {32bit} is true.

    2021-12-17  Segher Boessenkool <segher@kernel.crashing.org>

            PR target/103624
            * config/rs6000/rs6000-builtins.def (__builtin_darn): Expand to
            darn_64_di.  Add {32bit} attribute.  Return long.
            (__builtin_darn_32): Expand to darn_32_di.  Add {32bit} attribute.
            Return long.
            (__builtin_darn_raw): Expand to darn_raw_di.  Add {32bit}
attribute.
            Return long.
            * config/rs6000/rs6000-call.c (rs6000_expand_builtin): Expand the
darn
            builtins to the _si variants for -m32.
            * config/rs6000/rs6000.md (UNSPECV_DARN_32, UNSPECV_DARN_RAW):
Delete.
            (UNSPECV_DARN): Update comment.
            (darn_32, darn_raw, darn): Delete.
            (darn_32_<mode>, darn_64_<mode>, darn_raw_<mode> for GPR): New.
            (@darn<mode> for GPR): New.

[Bug target/103624] ICE: in extract_insn, at recog.c:2769 (error: unrecognizable insn)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103624

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Segher Boessenkool <segher@gcc.gnu.org>:

https://gcc.gnu.org/g:87ae8d7613a8b15d0d729b38ffd49153f1314799

commit r12-6048-g87ae8d7613a8b15d0d729b38ffd49153f1314799
Author: Segher Boessenkool <segher@kernel.crashing.org>
Date:   Fri Dec 17 17:01:16 2021 +0000

    rs6000: Update darn testcases

    Make the darn testcases work (and be tested) in 32-bit mode as well.
    They used to ICE, but they no longer do.

    2021-12-17  Segher Boessenkool <segher@kernel.crashing.org>

    gcc/testsuite/
            PR target/103624
            * gcc.target/powerpc/darn-0.c: Remove target clause.
            * gcc.target/powerpc/darn-1.c: Remove target clause. Remove lp64
            requirement.  Change return type to long.
            * gcc.target/powerpc/darn-2.c: Ditto.
            * gcc.target/powerpc/darn-3.c: Remove target clause.

[Bug target/103624] ICE: in extract_insn, at recog.c:2769 (error: unrecognizable insn)

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103624

Segher Boessenkool <segher at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #12 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Fixed on trunk.  No backports planned.