public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug ipa/103669] New: [12 Regression] wrong code with -O --param=modref-max-depth=1
@ 2021-12-12 16:27 zsojka at seznam dot cz
2021-12-12 20:29 ` [Bug ipa/103669] " pinskia at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: zsojka at seznam dot cz @ 2021-12-12 16:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103669
Bug ID: 103669
Summary: [12 Regression] wrong code with -O
--param=modref-max-depth=1
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Keywords: wrong-code
Severity: normal
Priority: P3
Component: ipa
Assignee: unassigned at gcc dot gnu.org
Reporter: zsojka at seznam dot cz
CC: marxin at gcc dot gnu.org
Target Milestone: ---
Host: x86_64-pc-linux-gnu
Created attachment 51979
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51979&action=edit
reduced testcase (from OpenTTD sources)
Output:
$ x86_64-pc-linux-gnu-g++ -O --param=modref-max-depth=1 testcase.C
$ ./a.out
Aborted
$ x86_64-pc-linux-gnu-g++ -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest/bin/x86_64-pc-linux-gnu-g++
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r12-5916-20211212131849-gaeedb00a1ae-checking-yes-rtl-df-extra-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/12.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--with-cloog --with-ppl --with-isl --build=x86_64-pc-linux-gnu
--host=x86_64-pc-linux-gnu --target=x86_64-pc-linux-gnu
--with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r12-5916-20211212131849-gaeedb00a1ae-checking-yes-rtl-df-extra-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.0.0 20211212 (experimental) (GCC)
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug ipa/103669] [12 Regression] wrong code with -O --param=modref-max-depth=1 2021-12-12 16:27 [Bug ipa/103669] New: [12 Regression] wrong code with -O --param=modref-max-depth=1 zsojka at seznam dot cz @ 2021-12-12 20:29 ` pinskia at gcc dot gnu.org 2021-12-13 10:00 ` [Bug ipa/103669] [12 Regression] wrong code with -O --param=modref-max-depth=1 since r12-4976-g4898e958a92d45db marxin at gcc dot gnu.org ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: pinskia at gcc dot gnu.org @ 2021-12-12 20:29 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103669 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |12.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug ipa/103669] [12 Regression] wrong code with -O --param=modref-max-depth=1 since r12-4976-g4898e958a92d45db 2021-12-12 16:27 [Bug ipa/103669] New: [12 Regression] wrong code with -O --param=modref-max-depth=1 zsojka at seznam dot cz 2021-12-12 20:29 ` [Bug ipa/103669] " pinskia at gcc dot gnu.org @ 2021-12-13 10:00 ` marxin at gcc dot gnu.org 2021-12-19 22:08 ` hubicka at gcc dot gnu.org ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: marxin at gcc dot gnu.org @ 2021-12-13 10:00 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103669 Martin Liška <marxin at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[12 Regression] wrong code |[12 Regression] wrong code |with -O |with -O |--param=modref-max-depth=1 |--param=modref-max-depth=1 | |since | |r12-4976-g4898e958a92d45db Priority|P3 |P1 Last reconfirmed| |2021-12-13 CC| |hubicka at gcc dot gnu.org Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> --- Started with r12-4976-g4898e958a92d45db. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug ipa/103669] [12 Regression] wrong code with -O --param=modref-max-depth=1 since r12-4976-g4898e958a92d45db 2021-12-12 16:27 [Bug ipa/103669] New: [12 Regression] wrong code with -O --param=modref-max-depth=1 zsojka at seznam dot cz 2021-12-12 20:29 ` [Bug ipa/103669] " pinskia at gcc dot gnu.org 2021-12-13 10:00 ` [Bug ipa/103669] [12 Regression] wrong code with -O --param=modref-max-depth=1 since r12-4976-g4898e958a92d45db marxin at gcc dot gnu.org @ 2021-12-19 22:08 ` hubicka at gcc dot gnu.org 2021-12-20 7:43 ` cvs-commit at gcc dot gnu.org 2021-12-20 7:45 ` hubicka at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: hubicka at gcc dot gnu.org @ 2021-12-19 22:08 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103669 --- Comment #2 from Jan Hubicka <hubicka at gcc dot gnu.org> --- Created attachment 52030 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52030&action=edit Patch in testing The problem here is a mixup with do_dataflow flag which prevents the name from being analyzed. I am testing the attached patch, but I wonder if we can get a testcase that does not depend on list from libstdc++? ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug ipa/103669] [12 Regression] wrong code with -O --param=modref-max-depth=1 since r12-4976-g4898e958a92d45db 2021-12-12 16:27 [Bug ipa/103669] New: [12 Regression] wrong code with -O --param=modref-max-depth=1 zsojka at seznam dot cz ` (2 preceding siblings ...) 2021-12-19 22:08 ` hubicka at gcc dot gnu.org @ 2021-12-20 7:43 ` cvs-commit at gcc dot gnu.org 2021-12-20 7:45 ` hubicka at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2021-12-20 7:43 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103669 --- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jan Hubicka <hubicka@gcc.gnu.org>: https://gcc.gnu.org/g:8d1e342b4afbad77cb92f8057cf6d1e996bfb077 commit r12-6072-g8d1e342b4afbad77cb92f8057cf6d1e996bfb077 Author: Jan Hubicka <jh@suse.cz> Date: Mon Dec 20 08:43:13 2021 +0100 Fix handling of deferred SSA names in modref dataflow In the testcase we fail to analyze SSA name because flag do_dataflow is set and thus triggers early exist in analyze_ssa_name. Fixed by disabling early exits when handling deferred names. gcc/ChangeLog: 2021-12-20 Jan Hubicka <hubicka@ucw.cz> PR ipa/103669 * ipa-modref.c (modref_eaf_analysis::analyze_ssa_name): Add deferred parameter. (modref_eaf_analysis::propagate): Use it. gcc/testsuite/ChangeLog: 2021-12-20 Jan Hubicka <hubicka@ucw.cz> PR ipa/103669 * g++.dg/torture/pr103669.C: New test. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug ipa/103669] [12 Regression] wrong code with -O --param=modref-max-depth=1 since r12-4976-g4898e958a92d45db 2021-12-12 16:27 [Bug ipa/103669] New: [12 Regression] wrong code with -O --param=modref-max-depth=1 zsojka at seznam dot cz ` (3 preceding siblings ...) 2021-12-20 7:43 ` cvs-commit at gcc dot gnu.org @ 2021-12-20 7:45 ` hubicka at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: hubicka at gcc dot gnu.org @ 2021-12-20 7:45 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103669 Jan Hubicka <hubicka at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> --- Fixed. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-20 7:45 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-12-12 16:27 [Bug ipa/103669] New: [12 Regression] wrong code with -O --param=modref-max-depth=1 zsojka at seznam dot cz 2021-12-12 20:29 ` [Bug ipa/103669] " pinskia at gcc dot gnu.org 2021-12-13 10:00 ` [Bug ipa/103669] [12 Regression] wrong code with -O --param=modref-max-depth=1 since r12-4976-g4898e958a92d45db marxin at gcc dot gnu.org 2021-12-19 22:08 ` hubicka at gcc dot gnu.org 2021-12-20 7:43 ` cvs-commit at gcc dot gnu.org 2021-12-20 7:45 ` hubicka at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).