[Bug fortran/103692] New: [11/12 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:2062

[Bug fortran/103692] New: [11/12 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:2062

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103692

            Bug ID: 103692
           Summary: [11/12 Regression] ICE in add_init_expr_to_sym, at
                    fortran/decl.c:2062
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Changed recently between 20211205 and 20211212 :


$ cat z1.f90
program p
   character(3), parameter :: a(4) = 'abc'
   character(*), parameter :: b(-1) = (a(2:1))
end


$ gfortran-12-20211205 -c z1.f90
z1.f90:3:35:

    3 |    character(*), parameter :: b(-1) = (a(2:1))
      |                                   1
Error: Different shape for array assignment at (1) on dimension 1 (-1 and 0)


$ gfortran-12-20211212 -c z1.f90
f951: internal compiler error: in add_init_expr_to_sym, at fortran/decl.c:2062
0x782cdf add_init_expr_to_sym
        ../../gcc/fortran/decl.c:2062
0x78c6aa variable_decl
        ../../gcc/fortran/decl.c:3108
0x78c6aa gfc_match_data_decl()
        ../../gcc/fortran/decl.c:6297
0x7f7183 match_word
        ../../gcc/fortran/parse.c:67
0x7f7183 decode_statement
        ../../gcc/fortran/parse.c:378
0x7f8bca next_free
        ../../gcc/fortran/parse.c:1397
0x7f8bca next_statement
        ../../gcc/fortran/parse.c:1629
0x7fa15b parse_spec
        ../../gcc/fortran/parse.c:4168
0x7fd2ac parse_progunit
        ../../gcc/fortran/parse.c:6192
0x7fe971 gfc_parse_file()
        ../../gcc/fortran/parse.c:6737
0x84bfcf gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:216

[Bug fortran/103692] [11/12 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:2062

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103692

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-12-13
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #1 from anlauf at gcc dot gnu.org ---
ICE confirmed.  I am not so sure that this is invalid code.

NAG accepts it, and I believe it is right.

(a(2:1)) should have shape=[0], len=3

[Bug fortran/103692] [11/12 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:2062

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103692

--- Comment #2 from anlauf at gcc dot gnu.org ---
It is probably easier to compare

  character(*), parameter :: b(*) = (a(2:1)) ! ICE

vs.

  character(*), parameter :: b(*) = a(2:1)   ! no ICE

[Bug fortran/103692] [11/12 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:2062

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103692

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
The ICE started with r12-5842-g5f7cdea34e118776.

[Bug fortran/103692] [11/12 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:2062

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103692

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.3
           Priority|P3                          |P4

[Bug fortran/103692] [11/12 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:2062

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103692

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code

--- Comment #4 from anlauf at gcc dot gnu.org ---
We need to handle zero-sized constructors.

Tentative patch:

diff --git a/gcc/fortran/array.c b/gcc/fortran/array.c
index 472304326e8..f1d92e00c98 100644
--- a/gcc/fortran/array.c
+++ b/gcc/fortran/array.c
@@ -1883,6 +1883,9 @@ gfc_expand_constructor (gfc_expr *e, bool fatal)
   gfc_expr *f;
   bool rc;

+  if (gfc_is_size_zero_array (e))
+    return true;
+
   /* If we can successfully get an array element at the max array size then
      the array is too big to expand, so we just return.  */
   f = gfc_get_array_element (e, flag_max_array_constructor);

[Bug fortran/103692] [11/12 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:2062

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103692

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

--- Comment #5 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2022-January/057420.html

[Bug fortran/103692] [11/12 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:2062

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103692

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:0d01a2722671bef37b931fd1f121e44b27e68268

commit r12-6695-g0d01a2722671bef37b931fd1f121e44b27e68268
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Jan 17 22:52:08 2022 +0100

    Fortran: handle expansion of zero-sized array constructors

    gcc/fortran/ChangeLog:

            PR fortran/103692
            * array.cc (gfc_expand_constructor): Handle zero-sized array
            constructors.

    gcc/testsuite/ChangeLog:

            PR fortran/103692
            * gfortran.dg/pr102520.f90: Adjust error messages.
            * gfortran.dg/pr103692.f90: New test.

[Bug fortran/103692] [11/12 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:2062

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103692

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:0351d851f791d81d85d4c366755e0662ea67dc97

commit r11-9483-g0351d851f791d81d85d4c366755e0662ea67dc97
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Jan 17 22:52:08 2022 +0100

    Fortran: handle expansion of zero-sized array constructors

    gcc/fortran/ChangeLog:

            PR fortran/103692
            * array.c (gfc_expand_constructor): Handle zero-sized array
            constructors.

    gcc/testsuite/ChangeLog:

            PR fortran/103692
            * gfortran.dg/pr102520.f90: Adjust error messages.
            * gfortran.dg/pr103692.f90: New test.

    (cherry picked from commit 0d01a2722671bef37b931fd1f121e44b27e68268)

[Bug fortran/103692] [11/12 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:2062

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103692

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:31677c2cbd1b725e7f46d6cc7c3353f0e4748f32

commit r10-10410-g31677c2cbd1b725e7f46d6cc7c3353f0e4748f32
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Jan 17 22:52:08 2022 +0100

    Fortran: handle expansion of zero-sized array constructors

    gcc/fortran/ChangeLog:

            PR fortran/103692
            * array.c (gfc_expand_constructor): Handle zero-sized array
            constructors.

    gcc/testsuite/ChangeLog:

            PR fortran/103692
            * gfortran.dg/pr102520.f90: Adjust error messages.
            * gfortran.dg/pr103692.f90: New test.

    (cherry picked from commit 0d01a2722671bef37b931fd1f121e44b27e68268)

[Bug fortran/103692] [11/12 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:2062

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103692

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-12, and on 11- and 10-branches.  Closing.

Thanks for the report!