public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/103714] New: [11/12 Regression] name lookup in requires-clause finds wrong thing
@ 2021-12-14 17:16 redi at gcc dot gnu.org
2021-12-14 17:18 ` [Bug c++/103714] " redi at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2021-12-14 17:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103714
Bug ID: 103714
Summary: [11/12 Regression] name lookup in requires-clause
finds wrong thing
Product: gcc
Version: 11.2.1
Status: UNCONFIRMED
Keywords: accepts-invalid
Severity: normal
Priority: P3
Component: c++
Assignee: unassigned at gcc dot gnu.org
Reporter: redi at gcc dot gnu.org
CC: ppalka at gcc dot gnu.org
Target Milestone: ---
This invalid code started to be accepted at r11-8144
template <int I>
struct derp
{
constexpr inline static int i = I;
template <int J>
void f(derp<J> d) requires(d.i < i)
{
__builtin_printf("derp %zu < %zu\n", d.i, i);
derp<I> d2;
f(d2);
}
};
int main()
{
derp<9> d9;
derp<8> d8;
d9.f(d8);
}
If the requires clause is changed to (d.derp<J>::i < i) then it is correctly
rejected, but for some reason (d.i < i) is satisfied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/103714] [11/12 Regression] name lookup in requires-clause finds wrong thing
2021-12-14 17:16 [Bug c++/103714] New: [11/12 Regression] name lookup in requires-clause finds wrong thing redi at gcc dot gnu.org
@ 2021-12-14 17:18 ` redi at gcc dot gnu.org
2021-12-14 22:26 ` ppalka at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2021-12-14 17:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103714
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2021-12-14
Priority|P3 |P2
Known to fail| |11.1.0, 11.2.0, 12.0
Target Milestone|--- |11.3
Known to work| |10.3.0
Ever confirmed|0 |1
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Running the code shows that it recurses until the stack overflows:
derp 8 < 9
derp 9 < 9
derp 9 < 9
derp 9 < 9
derp 9 < 9
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/103714] [11/12 Regression] name lookup in requires-clause finds wrong thing
2021-12-14 17:16 [Bug c++/103714] New: [11/12 Regression] name lookup in requires-clause finds wrong thing redi at gcc dot gnu.org
2021-12-14 17:18 ` [Bug c++/103714] " redi at gcc dot gnu.org
@ 2021-12-14 22:26 ` ppalka at gcc dot gnu.org
2021-12-19 17:10 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ppalka at gcc dot gnu.org @ 2021-12-14 22:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103714
Patrick Palka <ppalka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |ppalka at gcc dot gnu.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/103714] [11/12 Regression] name lookup in requires-clause finds wrong thing
2021-12-14 17:16 [Bug c++/103714] New: [11/12 Regression] name lookup in requires-clause finds wrong thing redi at gcc dot gnu.org
2021-12-14 17:18 ` [Bug c++/103714] " redi at gcc dot gnu.org
2021-12-14 22:26 ` ppalka at gcc dot gnu.org
@ 2021-12-19 17:10 ` cvs-commit at gcc dot gnu.org
2021-12-19 19:10 ` cvs-commit at gcc dot gnu.org
2021-12-19 19:10 ` ppalka at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-12-19 17:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103714
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:
https://gcc.gnu.org/g:30c286aa9377850c64aa35f5845a59d321a44be0
commit r12-6063-g30c286aa9377850c64aa35f5845a59d321a44be0
Author: Patrick Palka <ppalka@redhat.com>
Date: Sun Dec 19 12:10:16 2021 -0500
c++: local_specializations and recursive constrained fn [PR103714]
Here during constraint checking for the inner call to A<0>::f<0>,
substitution into the PARM_DECL d in the atomic constraint yields the
wrong local specialization because local_specializations at this point
is nonempty, and contains specializations for the caller A<0>::f<1>.
This patch makes us call push_to_top_level during satisfaction, which'll
temporarily clear local_specializations for us.
PR c++/103714
gcc/cp/ChangeLog:
* constraint.cc (satisfy_declaration_constraints): Do
push_to_top_level and pop_from_top_level around the call to
satisfy_normalized_constraints.
gcc/testsuite/ChangeLog:
* g++.dg/cpp2a/concepts-uneval5.C: New test.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/103714] [11/12 Regression] name lookup in requires-clause finds wrong thing
2021-12-14 17:16 [Bug c++/103714] New: [11/12 Regression] name lookup in requires-clause finds wrong thing redi at gcc dot gnu.org
` (2 preceding siblings ...)
2021-12-19 17:10 ` cvs-commit at gcc dot gnu.org
@ 2021-12-19 19:10 ` cvs-commit at gcc dot gnu.org
2021-12-19 19:10 ` ppalka at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-12-19 19:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103714
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:
https://gcc.gnu.org/g:75d95f5f0151247c39f0beb01376485806d0fd47
commit r11-9401-g75d95f5f0151247c39f0beb01376485806d0fd47
Author: Patrick Palka <ppalka@redhat.com>
Date: Sun Dec 19 12:10:16 2021 -0500
c++: local_specializations and recursive constrained fn [PR103714]
Here during constraint checking for the inner call to A<0>::f<0>,
substitution into the PARM_DECL d in the atomic constraint yields the
wrong local specialization because local_specializations at this point
is nonempty, and contains specializations for the caller A<0>::f<1>.
This patch makes us call push_to_top_level during satisfaction, which'll
temporarily clear local_specializations for us.
PR c++/103714
gcc/cp/ChangeLog:
* constraint.cc (satisfy_declaration_constraints): Do
push_to_top_level and pop_from_top_level around the call to
satisfy_normalized_constraints.
gcc/testsuite/ChangeLog:
* g++.dg/cpp2a/concepts-uneval5.C: New test.
(cherry picked from commit 30c286aa9377850c64aa35f5845a59d321a44be0)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/103714] [11/12 Regression] name lookup in requires-clause finds wrong thing
2021-12-14 17:16 [Bug c++/103714] New: [11/12 Regression] name lookup in requires-clause finds wrong thing redi at gcc dot gnu.org
` (3 preceding siblings ...)
2021-12-19 19:10 ` cvs-commit at gcc dot gnu.org
@ 2021-12-19 19:10 ` ppalka at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: ppalka at gcc dot gnu.org @ 2021-12-19 19:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103714
Patrick Palka <ppalka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Fixed for GCC 11.3/12.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-19 19:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-14 17:16 [Bug c++/103714] New: [11/12 Regression] name lookup in requires-clause finds wrong thing redi at gcc dot gnu.org
2021-12-14 17:18 ` [Bug c++/103714] " redi at gcc dot gnu.org
2021-12-14 22:26 ` ppalka at gcc dot gnu.org
2021-12-19 17:10 ` cvs-commit at gcc dot gnu.org
2021-12-19 19:10 ` cvs-commit at gcc dot gnu.org
2021-12-19 19:10 ` ppalka at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).