public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/103718] New: [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2393
@ 2021-12-14 18:13 gscfq@t-online.de
  2021-12-14 19:17 ` [Bug fortran/103718] " anlauf at gcc dot gnu.org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: gscfq@t-online.de @ 2021-12-14 18:13 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103718

            Bug ID: 103718
           Summary: [11/12 Regression] ICE in
                    doloop_contained_procedure_code, at
                    fortran/frontend-passes.c:2393
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Changed between 20200726 and 20200809 :
(gcc configured with --enable-checking=yes)


$ cat z1.f90
program p
   integer :: i
   do i = 1, 2
      call s
   end do
contains
   subroutine s
      shape(1) = 0
   end
end


$ cat z3.f90
program p
   integer :: i
   do i = 1, 2
      call s
   end do
contains
   subroutine s
      real(1) = 0
   end
end


$ gfortran-12-20211212 -c z1.f90
z1.f90:8:6:

    8 |       shape(1) = 0
      |      1
Error: Non-variable expression in variable definition context (assignment) at
(1)
f951: internal compiler error: Segmentation fault
0xf12d1f crash_signal
        ../../gcc/toplev.c:322
0x950019 doloop_contained_procedure_code
        ../../gcc/fortran/frontend-passes.c:2393
0x955909 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5337
0x957e72 doloop_code
        ../../gcc/fortran/frontend-passes.c:2627
0x955909 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5337
0x955a87 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5673
0x956afb doloop_warn
        ../../gcc/fortran/frontend-passes.c:3063
0x95704a gfc_run_passes(gfc_namespace*)
        ../../gcc/fortran/frontend-passes.c:156
0x857657 gfc_resolve(gfc_namespace*)
        ../../gcc/fortran/resolve.c:17573
0x83f954 resolve_all_program_units
        ../../gcc/fortran/parse.c:6586
0x83f954 gfc_parse_file()
        ../../gcc/fortran/parse.c:6842
0x88db0f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:216

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/103718] [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2393
  2021-12-14 18:13 [Bug fortran/103718] New: [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2393 gscfq@t-online.de
@ 2021-12-14 19:17 ` anlauf at gcc dot gnu.org
  2021-12-14 20:09 ` anlauf at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-12-14 19:17 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103718

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
                 CC|                            |anlauf at gcc dot gnu.org
   Last reconfirmed|                            |2021-12-14
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Target Milestone|---                         |11.4

--- Comment #1 from anlauf at gcc dot gnu.org ---
Patch for NULL pointer dereference:

diff --git a/gcc/fortran/frontend-passes.c b/gcc/fortran/frontend-passes.c
index 57b24a11cbe..8836b40be43 100644
--- a/gcc/fortran/frontend-passes.c
+++ b/gcc/fortran/frontend-passes.c
@@ -2390,7 +2390,7 @@ doloop_contained_procedure_code (gfc_code **c,
   switch (co->op)
     {
     case EXEC_ASSIGN:
-      if (co->expr1->symtree->n.sym == do_var)
+      if (co->expr1->symtree && co->expr1->symtree->n.sym == do_var)
        gfc_error_now (errmsg, do_var->name, &co->loc, info->procedure->name,
                       &info->where_do);
       break;

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/103718] [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2393
  2021-12-14 18:13 [Bug fortran/103718] New: [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2393 gscfq@t-online.de
  2021-12-14 19:17 ` [Bug fortran/103718] " anlauf at gcc dot gnu.org
@ 2021-12-14 20:09 ` anlauf at gcc dot gnu.org
  2021-12-14 20:14 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-12-14 20:09 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103718

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #2 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2021-December/057172.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/103718] [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2393
  2021-12-14 18:13 [Bug fortran/103718] New: [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2393 gscfq@t-online.de
  2021-12-14 19:17 ` [Bug fortran/103718] " anlauf at gcc dot gnu.org
  2021-12-14 20:09 ` anlauf at gcc dot gnu.org
@ 2021-12-14 20:14 ` cvs-commit at gcc dot gnu.org
  2021-12-15 19:35 ` cvs-commit at gcc dot gnu.org
  2021-12-15 19:38 ` anlauf at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-12-14 20:14 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103718

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:e866e1c92ecf88feeeafd5d55348451c9a181f3c

commit r12-5967-ge866e1c92ecf88feeeafd5d55348451c9a181f3c
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Dec 14 21:02:04 2021 +0100

    Fortran: prevent NULL pointer dereferences checking do-loop contained stuff

    gcc/fortran/ChangeLog:

            PR fortran/103718
            PR fortran/103719
            * frontend-passes.c (doloop_contained_procedure_code): Add several
            checks to prevent NULL pointer dereferences on valid and invalid
            code called within do-loops.

    gcc/testsuite/ChangeLog:

            PR fortran/103718
            PR fortran/103719
            * gfortran.dg/do_check_18.f90: New test.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/103718] [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2393
  2021-12-14 18:13 [Bug fortran/103718] New: [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2393 gscfq@t-online.de
                   ` (2 preceding siblings ...)
  2021-12-14 20:14 ` cvs-commit at gcc dot gnu.org
@ 2021-12-15 19:35 ` cvs-commit at gcc dot gnu.org
  2021-12-15 19:38 ` anlauf at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-12-15 19:35 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103718

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:689f8fed9b2a250e6cbeeec4fa882b8afd34eec8

commit r11-9385-g689f8fed9b2a250e6cbeeec4fa882b8afd34eec8
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Dec 14 21:02:04 2021 +0100

    Fortran: prevent NULL pointer dereferences checking do-loop contained stuff

    gcc/fortran/ChangeLog:

            PR fortran/103718
            PR fortran/103719
            * frontend-passes.c (doloop_contained_procedure_code): Add several
            checks to prevent NULL pointer dereferences on valid and invalid
            code called within do-loops.

    gcc/testsuite/ChangeLog:

            PR fortran/103718
            PR fortran/103719
            * gfortran.dg/do_check_18.f90: New test.

    (cherry picked from commit e866e1c92ecf88feeeafd5d55348451c9a181f3c)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/103718] [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2393
  2021-12-14 18:13 [Bug fortran/103718] New: [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2393 gscfq@t-online.de
                   ` (3 preceding siblings ...)
  2021-12-15 19:35 ` cvs-commit at gcc dot gnu.org
@ 2021-12-15 19:38 ` anlauf at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-12-15 19:38 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103718

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from anlauf at gcc dot gnu.org ---
Fixed.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-12-15 19:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-14 18:13 [Bug fortran/103718] New: [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2393 gscfq@t-online.de
2021-12-14 19:17 ` [Bug fortran/103718] " anlauf at gcc dot gnu.org
2021-12-14 20:09 ` anlauf at gcc dot gnu.org
2021-12-14 20:14 ` cvs-commit at gcc dot gnu.org
2021-12-15 19:35 ` cvs-commit at gcc dot gnu.org
2021-12-15 19:38 ` anlauf at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).