[Bug fortran/103719] New: [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2465

[Bug fortran/103719] New: [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2465

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103719

            Bug ID: 103719
           Summary: [11/12 Regression] ICE in
                    doloop_contained_procedure_code, at
                    fortran/frontend-passes.c:2465
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Changed between 20200726 and 20200809 :
(gcc configured with --enable-checking=yes)
(presumably related to pr103718)


$ cat z1.f90
program p
   integer :: i
   do i = 1, 2
      call s
   end do
contains
   subroutine s
      integer :: n
      inquire (iolength=n) 0
   end
end


$ gfortran-12-20211212 -c z1.f90
f951: internal compiler error: Segmentation fault
0xf12d1f crash_signal
        ../../gcc/toplev.c:322
0x94ffbd doloop_contained_procedure_code
        ../../gcc/fortran/frontend-passes.c:2465
0x955909 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5337
0x955a87 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5673
0x957e72 doloop_code
        ../../gcc/fortran/frontend-passes.c:2627
0x955909 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5337
0x955a87 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5673
0x956afb doloop_warn
        ../../gcc/fortran/frontend-passes.c:3063
0x95704a gfc_run_passes(gfc_namespace*)
        ../../gcc/fortran/frontend-passes.c:156
0x857657 gfc_resolve(gfc_namespace*)
        ../../gcc/fortran/resolve.c:17573
0x83f954 resolve_all_program_units
        ../../gcc/fortran/parse.c:6586
0x83f954 gfc_parse_file()
        ../../gcc/fortran/parse.c:6842
0x88db0f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:216

[Bug fortran/103719] [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2465

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103719

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-12-14
           Priority|P3                          |P4
   Target Milestone|---                         |11.4
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
                 CC|                            |anlauf at gcc dot gnu.org
           Keywords|ice-on-invalid-code         |ice-on-valid-code

--- Comment #1 from anlauf at gcc dot gnu.org ---
Indeed related to PR103718: nearby NULL pointer dereferences.

This one is helpful as it shows a different, more complex code path.

And it is valid code, not invalid!  (It was accepted with gcc-10).

[Bug fortran/103719] [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103719

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:e866e1c92ecf88feeeafd5d55348451c9a181f3c

commit r12-5967-ge866e1c92ecf88feeeafd5d55348451c9a181f3c
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Dec 14 21:02:04 2021 +0100

    Fortran: prevent NULL pointer dereferences checking do-loop contained stuff

    gcc/fortran/ChangeLog:

            PR fortran/103718
            PR fortran/103719
            * frontend-passes.c (doloop_contained_procedure_code): Add several
            checks to prevent NULL pointer dereferences on valid and invalid
            code called within do-loops.

    gcc/testsuite/ChangeLog:

            PR fortran/103718
            PR fortran/103719
            * gfortran.dg/do_check_18.f90: New test.

[Bug fortran/103719] [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103719

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:689f8fed9b2a250e6cbeeec4fa882b8afd34eec8

commit r11-9385-g689f8fed9b2a250e6cbeeec4fa882b8afd34eec8
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Dec 14 21:02:04 2021 +0100

    Fortran: prevent NULL pointer dereferences checking do-loop contained stuff

    gcc/fortran/ChangeLog:

            PR fortran/103718
            PR fortran/103719
            * frontend-passes.c (doloop_contained_procedure_code): Add several
            checks to prevent NULL pointer dereferences on valid and invalid
            code called within do-loops.

    gcc/testsuite/ChangeLog:

            PR fortran/103718
            PR fortran/103719
            * gfortran.dg/do_check_18.f90: New test.

    (cherry picked from commit e866e1c92ecf88feeeafd5d55348451c9a181f3c)

[Bug fortran/103719] [11/12 Regression] ICE in doloop_contained_procedure_code, at fortran/frontend-passes.c:2465

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103719

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from anlauf at gcc dot gnu.org ---
Fixed.