public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at kam dot mff.cuni.cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/103734] IPA-CP opportunity for imagick in SPECCPU 2017
Date: Wed, 15 Dec 2021 12:50:42 +0000	[thread overview]
Message-ID: <bug-103734-4-i4SUym6HlO@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103734-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103734

--- Comment #1 from hubicka at kam dot mff.cuni.cz ---
I think ipa-cp heuristics still needs some work.  It is nice that we got
it to do something, but I just checked and with LTO+PGO build of clang
it produces cca 30 clones that are not "for all known contexts", so it
seems that it is still quite strict on what it considers to clone at
least with FDO.

On the other hand we have PR103195 where tfft2 grows by 70% becuase
function is cloned with no great benefits.

I think one problem is that it is based on absolute time improvements.
This has problems because bigger functions run longer and more likely
to see bigger absolute improvement, but we are more interested in
relative improvement (i.e. duplicating very large fucntion to get 0.001%
speedup is less useful than duplicating small function that get 10%
speedup even if absolute number is same).

With profile feedback absolute numbers are OK since they should
translate to actual speedups of the whole program.  But then longer
trained programs will see bigger numbers than shorter trained numbers so
perhaps this should be relative to overall running time of the program?

  parent reply	other threads:[~2021-12-15 12:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15 12:14 [Bug ipa/103734] New: " tnfchris at gcc dot gnu.org
2021-12-15 12:22 ` [Bug ipa/103734] " marxin at gcc dot gnu.org
2021-12-15 12:50 ` hubicka at kam dot mff.cuni.cz [this message]
2021-12-16  6:18 ` pinskia at gcc dot gnu.org
2021-12-16  6:37 ` crazylht at gmail dot com
2021-12-17 17:23 ` pthaugen at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103734-4-i4SUym6HlO@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).