public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug ipa/103734] New: IPA-CP opportunity for imagick in SPECCPU 2017
@ 2021-12-15 12:14 tnfchris at gcc dot gnu.org
2021-12-15 12:22 ` [Bug ipa/103734] " marxin at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2021-12-15 12:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103734
Bug ID: 103734
Summary: IPA-CP opportunity for imagick in SPECCPU 2017
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: ipa
Assignee: unassigned at gcc dot gnu.org
Reporter: tnfchris at gcc dot gnu.org
CC: hubicka at gcc dot gnu.org, marxin at gcc dot gnu.org
Target Milestone: ---
When using --param ipa-cp-eval-threshold=1 --param ipa-cp-unit-growth=20 on
imagick the hot functions MorphologyApply and GetVirtualPixelsFromNexus get
replaced by specialized versions that are much smaller and faster.
Some other benchmarks like leela also get very small uplifts but the imagick
one is worth 14%. Both flags seem to be needed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug ipa/103734] IPA-CP opportunity for imagick in SPECCPU 2017
2021-12-15 12:14 [Bug ipa/103734] New: IPA-CP opportunity for imagick in SPECCPU 2017 tnfchris at gcc dot gnu.org
@ 2021-12-15 12:22 ` marxin at gcc dot gnu.org
2021-12-15 12:50 ` hubicka at kam dot mff.cuni.cz
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-12-15 12:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103734
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |26163
Last reconfirmed| |2021-12-15
Status|UNCONFIRMED |NEW
CC| |jamborm at gcc dot gnu.org
Ever confirmed|0 |1
Referenced Bugs:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=26163
[Bug 26163] [meta-bug] missed optimization in SPEC (2k17, 2k and 2k6 and 95)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug ipa/103734] IPA-CP opportunity for imagick in SPECCPU 2017
2021-12-15 12:14 [Bug ipa/103734] New: IPA-CP opportunity for imagick in SPECCPU 2017 tnfchris at gcc dot gnu.org
2021-12-15 12:22 ` [Bug ipa/103734] " marxin at gcc dot gnu.org
@ 2021-12-15 12:50 ` hubicka at kam dot mff.cuni.cz
2021-12-16 6:18 ` pinskia at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: hubicka at kam dot mff.cuni.cz @ 2021-12-15 12:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103734
--- Comment #1 from hubicka at kam dot mff.cuni.cz ---
I think ipa-cp heuristics still needs some work. It is nice that we got
it to do something, but I just checked and with LTO+PGO build of clang
it produces cca 30 clones that are not "for all known contexts", so it
seems that it is still quite strict on what it considers to clone at
least with FDO.
On the other hand we have PR103195 where tfft2 grows by 70% becuase
function is cloned with no great benefits.
I think one problem is that it is based on absolute time improvements.
This has problems because bigger functions run longer and more likely
to see bigger absolute improvement, but we are more interested in
relative improvement (i.e. duplicating very large fucntion to get 0.001%
speedup is less useful than duplicating small function that get 10%
speedup even if absolute number is same).
With profile feedback absolute numbers are OK since they should
translate to actual speedups of the whole program. But then longer
trained programs will see bigger numbers than shorter trained numbers so
perhaps this should be relative to overall running time of the program?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug ipa/103734] IPA-CP opportunity for imagick in SPECCPU 2017
2021-12-15 12:14 [Bug ipa/103734] New: IPA-CP opportunity for imagick in SPECCPU 2017 tnfchris at gcc dot gnu.org
2021-12-15 12:22 ` [Bug ipa/103734] " marxin at gcc dot gnu.org
2021-12-15 12:50 ` hubicka at kam dot mff.cuni.cz
@ 2021-12-16 6:18 ` pinskia at gcc dot gnu.org
2021-12-16 6:37 ` crazylht at gmail dot com
2021-12-17 17:23 ` pthaugen at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-12-16 6:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103734
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |missed-optimization
Severity|normal |enhancement
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug ipa/103734] IPA-CP opportunity for imagick in SPECCPU 2017
2021-12-15 12:14 [Bug ipa/103734] New: IPA-CP opportunity for imagick in SPECCPU 2017 tnfchris at gcc dot gnu.org
` (2 preceding siblings ...)
2021-12-16 6:18 ` pinskia at gcc dot gnu.org
@ 2021-12-16 6:37 ` crazylht at gmail dot com
2021-12-17 17:23 ` pthaugen at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: crazylht at gmail dot com @ 2021-12-16 6:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103734
--- Comment #2 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to Tamar Christina from comment #0)
> When using --param ipa-cp-eval-threshold=1 --param ipa-cp-unit-growth=20 on
> imagick the hot functions MorphologyApply and GetVirtualPixelsFromNexus get
> replaced by specialized versions that are much smaller and faster.
>
> Some other benchmarks like leela also get very small uplifts but the imagick
> one is worth 14%. Both flags seem to be needed.
Observe similar thing on ICX with -param=inline-min-speedup=3
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug ipa/103734] IPA-CP opportunity for imagick in SPECCPU 2017
2021-12-15 12:14 [Bug ipa/103734] New: IPA-CP opportunity for imagick in SPECCPU 2017 tnfchris at gcc dot gnu.org
` (3 preceding siblings ...)
2021-12-16 6:37 ` crazylht at gmail dot com
@ 2021-12-17 17:23 ` pthaugen at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: pthaugen at gcc dot gnu.org @ 2021-12-17 17:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103734
pthaugen at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pthaugen at gcc dot gnu.org
--- Comment #3 from pthaugen at gcc dot gnu.org ---
(In reply to Hongtao.liu from comment #2)
> (In reply to Tamar Christina from comment #0)
> > When using --param ipa-cp-eval-threshold=1 --param ipa-cp-unit-growth=20 on
> > imagick the hot functions MorphologyApply and GetVirtualPixelsFromNexus get
> > replaced by specialized versions that are much smaller and faster.
> >
> > Some other benchmarks like leela also get very small uplifts but the imagick
> > one is worth 14%. Both flags seem to be needed.
>
> Observe similar thing on ICX with -param=inline-min-speedup=3
I tested on a Power9 system and see the following improvements:
--param ipa-cp-eval-threshold=1 --param ipa-cp-unit-growth=20 : +5%
-param=inline-min-speedup=3 : +30%
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-17 17:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 12:14 [Bug ipa/103734] New: IPA-CP opportunity for imagick in SPECCPU 2017 tnfchris at gcc dot gnu.org
2021-12-15 12:22 ` [Bug ipa/103734] " marxin at gcc dot gnu.org
2021-12-15 12:50 ` hubicka at kam dot mff.cuni.cz
2021-12-16 6:18 ` pinskia at gcc dot gnu.org
2021-12-16 6:37 ` crazylht at gmail dot com
2021-12-17 17:23 ` pthaugen at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).