[Bug fortran/103794] New: ICE in gfc_check_reshape, at fortran/check.c:4727

[Bug fortran/103794] New: ICE in gfc_check_reshape, at fortran/check.c:4727

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103794

            Bug ID: 103794
           Summary: ICE in gfc_check_reshape, at fortran/check.c:4727
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to at least r5 :


$ cat z1.f90
program p
   integer, parameter :: a(2) = 2
   print *, reshape([1,2,3], [(a*i, i=1,2)])
end


$ cat z2.f90
program p
   print *, reshape([1,2,3], [([2,2]*i, i=1,2)])
end


$ gfortran-12-20211219 -c z1.f90
f951: internal compiler error: Segmentation fault
0xd6d1ff crash_signal
        ../../gcc/toplev.c:322
0x7739c7 gfc_check_reshape(gfc_expr*, gfc_expr*, gfc_expr*, gfc_expr*)
        ../../gcc/fortran/check.c:4727
0x7b4339 do_check
        ../../gcc/fortran/intrinsic.c:4770
0x7b4339 check_specific
        ../../gcc/fortran/intrinsic.c:4783
0x7bc3a4 gfc_intrinsic_func_interface(gfc_expr*, int)
        ../../gcc/fortran/intrinsic.c:5020
0x81001c resolve_unknown_f
        ../../gcc/fortran/resolve.c:2972
0x81001c resolve_function
        ../../gcc/fortran/resolve.c:3329
0x81001c gfc_resolve_expr(gfc_expr*)
        ../../gcc/fortran/resolve.c:7166
0x8164d4 gfc_resolve_expr(gfc_expr*)
        ../../gcc/fortran/resolve.c:7133
0x8164d4 gfc_resolve_code(gfc_code*, gfc_namespace*)
        ../../gcc/fortran/resolve.c:11923
0x814e8f gfc_resolve_blocks(gfc_code*, gfc_namespace*)
        ../../gcc/fortran/resolve.c:10939
0x8151e8 gfc_resolve_code(gfc_code*, gfc_namespace*)
        ../../gcc/fortran/resolve.c:11913
0x817b27 resolve_codes
        ../../gcc/fortran/resolve.c:17532
0x817bee gfc_resolve(gfc_namespace*)
        ../../gcc/fortran/resolve.c:17567
0x7fff14 resolve_all_program_units
        ../../gcc/fortran/parse.c:6586
0x7fff14 gfc_parse_file()
        ../../gcc/fortran/parse.c:6842
0x84d53f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:216

[Bug fortran/103794] ICE in gfc_check_reshape, at fortran/check.c:4727

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103794

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-12-21
                 CC|                            |anlauf at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from anlauf at gcc dot gnu.org ---
Confirmed.  We're not trying hard enough to simplify constant expressions
involving iterators.

The following fixes the testcases, but may not be the best/generic solution:

diff --git a/gcc/fortran/check.c b/gcc/fortran/check.c
index b4db9337e9f..9f597ccb4b4 100644
--- a/gcc/fortran/check.c
+++ b/gcc/fortran/check.c
@@ -33,6 +33,7 @@ along with GCC; see the file COPYING3.  If not see
 #include "intrinsic.h"
 #include "constructor.h"
 #include "target-memory.h"
+#include "match.h"


 /* Reset a BOZ to a zero value.  This is used to prevent run-on errors
@@ -4721,6 +4722,7 @@ gfc_check_reshape (gfc_expr *source, gfc_expr *shape,
     {
       gfc_expr *e;
       int i, extent;
+      gfc_reduce_init_expr (shape);
       for (i = 0; i < shape_size; ++i)
        {
          e = gfc_constructor_lookup_expr (shape->value.constructor, i);

[Bug fortran/103794] ICE in gfc_check_reshape, at fortran/check.c:4727

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103794

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
           Keywords|                            |wrong-code

--- Comment #2 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2023-May/059317.html

[Bug fortran/103794] ICE in gfc_check_reshape, at fortran/check.c:4727

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103794

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:5fd5d8fb744fd9251d04e4b17d04f2340e6a283b

commit r14-1174-g5fd5d8fb744fd9251d04e4b17d04f2340e6a283b
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Sun May 21 22:25:29 2023 +0200

    Fortran: checking and simplification of RESHAPE intrinsic [PR103794]

    gcc/fortran/ChangeLog:

            PR fortran/103794
            * check.cc (gfc_check_reshape): Expand constant arguments SHAPE and
            ORDER before checking.
            * gfortran.h (gfc_is_constant_array_expr): Add prototype.
            * iresolve.cc (gfc_resolve_reshape): Expand constant argument
SHAPE.
            * simplify.cc (is_constant_array_expr): If array is determined to
be
            constant, expand small array constructors if needed.
            (gfc_is_constant_array_expr): Wrapper for is_constant_array_expr.
            (gfc_simplify_reshape): Fix check for insufficient elements in
SOURCE
            when no padding specified.

    gcc/testsuite/ChangeLog:

            PR fortran/103794
            * gfortran.dg/reshape_10.f90: New test.
            * gfortran.dg/reshape_11.f90: New test.

[Bug fortran/103794] ICE in gfc_check_reshape, at fortran/check.c:4727

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103794

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from anlauf at gcc dot gnu.org ---
Fixed for gcc-14.  Closing.

Thanks for the report!