public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/103842] New: [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand
@ 2021-12-27  9:15 slyfox at gcc dot gnu.org
  2021-12-27  9:26 ` [Bug target/103842] " slyfox at gcc dot gnu.org
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: slyfox at gcc dot gnu.org @ 2021-12-27  9:15 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103842

            Bug ID: 103842
           Summary: [12 regression] ICE on ilmbase-2.5.7: during RTL pass:
                    expand
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: slyfox at gcc dot gnu.org
  Target Milestone: ---
            Target: x86_64-unknown-linux-gnu

Noticed new ICE on this week's gcc snapshot on ilmbase-2.5.7. Here is minimized
source:

    void abs(float *);
    struct Matrix33 {
      float x[3][3];
      float *operator[](int i) { return x[i]; }
      Matrix33();
      Matrix33(float f, float g) {
        x[1][0] = x[1][1] = x[1][2] = f;
        x[2][0] = g;
      }
      void equalWithAbsError();
      Matrix33 inverse() {
        Matrix33 s(x[1][2] - x[1][2], x[1][1] - x[1][1]);
        float r = s[2][0];
        if (r)
          for (int i = 0; i < 3; ++i)
            for (int j = 0; j < 3; ++j)
              s[i][j] /= r;
        for (int i = 0;;) {
          float *__trans_tmp_2 = s[i];
          abs(__trans_tmp_2);
        }
      }
    };
    void __assert_fail() {
      Matrix33 m, inv1 = m.inverse(), ident1 = inv1;
      ident1.equalWithAbsError();
    }

$ g++-12.0.0 -O3 -c bug.cpp.cpp
during RTL pass: expand
bug.cpp.cpp: In function 'void __assert_fail()':
bug.cpp.cpp:27:5: internal compiler error: Segmentation fault
   27 |     }
      |     ^
0x21196c6 internal_error(char const*, ...)
        ???:0

$ g++-12.0.0 -v
Using built-in specs.
COLLECT_GCC=/nix/store/hw64v14l9lzircg596kmj1bjiy76wcih-gcc-12.0.0/bin/g++
COLLECT_LTO_WRAPPER=/nix/store/hw64v14l9lzircg596kmj1bjiy76wcih-gcc-12.0.0/libexec/gcc/x86_64-unknown-linux-gnu/12.0.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with:
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 12.0.0 20211226 (experimental) (GCC)

Also attaching the unminimized preprocessed file in case it introduced
unrelated uninitialized values as `bug.cpp.cpp.orig`.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/103842] [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand
  2021-12-27  9:15 [Bug target/103842] New: [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand slyfox at gcc dot gnu.org
@ 2021-12-27  9:26 ` slyfox at gcc dot gnu.org
  2021-12-27  9:28 ` pinskia at gcc dot gnu.org
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: slyfox at gcc dot gnu.org @ 2021-12-27  9:26 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103842

--- Comment #1 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
Created attachment 52065
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52065&action=edit
bug.cpp.cpp.orig.gz

bug.cpp.cpp.orig.gz - unreduced file (had to compress to get past 1MB limit)

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/103842] [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand
  2021-12-27  9:15 [Bug target/103842] New: [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand slyfox at gcc dot gnu.org
  2021-12-27  9:26 ` [Bug target/103842] " slyfox at gcc dot gnu.org
@ 2021-12-27  9:28 ` pinskia at gcc dot gnu.org
  2021-12-27  9:28 ` pinskia at gcc dot gnu.org
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-12-27  9:28 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103842

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This was exposed/caused by r12-6113 as far as I can tell.
We didn't do SLP of the divide before and now we do and it caused the ICE
somehow.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/103842] [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand
  2021-12-27  9:15 [Bug target/103842] New: [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand slyfox at gcc dot gnu.org
  2021-12-27  9:26 ` [Bug target/103842] " slyfox at gcc dot gnu.org
  2021-12-27  9:28 ` pinskia at gcc dot gnu.org
@ 2021-12-27  9:28 ` pinskia at gcc dot gnu.org
  2021-12-27  9:30 ` pinskia at gcc dot gnu.org
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-12-27  9:28 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103842

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-12-27
           Keywords|                            |ice-on-valid-code
   Target Milestone|---                         |12.0

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/103842] [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand
  2021-12-27  9:15 [Bug target/103842] New: [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand slyfox at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2021-12-27  9:28 ` pinskia at gcc dot gnu.org
@ 2021-12-27  9:30 ` pinskia at gcc dot gnu.org
  2021-12-27  9:34 ` pinskia at gcc dot gnu.org
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-12-27  9:30 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103842

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(insn 56 55 57 (set (subreg:V4SF (reg:V2SF 124 [ vect__35.17 ]) 0)
        (div:V4SF (nil)
            (reg:V4SF 126))) "t.c":18:23 -1
     (nil))

Yes that nill there is wrong.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/103842] [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand
  2021-12-27  9:15 [Bug target/103842] New: [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand slyfox at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2021-12-27  9:30 ` pinskia at gcc dot gnu.org
@ 2021-12-27  9:34 ` pinskia at gcc dot gnu.org
  2021-12-27 10:59 ` jakub at gcc dot gnu.org
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-12-27  9:34 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103842

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(gdb) n
534       rtx op1 = lowpart_subreg (V4SFmode, operands[1],
1: debug_rtx(operands[1]) = (subreg:V2SF (reg:DI 123) 0)
void
(gdb) n
536       rtx op2 = gen_rtx_VEC_CONCAT (V4SFmode, operands[2],
1: debug_rtx(operands[1]) = (subreg:V2SF (reg:DI 123) 0)
void
(gdb) p op1
$7 = (rtx) 0x0

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/103842] [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand
  2021-12-27  9:15 [Bug target/103842] New: [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand slyfox at gcc dot gnu.org
                   ` (4 preceding siblings ...)
  2021-12-27  9:34 ` pinskia at gcc dot gnu.org
@ 2021-12-27 10:59 ` jakub at gcc dot gnu.org
  2021-12-28  7:32 ` ubizjak at gmail dot com
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-12-27 10:59 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103842

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 52068
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52068&action=edit
gcc12-pr103842.patch

Untested fix.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/103842] [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand
  2021-12-27  9:15 [Bug target/103842] New: [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand slyfox at gcc dot gnu.org
                   ` (5 preceding siblings ...)
  2021-12-27 10:59 ` jakub at gcc dot gnu.org
@ 2021-12-28  7:32 ` ubizjak at gmail dot com
  2021-12-28 10:01 ` cvs-commit at gcc dot gnu.org
  2021-12-28 10:03 ` jakub at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: ubizjak at gmail dot com @ 2021-12-28  7:32 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103842

--- Comment #6 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Jakub Jelinek from comment #5)
> Created attachment 52068 [details]
> gcc12-pr103842.patch
> 
> Untested fix.

The patch is OK.

Thanks,
Uros.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/103842] [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand
  2021-12-27  9:15 [Bug target/103842] New: [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand slyfox at gcc dot gnu.org
                   ` (6 preceding siblings ...)
  2021-12-28  7:32 ` ubizjak at gmail dot com
@ 2021-12-28 10:01 ` cvs-commit at gcc dot gnu.org
  2021-12-28 10:03 ` jakub at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-12-28 10:01 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103842

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:242783c52c22ed96eae722b2fa9847711ac84699

commit r12-6129-g242783c52c22ed96eae722b2fa9847711ac84699
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Dec 28 10:58:43 2021 +0100

    i386: Fix handling of SUBREGs in divv2sf3 [PR103842]

    register_operand predicate allows not just REGs, but also SUBREGs of REGs,
    and for the latter lowpart_subreg might FAIL when trying to create
paradoxical
    SUBREG in some cases.  For the input operand fixed by force_reg on it
first,
    for the output operand handled by always dividing into a fresh V4SFmode
temporary
    and emit_move_insn into the destination afterwards, that is also beneficial
for
    combine.

    2021-12-28  Jakub Jelinek  <jakub@redhat.com>

            PR target/103842
            * config/i386/mmx.md (divv2sf3): Use force_reg on op1.  Always
perform
            divv4sf3 into a pseudo and emit_move_insn into operands[0].

            * g++.dg/opt/pr103842.C: New test.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/103842] [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand
  2021-12-27  9:15 [Bug target/103842] New: [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand slyfox at gcc dot gnu.org
                   ` (7 preceding siblings ...)
  2021-12-28 10:01 ` cvs-commit at gcc dot gnu.org
@ 2021-12-28 10:03 ` jakub at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-12-28 10:03 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103842

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-12-28 10:03 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-27  9:15 [Bug target/103842] New: [12 regression] ICE on ilmbase-2.5.7: during RTL pass: expand slyfox at gcc dot gnu.org
2021-12-27  9:26 ` [Bug target/103842] " slyfox at gcc dot gnu.org
2021-12-27  9:28 ` pinskia at gcc dot gnu.org
2021-12-27  9:28 ` pinskia at gcc dot gnu.org
2021-12-27  9:30 ` pinskia at gcc dot gnu.org
2021-12-27  9:34 ` pinskia at gcc dot gnu.org
2021-12-27 10:59 ` jakub at gcc dot gnu.org
2021-12-28  7:32 ` ubizjak at gmail dot com
2021-12-28 10:01 ` cvs-commit at gcc dot gnu.org
2021-12-28 10:03 ` jakub at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).