[Bug rtl-optimization/103900] New: ICE: in expand_expr_real_2, at expr.c:9771 with -O -fno-tree-dce -fno-tree-dse

[Bug rtl-optimization/103900] New: ICE: in expand_expr_real_2, at expr.c:9771 with -O -fno-tree-dce -fno-tree-dse

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103900

            Bug ID: 103900
           Summary: ICE: in expand_expr_real_2, at expr.c:9771 with -O
                    -fno-tree-dce -fno-tree-dse
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 52115
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52115&action=edit
auto-reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc -O -fno-tree-dce -fno-tree-dse testcase.c 
during RTL pass: expand
testcase.c: In function 'foo0':
testcase.c:11:1: internal compiler error: in expand_expr_real_2, at expr.c:9771
   11 | foo0() {
      | ^~~~
0x6c4ecd expand_expr_real_2(separate_ops*, rtx_def*, machine_mode,
expand_modifier)
        /repo/gcc-trunk/gcc/expr.c:9771
0xe66f8f expand_gimple_stmt_1
        /repo/gcc-trunk/gcc/cfgexpand.c:3967
0xe66f8f expand_gimple_stmt
        /repo/gcc-trunk/gcc/cfgexpand.c:4028
0xe6cd18 expand_gimple_basic_block
        /repo/gcc-trunk/gcc/cfgexpand.c:6069
0xe6eea7 execute
        /repo/gcc-trunk/gcc/cfgexpand.c:6795
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r12-6199-20220104114958-g05da96886ef-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/12.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r12-6199-20220104114958-g05da96886ef-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.0.0 20220104 (experimental) (GCC)

[Bug rtl-optimization/103900] [12 Regression] ICE: in expand_expr_real_2, at expr.c:9771 with -O -fno-tree-dce -fno-tree-dse since r12-6173-g9ff206d3865df5cb

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103900

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-01-04
   Target Milestone|---                         |12.0
             Status|UNCONFIRMED                 |NEW
            Summary|ICE: in expand_expr_real_2, |[12 Regression] ICE: in
                   |at expr.c:9771 with -O      |expand_expr_real_2, at
                   |-fno-tree-dce -fno-tree-dse |expr.c:9771 with -O
                   |                            |-fno-tree-dce -fno-tree-dse
                   |                            |since
                   |                            |r12-6173-g9ff206d3865df5cb
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |uros at gcc dot gnu.org
           Priority|P3                          |P1

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-6173-g9ff206d3865df5cb.

[Bug target/103900] [12 Regression] ICE: in expand_expr_real_2, at expr.c:9771 with -O -fno-tree-dce -fno-tree-dse since r12-6173-g9ff206d3865df5cb

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103900

--- Comment #2 from Uroš Bizjak <ubizjak at gmail dot com> ---
Looks fixed, does not ICE for me with:

GNU C17 (GCC) version 12.0.0 20220104 (experimental) [master
r12-6200-g62c8b21d48a] (x86_64-pc-linux-gnu)

[Bug target/103900] [12 Regression] ICE: in expand_expr_real_2, at expr.c:9771 with -O -fno-tree-dce -fno-tree-dse since r12-6173-g9ff206d3865df5cb

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103900

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Uroš Bizjak from comment #2)
> Looks fixed, does not ICE for me with:

Maybe the fix for PR 103895 fixed this one also.

[Bug target/103900] [12 Regression] ICE: in expand_expr_real_2, at expr.c:9771 with -O -fno-tree-dce -fno-tree-dse since r12-6173-g9ff206d3865df5cb

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103900

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Uroš Bizjak from comment #2)
> Looks fixed, does not ICE for me with:
> 
> GNU C17 (GCC) version 12.0.0 20220104 (experimental) [master
> r12-6200-g62c8b21d48a] (x86_64-pc-linux-gnu)

Or rather it is the RTL checking which is causing the extra assert fail.

[Bug target/103900] [12 Regression] ICE: in expand_expr_real_2, at expr.c:9771 with -O -fno-tree-dce -fno-tree-dse since r12-6173-g9ff206d3865df5cb

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103900

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
No, it still crashes with the current master (g:fbb592407c9):

$ gcc pr103900.c -c -O -fno-tree-dce -fno-tree-dse --save-temps --verbose
Using built-in specs.
COLLECT_GCC=gcc
Target: x86_64-pc-linux-gnu
Configured with: /home/marxin/Programming/gcc/configure
--enable-languages=c,c++,fortran,jit --prefix=/home/marxin/bin/gcc
--disable-multilib --enable-host-shared --disable-libsanitizer
--enable-valgrind-annotations --disable-bootstrap
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.0.0 20220104 (experimental) (GCC) 
COLLECT_GCC_OPTIONS='-c' '-O' '-fno-tree-dce' '-fno-tree-dse' '-save-temps'
'-v' '-mtune=generic' '-march=x86-64'
 /home/marxin/bin/gcc/libexec/gcc/x86_64-pc-linux-gnu/12.0.0/cc1 -E -quiet -v
pr103900.c -mtune=generic -march=x86-64 -fno-tree-dce -fno-tree-dse -O
-fpch-preprocess -o pr103900.i
ignoring nonexistent directory
"/home/marxin/bin/gcc/lib64/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../x86_64-pc-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:
 /home/marxin/bin/gcc/lib64/gcc/x86_64-pc-linux-gnu/12.0.0/include
 /usr/local/include
 /home/marxin/bin/gcc/include
 /home/marxin/bin/gcc/lib64/gcc/x86_64-pc-linux-gnu/12.0.0/include-fixed
 /usr/include
End of search list.
COLLECT_GCC_OPTIONS='-c' '-O' '-fno-tree-dce' '-fno-tree-dse' '-save-temps'
'-v' '-mtune=generic' '-march=x86-64'
 /home/marxin/bin/gcc/libexec/gcc/x86_64-pc-linux-gnu/12.0.0/cc1 -fpreprocessed
pr103900.i -quiet -dumpbase pr103900.c -dumpbase-ext .c -mtune=generic
-march=x86-64 -O -version -fno-tree-dce -fno-tree-dse -o pr103900.s
GNU C17 (GCC) version 12.0.0 20220104 (experimental) (x86_64-pc-linux-gnu)
        compiled by GNU C version 11.2.1 20211124 [revision
7510c23c1ec53aa4a62705f0384079661342ff7b], GMP version 6.2.1, MPFR version
4.1.0-p7, MPC version 1.2.1, isl version isl-0.24-GMP

GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
GNU C17 (GCC) version 12.0.0 20220104 (experimental) (x86_64-pc-linux-gnu)
        compiled by GNU C version 11.2.1 20211124 [revision
7510c23c1ec53aa4a62705f0384079661342ff7b], GMP version 6.2.1, MPFR version
4.1.0-p7, MPC version 1.2.1, isl version isl-0.24-GMP

GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: c265fe5ba5ef24bee29b1830921bb05e
during RTL pass: expand
pr103900.c: In function ‘foo0’:
pr103900.c:11:1: internal compiler error: in expand_expr_real_2, at expr.c:9771
   11 | foo0() {
      | ^~~~
0x6e2341 expand_expr_real_2(separate_ops*, rtx_def*, machine_mode,
expand_modifier)
        /home/marxin/Programming/gcc/gcc/expr.c:9771
0xa3bf75 expand_gimple_stmt_1
        /home/marxin/Programming/gcc/gcc/cfgexpand.c:3967
0xa3bf75 expand_gimple_stmt
        /home/marxin/Programming/gcc/gcc/cfgexpand.c:4028
0xa41dac expand_gimple_basic_block
        /home/marxin/Programming/gcc/gcc/cfgexpand.c:6069
0xa43f77 execute
        /home/marxin/Programming/gcc/gcc/cfgexpand.c:6795
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug target/103900] [12 Regression] ICE: in expand_expr_real_2, at expr.c:9771 with -O -fno-tree-dce -fno-tree-dse since r12-6173-g9ff206d3865df5cb

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103900

--- Comment #6 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Martin Liška from comment #5)
> No, it still crashes with the current master (g:fbb592407c9):

Ah, the compiler is blindly trying to generate V2QI XOR due to missing
one_cmplv2qi2 pattern. I have a patch that implements V2QI logic insns that
fixes the ICE.

[Bug target/103900] [12 Regression] ICE: in expand_expr_real_2, at expr.c:9771 with -O -fno-tree-dce -fno-tree-dse since r12-6173-g9ff206d3865df5cb

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103900

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |ubizjak at gmail dot com
             Status|NEW                         |ASSIGNED

--- Comment #7 from Uroš Bizjak <ubizjak at gmail dot com> ---
Created attachment 52117
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52117&action=edit
Patch that implements v2qi logic insns

[Bug target/103900] [12 Regression] ICE: in expand_expr_real_2, at expr.c:9771 with -O -fno-tree-dce -fno-tree-dse since r12-6173-g9ff206d3865df5cb

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103900

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Uros Bizjak <uros@gcc.gnu.org>:

https://gcc.gnu.org/g:708b87dcb6e48cb48d170a4b3625088995377a5c

commit r12-6215-g708b87dcb6e48cb48d170a4b3625088995377a5c
Author: Uros Bizjak <ubizjak@gmail.com>
Date:   Tue Jan 4 19:41:47 2022 +0100

    i386: Introduce V2QImode vectorized logic [PR103861]

    Add V2QImode logic operations with SSE and GP registers and split
    them to V4QImode SSE instructions or SImode GP instructions.

    The patch also fixes PR target/103900.

    2022-01-04  Uroš Bizjak  <ubizjak@gmail.com>

    gcc/ChangeLog:

            PR target/103861
            * config/i386/mmx.md (one_cmplv2qi3): New insn pattern.
            (one_cmplv2qi3 splitters): New post-reload splitters.
            (*andnotv2qi3): New insn pattern.
            (andnotv2qi3 splitters): New post-reload splitters.
            (<any_logic:code>v2qi3): New insn pattern.
            (<any_logic:insn>v2qi3 splitters): New post-reload splitters.

    gcc/testsuite/ChangeLog:

            PR target/103861
            * gcc.target/i386/warn-vect-op-2.c: Adjust warnings.
            * gcc.target/i386/pr103900.c: New test.

[Bug target/103900] [12 Regression] ICE: in expand_expr_real_2, at expr.c:9771 with -O -fno-tree-dce -fno-tree-dse since r12-6173-g9ff206d3865df5cb

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103900

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed.