public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "anlauf at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/103931] Type name "c_ptr" is ambiguous when iso_c_binding is imported both directly and indirectly Date: Mon, 24 Apr 2023 20:14:01 +0000 [thread overview] Message-ID: <bug-103931-4-GiBwLj0fc2@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-103931-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103931 anlauf at gcc dot gnu.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anlauf at gcc dot gnu.org --- Comment #19 from anlauf at gcc dot gnu.org --- (In reply to Bernhard Reutner-Fischer from comment #18) > (In reply to Bernhard Reutner-Fischer from comment #17) > > (In reply to Bernhard Reutner-Fischer from comment #16) > We can just mark the dt symbol (which is used to describe the generic > interface) as attr.generic = 1 > > This regtests cleanly and fixes the reported bug. > > > diff --git a/gcc/fortran/symbol.cc b/gcc/fortran/symbol.cc > index 221165d6dac..28ed1a32b9e 100644 > --- a/gcc/fortran/symbol.cc > +++ b/gcc/fortran/symbol.cc > @@ -4977,6 +4986,10 @@ generate_isocbinding_symbol (const char *mod_name, > iso_c_binding_symbol s, > if (!tmp_sym->attr.function > && !gfc_add_function (&tmp_sym->attr, tmp_sym->name, NULL)) > return NULL; > + > + /* Mark the derived-type symbol in the generic interface > + as generic. */ > + dt_sym->attr.generic = 1; > } > > /* Say what module this symbol belongs to. */ > > > i.e. it marks the dt as GENERIC, so the gmodule contents from comment #16 > become I have reduced the failing version further for easier debugging (it still fails on 14-trunk and on 13-branch) to the following: module AModule use, intrinsic :: ISO_C_BINDING, only: C_PTR end module module DModule type, abstract :: DType end type end module module FModule use AModule use DModule implicit none public :: FProc private contains subroutine FProc(x) class(DType), allocatable, intent(out) :: x end subroutine end module module GModule use AModule end module module HModule use FModule use, intrinsic :: ISO_C_BINDING, only: C_PTR use GModule implicit none type(C_PTR) :: context end module I think I agree more with your thoughts in comment#16 than comment#18: the symbol C_PTR is erroneously marked as ambiguous in module reading, but for the wrong reason. C_PTR is an intrinsic DT and not a procedure; so we should not mark it as "generic". As long as a symbol from an *intrinsic module* is use-associated - either directly or indirectly - the conflict check could trace it down to its origin (in case it is renamed), and we would resolve this explicitly. I haven't checked the standard about possible issues coming with renaming; I should do that now..
next prev parent reply other threads:[~2023-04-24 20:14 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-06 15:39 [Bug fortran/103931] New: " trnka at scm dot com 2022-01-06 16:55 ` [Bug fortran/103931] " marxin at gcc dot gnu.org 2022-01-06 21:40 ` anlauf at gcc dot gnu.org 2022-01-06 22:38 ` pinskia at gcc dot gnu.org 2022-01-06 22:42 ` pinskia at gcc dot gnu.org 2022-01-06 22:50 ` trnka at scm dot com 2022-01-06 22:54 ` pinskia at gcc dot gnu.org 2022-01-06 22:55 ` pinskia at gcc dot gnu.org 2022-01-07 7:03 ` marxin at gcc dot gnu.org 2023-03-31 20:12 ` anlauf at gcc dot gnu.org 2023-04-01 19:50 ` aldot at gcc dot gnu.org 2023-04-02 15:54 ` aldot at gcc dot gnu.org 2023-04-02 18:59 ` anlauf at gcc dot gnu.org 2023-04-12 17:20 ` aldot at gcc dot gnu.org 2023-04-12 18:56 ` anlauf at gcc dot gnu.org 2023-04-13 19:59 ` aldot at gcc dot gnu.org 2023-04-14 17:21 ` aldot at gcc dot gnu.org 2023-04-24 16:17 ` aldot at gcc dot gnu.org 2023-04-24 16:29 ` aldot at gcc dot gnu.org 2023-04-24 20:14 ` anlauf at gcc dot gnu.org [this message] 2023-04-25 18:16 ` anlauf at gcc dot gnu.org 2023-04-25 18:46 ` aldot at gcc dot gnu.org 2023-04-25 19:03 ` anlauf at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-103931-4-GiBwLj0fc2@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).