[Bug testsuite/104022] New: g++.dg/gcov/pr16855.C does not precleanup upon failures

[Bug testsuite/104022] New: g++.dg/gcov/pr16855.C does not precleanup upon failures

[rimvydas.jas at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104022

            Bug ID: 104022
           Summary: g++.dg/gcov/pr16855.C does not precleanup upon
                    failures
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rimvydas.jas at gmail dot com
  Target Milestone: ---

Created attachment 52186
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52186&action=edit
xfails

Testsuite on x86_64-*-dragonfly gives:

$ gmake check-gcc-c++ -k RUNTESTFLAGS="gcov.exp=pr16855*"
FAIL: g++.dg/gcov/pr16855-priority.C  -std=gnu++98  line 14: is 5:should be 1
FAIL: g++.dg/gcov/pr16855-priority.C  -std=gnu++98  line 21: is 5:should be 1
FAIL: g++.dg/gcov/pr16855-priority.C  -std=gnu++98  line 22: is #####:should be
1
FAIL: g++.dg/gcov/pr16855-priority.C  -std=gnu++98  line 35: is 5:should be 1
FAIL: g++.dg/gcov/pr16855-priority.C  -std=gnu++98  line 41: is 5:should be 1
FAIL: g++.dg/gcov/pr16855-priority.C  -std=gnu++98  line 46: is 5:should be 1
FAIL: g++.dg/gcov/pr16855-priority.C  -std=gnu++98  line 51: is 5:should be 1
FAIL: g++.dg/gcov/pr16855-priority.C  -std=gnu++98  line 56: is 5:should be 1
FAIL: g++.dg/gcov/pr16855-priority.C  -std=gnu++98  line 61: is 5:should be 1
FAIL: g++.dg/gcov/pr16855-priority.C  -std=gnu++98  line 66: is 5:should be 1
FAIL: g++.dg/gcov/pr16855-priority.C  -std=gnu++98  line 71: is 5:should be 1
FAIL: g++.dg/gcov/pr16855-priority.C  -std=gnu++98  line 76: is 5:should be 1
FAIL: g++.dg/gcov/pr16855-priority.C  -std=gnu++98  gcov: 12 failures in line
counts, 0 in branch percentages, 0 in return percentages, 0 in intermediate
format
[SNIP]
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++98  line 15: is 5:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++98  line 22: is 5:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++98  line 24: is #####:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++98  line 38: is 5:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++98  line 44: is 5:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++98  line 49: is 5:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++98  gcov: 6 failures in line counts, 0
in branch percentages, 0 in return percentages, 0 in intermediate format
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++14  line 15: is 6:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++14  line 22: is 6:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++14  line 24: is #####:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++14  line 38: is 6:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++14  line 44: is 6:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++14  line 49: is 6:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++14  gcov: 6 failures in line counts, 0
in branch percentages, 0 in return percentages, 0 in intermediate format
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++17  line 15: is 7:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++17  line 22: is 7:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++17  line 24: is #####:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++17  line 38: is 7:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++17  line 44: is 7:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++17  line 49: is 7:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++17  gcov: 6 failures in line counts, 0
in branch percentages, 0 in return percentages, 0 in intermediate format
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++2a  line 15: is 8:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++2a  line 22: is 8:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++2a  line 24: is #####:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++2a  line 38: is 8:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++2a  line 44: is 8:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++2a  line 49: is 8:should be 1
FAIL: g++.dg/gcov/pr16855.C  -std=gnu++2a  gcov: 6 failures in line counts, 0
in branch percentages, 0 in return percentages, 0 in intermediate format

                === g++ Summary ===

# of expected passes            24
# of unexpected failures        80
/build/trunk/gcc/xg++  version 12.0.0 20220114 (experimental)
[remotes/origin/master -gb31cec9c22b] (GCC)

Line counts are incrementing with every check command invoke. Adding missing
xfails avoids the issue.
$ gmake check-gcc-c++ -k RUNTESTFLAGS="gcov.exp=pr16855*"
                === g++ Summary ===

# of expected passes            88
# of expected failures          16

The "line 24: is #####:should be 1" is a known issue on DragonFly BSD, the
dynamic linker on dso stops profiling before destructor is executed.
Alternatively adding "/* { dg-additional-options "-static" { target
*-*-dragonfly* } } */" directives to both tests allows them to pass fully.
# of expected passes            104

[Bug testsuite/104022] g++.dg/gcov/pr16855.C does not precleanup upon failures

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104022

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-01-14
     Ever confirmed|0                           |1

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
The patch is pre-approved, please commit it.

[Bug testsuite/104022] g++.dg/gcov/pr16855.C does not precleanup upon failures

[rimvydas.jas at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104022

--- Comment #2 from Rimvydas (RJ) <rimvydas.jas at gmail dot com> ---
Created attachment 52224
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52224&action=edit
proposed patch

I do not have write access.  Would Signed-off-by version be OK?

[Bug testsuite/104022] g++.dg/gcov/pr16855.C does not precleanup upon failures

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104022

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:32657045bd28f7d35c9b814d8b338c21e4f5dc40

commit r12-6719-g32657045bd28f7d35c9b814d8b338c21e4f5dc40
Author: Rimvydas Jasinskas <rimvydas.jas@gmail.com>
Date:   Tue Jan 18 06:12:45 2022 +0000

    Add XFAIL parts of pr16855.C for dragonfly.

    On DragonFly BSD profiling ends before these DTORs are invoked on dso
cleanup.
    The -static compilation works as expected.

    gcc/testsuite/ChangeLog:

            PR testsuite/104022
            * g++.dg/gcov/pr16855.C: xfail the count lines for DTORs on
dragonfly.
            * g++.dg/gcov/pr16855-priority.C: Ditto.  Adjust source layout so
that
            dejagnu xfail expressions work.

    Signed-off-by: Rimvydas Jasinskas <rimvydas.jas@gmail.com>

[Bug testsuite/104022] g++.dg/gcov/pr16855.C does not precleanup upon failures

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104022

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Rimvydas (RJ) from comment #2)
> Created attachment 52224 [details]
> proposed patch
> 
> I do not have write access.  Would Signed-off-by version be OK?

Sure, I've just installed that on your behalf.

[Bug testsuite/104022] g++.dg/gcov/pr16855.C does not precleanup upon failures

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104022

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed now.