[Bug jit/104072] New: Register variables in libgccjit

[Bug jit/104072] New: Register variables in libgccjit

[bouanto at zoho dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104072

            Bug ID: 104072
           Summary: Register variables in libgccjit
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: jit
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: bouanto at zoho dot com
  Target Milestone: ---

Hi.
I'm opening this issue to track my upcoming patch adding support for register
variables in libgccjit.

[Bug jit/104072] Register variables in libgccjit

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104072

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:5780ff348ad4430383fd67c6f0c572d8c3e721ad

commit r12-8118-g5780ff348ad4430383fd67c6f0c572d8c3e721ad
Author: Antoni Boucher <bouanto@zoho.com>
Date:   Tue Apr 12 17:20:30 2022 -0400

    libgccjit: Add support for register variables [PR104072]

    gcc/jit/
            PR jit/104072
            * docs/_build/texinfo/libgccjit.texi: Regenerate.
            * docs/topics/compatibility.rst (LIBGCCJIT_ABI_22): New ABI tag.
            * docs/topics/expressions.rst: Add documentation for the
            function gcc_jit_lvalue_set_register_name.
            * jit-playback.h: New function (set_register_name).
            * jit-recording.cc: New function (set_register_name) and add
            support for register variables.
            * jit-recording.h: New field (m_reg_name) and new function
            (set_register_name).
            * libgccjit.cc: New function (gcc_jit_lvalue_set_register_name).
            * libgccjit.h: New function (gcc_jit_lvalue_set_register_name).
            * libgccjit.map (LIBGCCJIT_ABI_22): New ABI tag.

    gcc/
            PR jit/104072
            * reginfo.cc: New functions (clear_global_regs_cache,
            reginfo_cc_finalize) to avoid an issue where compiling the same
            code multiple times gives an error about assigning the same
            register to 2 global variables.
            * rtl.h: New function (reginfo_cc_finalize).
            * toplev.cc: Call it.

    gcc/testsuite/
            PR jit/104072
            * jit.dg/all-non-failing-tests.h: Add new
            test-register-variable.
            * jit.dg/harness.h: Add -fdiagnostics-color=never to context's
            command-line options.
            * jit.dg/test-error-register-variable-bad-name.c: New test.
            * jit.dg/test-error-register-variable-size-mismatch.c: New test.
            * jit.dg/test-register-variable.c: New test.

[Bug jit/104072] Register variables in libgccjit

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104072

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Marking as resolved; please reopen if there's an issue integrating the version
of the patch I committed with rustc_codegen_gcc.

[Bug jit/104072] Register variables in libgccjit

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104072

--- Comment #3 from Andreas Schwab <schwab@linux-m68k.org> ---
FAIL: test-error-register-variable-size-mismatch.c.exe iteration 1 of 5:
verify_code: actual: "invalid register name for 'global_variable'" != expected:
"data type of 'global_variable' isn't suitable for a register"

[Bug jit/104072] Register variables in libgccjit

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104072

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andreas Schwab from comment #3)
> FAIL: test-error-register-variable-size-mismatch.c.exe iteration 1 of 5:
> verify_code: actual: "invalid register name for 'global_variable'" !=
> expected: "data type of 'global_variable' isn't suitable for a register"

Yes looks like a testcase issue. What target is from? r12 is sometimes a valid
register name but not always.