[Bug libstdc++/104080] New: [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[Bug libstdc++/104080] New: [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104080

            Bug ID: 104080
           Summary: [12 Regression] newlib doesn't have endian.h causing
                    build failure with 2800bc08e4ab r12-6646
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hp at gcc dot gnu.org
                CC: ppalka at gcc dot gnu.org
  Target Milestone: ---
            Target: cris-elf

With a commit in the range a81f6092350c..490e23032baa, most likely 2800bc08e4ab
a.k.a. r12-6646, newlib targets such as cris-elf has started failing at build
time of libstdc++ thus:

make[5]: Entering directory '/X-obj/cris-elf/libstdc++-v3/src/c++17'
/bin/sh ../../libtool --tag CXX --tag disable-shared   --mode=compile
/X-obj/./gcc/xgcc -shared-libgcc -B/X-obj/./gcc -nostdinc++
-L/X-obj/cris-elf/libstdc++-v3/src -L/X-obj/cris-elf/libstdc++-v3/src/.libs
-L/X-obj/cris-elf/libstdc++-v3/libsupc++/.libs -nostdinc
-B/X-obj/cris-elf/newlib/ -isystem /X-obj/cris-elf/newlib/targ-include -isystem
/X-gccsrc/newlib/libc/include -B/X-obj/cris-elf/libgloss/cris
-L/X-obj/cris-elf/libgloss/libnosys -L/X-gccsrc/libgloss/cris
-B/X/pre/cris-elf/bin/ -B/X/pre/cris-elf/lib/ -isystem /X/pre/cris-elf/include
-isystem /X/pre/cris-elf/sys-include    -I/X-gccsrc/libstdc++-v3/../libgcc
-I/X-obj/cris-elf/libstdc++-v3/include/cris-elf
-I/X-obj/cris-elf/libstdc++-v3/include -I/X-gccsrc/libstdc++-v3/libsupc++  
-std=gnu++17 -nostdinc++   -fno-implicit-templates  -Wall -Wextra
-Wwrite-strings -Wcast-qual -Wabi=2  -fdiagnostics-show-location=once  
-ffunction-sections -fdata-sections  -frandom-seed=floating_from_chars.lo 
-fimplicit-templates -g -O2  -c -o floating_from_chars.lo
/X-gccsrc/libstdc++-v3/src/c++17/floating_from_chars.cc
libtool: compile:  /X-obj/./gcc/xgcc -shared-libgcc -B/X-obj/./gcc -nostdinc++
-L/X-obj/cris-elf/libstdc++-v3/src -L/X-obj/cris-elf/libstdc++-v3/src/.libs
-L/X-obj/cris-elf/libstdc++-v3/libsupc++/.libs -nostdinc
-B/X-obj/cris-elf/newlib/ -isystem /X-obj/cris-elf/newlib/targ-include -isystem
/X-gccsrc/newlib/libc/include -B/X-obj/cris-elf/libgloss/cris
-L/X-obj/cris-elf/libgloss/libnosys -L/X-gccsrc/libgloss/cris
-B/X/pre/cris-elf/bin/ -B/X/pre/cris-elf/lib/ -isystem /X/pre/cris-elf/include
-isystem /X/pre/cris-elf/sys-include -I/X-gccsrc/libstdc++-v3/../libgcc
-I/X-obj/cris-elf/libstdc++-v3/include/cris-elf
-I/X-obj/cris-elf/libstdc++-v3/include -I/X-gccsrc/libstdc++-v3/libsupc++
-std=gnu++17 -nostdinc++ -fno-implicit-templates -Wall -Wextra -Wwrite-strings
-Wcast-qual -Wabi=2 -fdiagnostics-show-location=once -ffunction-sections
-fdata-sections -frandom-seed=floating_from_chars.lo -fimplicit-templates -g
-O2 -c /X-gccsrc/libstdc++-v3/src/c++17/floating_from_chars.cc -o
floating_from_chars.o
In file included from
/X-gccsrc/libstdc++-v3/src/c++17/floating_from_chars.cc:65:
/X-gccsrc/libstdc++-v3/src/c++17/fast_float/fast_float.h:139:10: fatal error:
endian.h: No such file or directory
  139 | #include <endian.h>
      |          ^~~~~~~~~~
compilation terminated.
make[5]: *** [Makefile:585: floating_from_chars.lo] Error 1
make[5]: Leaving directory '/X-obj/cris-elf/libstdc++-v3/src/c++17'

Newlib doesn't have endian.h, but it does have machine/endian.h.
An obvious patch is being tested.

[Bug libstdc++/104080] [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104080

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-01-18
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

[Bug libstdc++/104080] [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104080

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |hp at gcc dot gnu.org

--- Comment #1 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
I'm testing an obvious patch.

[Bug libstdc++/104080] [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104080

--- Comment #2 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Created attachment 52215
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52215&action=edit
patch for endian.h issue

This patch is not sufficient: after this, I get:
libtool: compile:  /X-obj/./gcc/xgcc -shared-libgcc -B/X-obj/./gcc -nostdinc++
-L/X-obj/cris-elf/libstdc++-v3/src -L/X-obj/cris-elf/libstdc++-v3/src/.libs
-L/X-obj/cris-elf/libstdc++-v3/libsupc++/.libs -nostdinc
-B/X-obj/cris-elf/newlib/ -isystem /X-obj/cris-elf/newlib/targ-include -isystem
/X-gccsrc/newlib/libc/include -B/X-obj/cris-elf/libgloss/cris
-L/X-obj/cris-elf/libgloss/libnosys -L/X-gccsrc/libgloss/cris
-B/mnt/storage0/hp/tmpdir/break22017-1/pre/cris-elf/bin/
-B/mnt/storage0/hp/tmpdir/break22017-1/pre/cris-elf/lib/ -isystem
/mnt/storage0/hp/tmpdir/break22017-1/pre/cris-elf/include -isystem
/mnt/storage0/hp/tmpdir/break22017-1/pre/cris-elf/sys-include
-I/X-gccsrc/libstdc++-v3/../libgcc
-I/X-obj/cris-elf/libstdc++-v3/include/cris-elf
-I/X-obj/cris-elf/libstdc++-v3/include -I/X-gccsrc/libstdc++-v3/libsupc++
-std=gnu++17 -nostdinc++ -fno-implicit-templates -Wall -Wextra -Wwrite-strings
-Wcast-qual -Wabi=2 -fdiagnostics-show-location=once -ffunction-sections
-fdata-sections -frandom-seed=floating_from_chars.lo -fimplicit-templates -g
-O2 -c /X-gccsrc/libstdc++-v3/src/c++17/floating_from_chars.cc -o
floating_from_chars.o
In file included from
/X-gccsrc/libstdc++-v3/src/c++17/floating_from_chars.cc:65:
/X-gccsrc/libstdc++-v3/src/c++17/fast_float/fast_float.h: In function 'void
{anonymous}::fast_float::round(adjusted_mantissa&, callback)':
/X-gccsrc/libstdc++-v3/src/c++17/fast_float/fast_float.h:2469:20: error: no
matching function for call to 'min(int32_t&, int)'
 2469 |     cb(am, std::min(shift, 64));
      |            ~~~~~~~~^~~~~~~~~~~
In file included from /X-obj/cris-elf/libstdc++-v3/include/string:50,
                 from
/X-gccsrc/libstdc++-v3/src/c++17/floating_from_chars.cc:35:
/X-obj/cris-elf/libstdc++-v3/include/bits/stl_algobase.h:230:5: note:
candidate: 'template<class _Tp> constexpr const _Tp& std::min(const _Tp&, const
_Tp&)'
  230 |     min(const _Tp& __a, const _Tp& __b)
      |     ^~~
/X-obj/cris-elf/libstdc++-v3/include/bits/stl_algobase.h:230:5: note:  
template argument deduction/substitution failed:
/X-gccsrc/libstdc++-v3/src/c++17/fast_float/fast_float.h:2469:20: note:  
deduced conflicting types for parameter 'const _Tp' ('long int' and 'int')
 2469 |     cb(am, std::min(shift, 64));
      |            ~~~~~~~~^~~~~~~~~~~
/X-obj/cris-elf/libstdc++-v3/include/bits/stl_algobase.h:278:5: note:
candidate: 'template<class _Tp, class _Compare> constexpr const _Tp&
std::min(const _Tp&, const _Tp&, _Compare)'
  278 |     min(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
/X-obj/cris-elf/libstdc++-v3/include/bits/stl_algobase.h:278:5: note:  
template argument deduction/substitution failed:
/X-gccsrc/libstdc++-v3/src/c++17/fast_float/fast_float.h:2469:20: note:  
deduced conflicting types for parameter 'const _Tp' ('long int' and 'int')
 2469 |     cb(am, std::min(shift, 64));
      |            ~~~~~~~~^~~~~~~~~~~
make[5]: *** [Makefile:585: floating_from_chars.lo] Error 1
make[5]: Leaving directory '/X-obj/cris-elf/libstdc++-v3/src/c++17'

This is likely the usual size_t mismatch.  Unassigning myself.

[Bug libstdc++/104080] [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104080

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

[Bug libstdc++/104080] [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104080

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
   Target Milestone|---                         |12.0

[Bug libstdc++/104080] [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[pexu@gcc-bugzilla.mail.kapsi.fi]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104080

Pekka S <pexu@gcc-bugzilla.mail.kapsi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pexu@gcc-bugzilla.mail.kaps
                   |                            |i.fi

--- Comment #3 from Pekka S <pexu@gcc-bugzilla.mail.kapsi.fi> ---
Created attachment 52216
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52216&action=edit
Fix compile issue with newlib

A further improved patch.  Simply does an explicit cast following the style of
the library; int32_t(64).  With the patch compiles for target AArch64
LP64/ILP32, not tested otherwise.

[Bug libstdc++/104080] [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104080

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
It would be better to use __has_include to detect headers, not hardcoding it
based on target macros. But I don't see why we need that header anyway, GCC
defines __BYTE_ORDER__ and __ORDER_LITTLE_ENDIAN__ without any headers. We
should just rip that piece of fast_float out.

[Bug libstdc++/104080] [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104080

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|hp at gcc dot gnu.org              |redi at gcc dot gnu.org

[Bug libstdc++/104080] [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104080

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:97b9236976a4914d268089613d1fb42ece34aff9

commit r12-6664-g97b9236976a4914d268089613d1fb42ece34aff9
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Jan 18 09:46:16 2022 +0000

    libstdc++: Fix deduction failure for std::min call [PR104080]

    libstdc++-v3/ChangeLog:

            PR libstdc++/104080
            * src/c++17/fast_float/LOCAL_PATCHES: UPDATE.
            * src/c++17/fast_float/fast_float.h (round): Use explicit
            template argument list for std::min.

[Bug libstdc++/104080] [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104080

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:8f6b62e0f0c99e421d07bf1847259744db22924b

commit r12-6665-g8f6b62e0f0c99e421d07bf1847259744db22924b
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Jan 18 10:01:23 2022 +0000

    libstdc++: Use GCC's predefined macro for endianness [PR104080]

    Instead of hardcoded preprocessor conditionals with explicit target
    checks, just rely on the fact that __BYTE_ORDER__ is always defined by
    GCC.

    libstdc++-v3/ChangeLog:

            PR libstdc++/104080
            * src/c++17/fast_float/LOCAL_PATCHES: Update.
            * src/c++17/fast_float/fast_float.h (FASTFLOAT_IS_BIG_ENDIAN):
            Define in terms of __BYTE_ORDER__.

[Bug libstdc++/104080] [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104080

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
This should be fixed now.

[Bug libstdc++/104080] [12 Regression] newlib doesn't have endian.h causing build failure with 2800bc08e4ab r12-6646

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104080

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #7)
> This should be fixed now.

Confirmed (autotester has completed a build at r12-6665-g8f6b62e0f0c9). 
Closing.
Thanks!