[Bug c++/104139] New: [12 Regression] g++.dg/abi/no_unique_address2.C at r12-6028 (a37e8ce3b663)

[Bug c++/104139] New: [12 Regression] g++.dg/abi/no_unique_address2.C at r12-6028 (a37e8ce3b663)

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104139

            Bug ID: 104139
           Summary: [12 Regression] g++.dg/abi/no_unique_address2.C at
                    r12-6028 (a37e8ce3b663)
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ABI
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hp at gcc dot gnu.org
                CC: jason at redhat dot com
  Target Milestone: ---

A patch in the commit range 93faac7e32e4..79a89108dd35, no doubt a37e8ce3b663,
caused g++.dg/abi/no_unique_address2.C to regress for cris-elf.
Judging from
https://gcc.gnu.org/pipermail/gcc-testresults/2022-January/744855.html it's
broken there too.  For cris-elf:

Running /X/gcc/testsuite/g++.dg/dg.exp ...
...
FAIL: g++.dg/abi/no_unique_address2.C  -std=c++14 (test for excess errors)
FAIL: g++.dg/abi/no_unique_address2.C  -std=c++17 (test for excess errors)
FAIL: g++.dg/abi/no_unique_address2.C  -std=c++2a (test for excess errors)

In g++.log:
spawn -ignore SIGHUP /X/obj/gcc/testsuite/g++/../../xg++
-B/X/obj/gcc/testsuite/g++/../../
/X/gccsrc/gcc/testsuite/g++.dg/abi/no_unique_address2.C
-fdiagnostics-plain-output -nostdinc++
-I/X/obj/cris-elf/libstdc++-v3/include/cris-elf
-I/X/obj/cris-elf/libstdc++-v3/include -I/X/gccsrc/libstdc++-v3/libsupc++
-I/X/gccsrc/libstdc++-v3/include/backward
-I/X/gccsrc/libstdc++-v3/testsuite/util -fmessage-length=0 -std=c++14
-pedantic-errors -Wno-long-long -S -isystem
/X/obj/cris-elf/./newlib/targ-include -isystem /X/gccsrc/newlib/libc/include -o
no_unique_address2.s
/X/gccsrc/gcc/testsuite/g++.dg/abi/no_unique_address2.C:43:17: error: static
assertion failed: sizeof (B3) == sizeof (B4)
/X/gccsrc/gcc/testsuite/g++.dg/abi/no_unique_address2.C:41:31: note: in
definition of macro 'SA'
compiler exited with status 1
FAIL: g++.dg/abi/no_unique_address2.C  -std=c++14 (test for excess errors)
Excess errors:
/X/gccsrc/gcc/testsuite/g++.dg/abi/no_unique_address2.C:43:17: error: static
assertion failed: sizeof (B3) == sizeof (B4)

Replacing the last two lines in the source file with
__SIZE_TYPE__ sizes[] = { sizeof (B2), sizeof (B3),  sizeof (B3), sizeof (B4)
};
shows that the sizes are:
        .dword  6
        .dword  6
        .dword  6
        .dword  5
With a build from before the failing commit range (specifically
r12-5824-g8e836af61b70) the sizes as all 6.

[Bug c++/104139] [12 Regression] g++.dg/abi/no_unique_address2.C at r12-6028 (a37e8ce3b663)

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104139

--- Comment #1 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
BTW, cris-elf structure layout is "default packed"; byte boundaries all over.
(I don't know what pru-elf does.)

[Bug c++/104139] [12 Regression] g++.dg/abi/no_unique_address2.C at r12-6028 (a37e8ce3b663)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104139

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0
             Target|                            |cris-elf, pru-elf

[Bug c++/104139] [12 Regression] g++.dg/abi/no_unique_address2.C at r12-6028 (a37e8ce3b663)

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104139

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

[Bug c++/104139] [12 Regression] g++.dg/abi/no_unique_address2.C at r12-6028 (a37e8ce3b663)

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104139

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jason at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org

[Bug c++/104139] [12 Regression] g++.dg/abi/no_unique_address2.C at r12-6028 (a37e8ce3b663)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104139

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:23be9f83bbd2c6f03580757adbfe599de6bf702b

commit r12-6800-g23be9f83bbd2c6f03580757adbfe599de6bf702b
Author: Jason Merrill <jason@redhat.com>
Date:   Fri Jan 21 11:16:49 2022 -0500

    c++: [[no_unique_address]] and virtual base [PR104139]

    Fixing a thinko in my patch for 103681: when computing the size of a
virtual
    base, it would help to use its binfo instead of the one for the derived
    class.

            PR c++/104139
            PR c++/103681

    gcc/cp/ChangeLog:

            * class.cc (end_of_class): Use base_binfo.

    gcc/testsuite/ChangeLog:

            * g++.dg/abi/no_unique_address2.C: Adjust to detect this on x86-64.

[Bug c++/104139] [12 Regression] g++.dg/abi/no_unique_address2.C at r12-6028 (a37e8ce3b663)

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104139

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed.